- Issue created by @luannguyen
- đŸ‡®đŸ‡³India vishal.kadam Mumbai
Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.
- Status changed to Needs work
over 1 year ago 5:18am 16 March 2023 - đŸ‡®đŸ‡³India vishal.kadam Mumbai
Fix phpcs issues → . You can use the PHPCS tool for checking and resolving issues.
- đŸ‡®đŸ‡³India Rashmisoni Bangalore
Fix PHPCS issues. You can use the PHPCS tool for checking and resolving issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml wordsonline_connectorFILE: /Users/projects/drupal-d10/modules/wordsonline_connector/tmgmt_wordsonline.libraries.yml ------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------ 28 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------ FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/tmgmt_wordsonline.links.menu.yml ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 12 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/css/wordsonline.css ------------------------------------------------------------------------------------------------------ FOUND 4 ERRORS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------ 10 | ERROR | [x] CSS colours must be defined in lowercase; expected #01638a but found #01638A 560 | ERROR | [x] Blank lines are not allowed in class definitions 619 | ERROR | [x] Expected 0 spaces before semicolon in style definition; newline found 733 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------ FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/css/global.css ------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 1 | ERROR | [x] Opening brace should be the last content on the line 1 | ERROR | [x] Closing brace of class definition must be on new line ------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/tmgmt_wordsonline.module ----------------------------------------------------------------------------------------------------------------------- FOUND 449 ERRORS AND 18 WARNINGS AFFECTING 281 LINES ----------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 1 | ERROR | [x] Missing file doc comment 3 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement 9 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 10 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1 11 | ERROR | [x] Doc comment short description must start with a capital letter 11 | ERROR | [x] Doc comment short description must end with a full stop 13 | ERROR | [x] Additional blank lines found at end of doc comment 14 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 14 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "request" but expected | | "tmgmt_wordsonline_request" 14 | ERROR | [x] Expected 1 blank line before function; 0 found 14 | ERROR | [x] Expected one space after the comma, 0 found 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 16 | ERROR | [x] Whitespace found at end of line 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [x] Concat operator must be surrounded by a single space 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 21 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 24 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 26 | ERROR | [x] Expected 1 space after IF keyword; 0 found 26 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 26 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 27 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 28 | ERROR | [x] Concat operator must be surrounded by a single space 30 | ERROR | [x] Expected 1 space before "=>"; 0 found 30 | ERROR | [x] Expected 1 space after "=>"; 0 found 30 | WARNING | [x] A comma should follow the last multiline array item. Found: 'ClientAPI' 32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 32 | ERROR | [x] Expected newline after closing brace 32 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 33 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 34 | WARNING | [x] A comma should follow the last multiline array item. Found: 'application/json' 36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 37 | ERROR | [x] Whitespace found at end of line 38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 42 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 43 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 44 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 45 | ERROR | [x] Whitespace found at end of line 46 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 49 | ERROR | [x] Whitespace found at end of line 50 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 59 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 59 | ERROR | [x] Expected 1 blank line after function; 0 found 60 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 61 | ERROR | [x] Doc comment short description must start with a capital letter 61 | ERROR | [x] Doc comment short description must end with a full stop 63 | ERROR | [x] Additional blank lines found at end of doc comment 64 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 64 | ERROR | [ ] Invalid function name, expected get_status_code but found getStatusCode 64 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "getStatusCode" but expected | | "tmgmt_wordsonline_getStatusCode" 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 66 | ERROR | [x] Whitespace found at end of line 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 67 | ERROR | [x] Concat operator must be surrounded by a single space 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 69 | ERROR | [x] Expected 1 space after TRY keyword; newline found 69 | ERROR | [x] Whitespace found at end of line 71 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 71 | ERROR | [x] Space found before semicolon; expected "$params;" but found "$params ;" 72 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 73 | WARNING | [x] A comma should follow the last multiline array item. Found: 'application/x-www-form-urlencoded' 75 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 77 | ERROR | [x] Expected 1 space after closing parenthesis; found 6 77 | ERROR | [x] Whitespace found at end of line 79 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 79 | ERROR | [x] Expected 1 space after closing parenthesis; found 8 79 | ERROR | [x] Whitespace found at end of line 81 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 82 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 83 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 86 | ERROR | [x] Whitespace found at end of line 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 89 | ERROR | [x] Whitespace found at end of line 89 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 92 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 92 | ERROR | [x] Expected 1 blank line after function; 0 found 93 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 94 | ERROR | [x] Doc comment short description must start with a capital letter 94 | ERROR | [x] Doc comment short description must end with a full stop 96 | ERROR | [x] Additional blank lines found at end of doc comment 97 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 97 | ERROR | [ ] Invalid function name, expected get_token but found getToken 97 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "getToken" but expected | | "tmgmt_wordsonline_getToken" 98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 99 | ERROR | [x] Whitespace found at end of line 100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 100 | ERROR | [x] Concat operator must be surrounded by a single space 101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 102 | ERROR | [x] Expected 1 space after TRY keyword; newline found 102 | ERROR | [x] Whitespace found at end of line 104 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 104 | ERROR | [x] Space found before semicolon; expected "$params;" but found "$params ;" 105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 106 | WARNING | [x] A comma should follow the last multiline array item. Found: 'application/x-www-form-urlencoded' 108 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 110 | ERROR | [x] Expected 1 space after closing parenthesis; found 6 110 | ERROR | [x] Whitespace found at end of line 112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 112 | ERROR | [x] Expected 1 space after closing parenthesis; found 8 112 | ERROR | [x] Whitespace found at end of line 114 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 115 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 116 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 117 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 118 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 119 | ERROR | [x] Whitespace found at end of line 120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 122 | ERROR | [x] Whitespace found at end of line 123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 124 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 124 | ERROR | [x] Language constructs must be followed by a single space; expected 1 space but found "··" 125 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 125 | ERROR | [x] Expected 1 blank line after function; 0 found 126 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 127 | ERROR | [x] Doc comment short description must start with a capital letter 127 | ERROR | [x] Doc comment short description must end with a full stop 129 | ERROR | [x] Additional blank lines found at end of doc comment 130 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1 130 | ERROR | [ ] Invalid function name, expected get_quote but found getQuote 130 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "getQuote" but expected | | "tmgmt_wordsonline_getQuote" 130 | ERROR | [x] Expected 0 spaces after opening parenthesis; 1 found 130 | ERROR | [x] There should be no white space after an opening "(" 130 | ERROR | [x] Expected one space after the comma, 0 found 131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 131 | ERROR | [x] Concat operator must be surrounded by a single space 131 | ERROR | [x] Concat operator must be surrounded by a single space 132 | ERROR | [x] Whitespace found at end of line 133 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 135 | ERROR | [x] Concat operator must be surrounded by a single space 137 | ERROR | [x] Expected 1 space before "=>"; 0 found 137 | ERROR | [x] Expected 1 space after "=>"; 0 found 137 | WARNING | [x] A comma should follow the last multiline array item. Found: 'ClientAPI' 139 | ERROR | [x] Expected 1 space before "=>"; 0 found 139 | ERROR | [x] Expected 1 space after "=>"; 0 found 139 | WARNING | [x] A comma should follow the last multiline array item. Found: 3600 142 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 4 143 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 6 144 | ERROR | [x] Whitespace found at end of line 145 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 6 146 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 3 146 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 3 147 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 3 148 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 8 149 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 3 150 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 150 | ERROR | [x] Closing brace indented incorrectly; expected 1 spaces, found 2 150 | ERROR | [x] Expected 1 blank line after function; 0 found 151 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 152 | ERROR | [x] Doc comment short description must start with a capital letter 152 | ERROR | [x] Doc comment short description must end with a full stop 154 | ERROR | [x] Additional blank lines found at end of doc comment 155 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 155 | ERROR | [ ] Invalid function name, expected approve_quote but found ApproveQuote 155 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "ApproveQuote" but expected | | "tmgmt_wordsonline_ApproveQuote" 155 | ERROR | [x] Expected one space after the comma, 0 found 155 | ERROR | [x] Expected one space after the comma, 0 found 155 | ERROR | [x] Expected one space after the comma, 0 found 155 | ERROR | [x] Expected 1 space before opening brace; found 0 156 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 5 156 | ERROR | [x] Concat operator must be surrounded by a single space 157 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 159 | ERROR | [x] Concat operator must be surrounded by a single space 161 | ERROR | [x] Expected 1 space before "=>"; 0 found 161 | ERROR | [x] Expected 1 space after "=>"; 0 found 161 | WARNING | [x] A comma should follow the last multiline array item. Found: 'ClientAPI' 166 | WARNING | [x] A comma should follow the last multiline array item. Found: $action 168 | ERROR | [x] Expected 1 space before "=>"; 0 found 168 | ERROR | [x] Expected 1 space after "=>"; 0 found 168 | WARNING | [x] A comma should follow the last multiline array item. Found: 3600 171 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4 172 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 173 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 173 | ERROR | [x] Expected 1 space after IF keyword; 0 found 173 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 174 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 175 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 176 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 177 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 3 177 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 3 178 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 3 179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8 180 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8 180 | ERROR | [x] Whitespace found at end of line 181 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8 182 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8 182 | ERROR | [x] Expected 1 space after IF keyword; 0 found 182 | ERROR | [x] Expected 1 space before "!="; 0 found 182 | ERROR | [x] Expected 1 space after "!="; 0 found 182 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 182 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 182 | ERROR | [x] There should be no white space before a closing ")" 182 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 183 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10 183 | ERROR | [x] Expected 1 space after "="; 2 found 183 | ERROR | [x] Concat operator must be surrounded by a single space 183 | ERROR | [x] Concat operator must be surrounded by a single space 184 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8 185 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8 185 | ERROR | [x] There should be no white space after an opening "(" 186 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8 187 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 3 188 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 188 | ERROR | [x] Expected 1 blank line after function; 0 found 189 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 190 | ERROR | [x] Doc comment short description must start with a capital letter 190 | ERROR | [x] Doc comment short description must end with a full stop 192 | ERROR | [x] Additional blank lines found at end of doc comment 193 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 193 | ERROR | [ ] Invalid function name, expected get_request_files_list but found getRequestFilesList 193 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "getRequestFilesList" but expected | | "tmgmt_wordsonline_getRequestFilesList" 193 | ERROR | [x] Expected one space after the comma, 0 found 193 | ERROR | [x] Expected 1 space before opening brace; found 0 194 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 194 | ERROR | [x] Concat operator must be surrounded by a single space 194 | ERROR | [x] Concat operator must be surrounded by a single space 194 | ERROR | [x] Concat operator must be surrounded by a single space 195 | ERROR | [x] Whitespace found at end of line 196 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 198 | ERROR | [x] Concat operator must be surrounded by a single space 200 | ERROR | [x] Expected 1 space before "=>"; 0 found 200 | ERROR | [x] Expected 1 space after "=>"; 0 found 200 | WARNING | [x] A comma should follow the last multiline array item. Found: 'ClientAPI' 201 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 203 | ERROR | [x] Whitespace found at end of line 204 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4 205 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 206 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 207 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4 208 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 3 208 | ERROR | [x] Whitespace found at end of line 209 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 209 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 209 | ERROR | [x] Expected one space after the comma, 0 found 209 | ERROR | [x] Expected one space after the comma, 0 found 209 | ERROR | [x] Expected one space after the comma, 0 found 209 | ERROR | [x] Whitespace found at end of line 210 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4 210 | ERROR | [x] Closing brace indented incorrectly; expected 3 spaces, found 4 211 | ERROR | [x] Whitespace found at end of line 212 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 212 | ERROR | [x] Expected 1 blank line after function; 0 found 213 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 214 | ERROR | [x] Doc comment short description must start with a capital letter 214 | ERROR | [x] Doc comment short description must end with a full stop 216 | ERROR | [x] Additional blank lines found at end of doc comment 217 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1 217 | ERROR | [ ] Invalid function name, expected download_file but found downloadFile 217 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "downloadFile" but expected | | "tmgmt_wordsonline_downloadFile" 217 | ERROR | [x] Expected one space after the comma, 0 found 217 | ERROR | [x] Expected one space after the comma, 0 found 217 | ERROR | [x] Expected 1 space before opening brace; found 0 218 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 5 218 | ERROR | [x] Concat operator must be surrounded by a single space 218 | ERROR | [x] Concat operator must be surrounded by a single space 218 | ERROR | [x] Concat operator must be surrounded by a single space 218 | ERROR | [x] Concat operator must be surrounded by a single space 219 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 5 221 | ERROR | [x] Concat operator must be surrounded by a single space 222 | ERROR | [x] Expected 1 space before "=>"; 0 found 222 | ERROR | [x] Expected 1 space after "=>"; 0 found 222 | WARNING | [x] A comma should follow the last multiline array item. Found: 'ClientAPI' 223 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 226 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 3 227 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 6 228 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 6 229 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 3 230 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 3 230 | ERROR | [x] Whitespace found at end of line 231 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 8 231 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 231 | ERROR | [x] Whitespace found at end of line 232 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 2 232 | ERROR | [x] Closing brace indented incorrectly; expected 3 spaces, found 2 233 | ERROR | [x] Whitespace found at end of line 234 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 234 | ERROR | [x] Closing brace indented incorrectly; expected 1 spaces, found 2 234 | ERROR | [x] Expected 1 blank line after function; 0 found 235 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 236 | ERROR | [x] Doc comment short description must start with a capital letter 236 | ERROR | [x] Doc comment short description must end with a full stop 238 | ERROR | [x] Additional blank lines found at end of doc comment 239 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 3 239 | ERROR | [ ] Invalid function name, expected request_action but found requestAction 239 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "requestAction" but expected | | "tmgmt_wordsonline_requestAction" 239 | ERROR | [x] Expected one space after the comma, 0 found 239 | ERROR | [x] Expected one space after the comma, 0 found 239 | ERROR | [x] Expected one space after the comma, 0 found 239 | ERROR | [x] Expected 1 space before opening brace; found 0 240 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 5 240 | ERROR | [x] Concat operator must be surrounded by a single space 241 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 5 243 | ERROR | [x] Concat operator must be surrounded by a single space 245 | ERROR | [x] Expected 1 space before "=>"; 0 found 245 | ERROR | [x] Expected 1 space after "=>"; 0 found 245 | WARNING | [x] A comma should follow the last multiline array item. Found: 'ClientAPI' 250 | WARNING | [x] A comma should follow the last multiline array item. Found: $action 252 | ERROR | [x] Expected 1 space before "=>"; 0 found 252 | ERROR | [x] Expected 1 space after "=>"; 0 found 252 | WARNING | [x] A comma should follow the last multiline array item. Found: 3600 255 | ERROR | [x] Line indented incorrectly; expected -1 spaces, found 4 256 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 6 257 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 6 257 | ERROR | [x] Expected 1 space after IF keyword; 0 found 257 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 258 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 8 259 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 6 260 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 6 261 | ERROR | [x] Line indented incorrectly; expected -1 spaces, found 4 262 | ERROR | [x] Line indented incorrectly; expected -1 spaces, found 4 263 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 6 264 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 6 264 | ERROR | [x] Whitespace found at end of line 265 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 6 266 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 6 266 | ERROR | [x] Expected 1 space after IF keyword; 0 found 266 | ERROR | [x] Expected 1 space before "!="; 0 found 266 | ERROR | [x] Expected 1 space after "!="; 0 found 266 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 266 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 266 | ERROR | [x] There should be no white space before a closing ")" 266 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 267 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 8 267 | ERROR | [x] Expected 1 space after "="; 2 found 267 | ERROR | [x] Concat operator must be surrounded by a single space 267 | ERROR | [x] Concat operator must be surrounded by a single space 268 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 6 269 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 6 269 | ERROR | [x] There should be no white space after an opening "(" 270 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found 6 271 | ERROR | [x] Line indented incorrectly; expected -1 spaces, found 3 271 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 3 272 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 272 | ERROR | [x] Closing brace indented incorrectly; expected 3 spaces, found 2 272 | ERROR | [x] Expected 1 blank line after function; 0 found 273 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 274 | ERROR | [x] Doc comment short description must start with a capital letter 274 | ERROR | [x] Doc comment short description must end with a full stop 276 | ERROR | [x] Additional blank lines found at end of doc comment 277 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 277 | ERROR | [ ] Invalid function name, expected get_error_message but found getErrorMessage 277 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "getErrorMessage" but expected | | "tmgmt_wordsonline_getErrorMessage" 277 | ERROR | [x] Expected 1 space before opening brace; found 0 278 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 279 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 280 | ERROR | [x] Expected 1 space before "="; 0 found 280 | ERROR | [x] Expected 1 space after "="; 0 found 282 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 283 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 284 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 285 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 286 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 287 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 288 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 288 | ERROR | [x] Expected 1 space before "="; 0 found 288 | ERROR | [x] Expected 1 space after "="; 0 found 289 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 290 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 291 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 292 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 293 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 293 | ERROR | [x] Expected 1 space before "="; 0 found 293 | ERROR | [x] Expected 1 space after "="; 0 found 294 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 295 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 296 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 297 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 298 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 299 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 299 | ERROR | [x] Expected 1 space before "="; 0 found 299 | ERROR | [x] Expected 1 space after "="; 0 found 299 | ERROR | [x] Concat operator must be surrounded by a single space 299 | ERROR | [x] Concat operator must be surrounded by a single space 300 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 301 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 302 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 303 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 304 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 305 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 305 | ERROR | [x] Expected 1 space before "="; 0 found 305 | ERROR | [x] Expected 1 space after "="; 0 found 305 | ERROR | [x] Concat operator must be surrounded by a single space 305 | ERROR | [x] Concat operator must be surrounded by a single space 305 | ERROR | [x] Concat operator must be surrounded by a single space 305 | ERROR | [x] Concat operator must be surrounded by a single space 306 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 307 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 308 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 309 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 310 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 311 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 311 | ERROR | [x] Expected 1 space before "="; 0 found 311 | ERROR | [x] Expected 1 space after "="; 0 found 311 | ERROR | [x] Concat operator must be surrounded by a single space 311 | ERROR | [x] Concat operator must be surrounded by a single space 311 | ERROR | [x] Concat operator must be surrounded by a single space 311 | ERROR | [x] Concat operator must be surrounded by a single space 312 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 313 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 314 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 314 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 315 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 315 | ERROR | [x] Expected 1 blank line after function; 0 found 316 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 317 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 317 | ERROR | [x] Doc comment short description must start with a capital letter 317 | ERROR | [x] Doc comment short description must end with a full stop 318 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 319 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 319 | ERROR | [ ] Invalid function name, expected get_request_name but found getRequestName 319 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "getRequestName" but expected | | "tmgmt_wordsonline_getRequestName" 319 | ERROR | [x] Expected 1 space before opening brace; found 0 320 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 321 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 321 | ERROR | [x] Expected 1 space after "="; 0 found 322 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 322 | ERROR | [x] Concat operator must be surrounded by a single space 323 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 323 | ERROR | [x] Expected 1 blank line after function; 0 found 324 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 325 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 326 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 327 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 328 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 330 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 331 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 331 | ERROR | [x] Expected 1 blank line after function; 0 found 332 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 333 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 334 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 335 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 336 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 337 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 340 | ERROR | [x] Concat operator must be surrounded by a single space 341 | ERROR | [x] Case breaking statement indented incorrectly; expected 7 spaces, found 6 342 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 343 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2 343 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 448 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/tmgmt_wordsonline.install ------------------------------------------------------------------------------------------------------------ FOUND 109 ERRORS AND 2 WARNINGS AFFECTING 90 LINES ------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 1 | ERROR | [x] Missing file doc comment 3 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found 3 | ERROR | [x] Doc comment short description must start with a capital letter 4 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found 5 | ERROR | [x] Expected 1 blank line before function; 0 found 6 | ERROR | [x] Short array syntax must be used to define arrays 8 | ERROR | [x] Short array syntax must be used to define arrays 9 | ERROR | [x] Short array syntax must be used to define arrays 14 | ERROR | [x] Short array syntax must be used to define arrays 21 | ERROR | [x] Array indentation error, expected 6 spaces but found 7 21 | ERROR | [x] Short array syntax must be used to define arrays 22 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 23 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 24 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 25 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 26 | ERROR | [x] Array closing indentation error, expected 7 spaces but found 6 27 | ERROR | [x] Array indentation error, expected 6 spaces but found 7 27 | ERROR | [x] Short array syntax must be used to define arrays 28 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 29 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 30 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 31 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 32 | ERROR | [x] Array closing indentation error, expected 7 spaces but found 6 33 | ERROR | [x] Short array syntax must be used to define arrays 34 | ERROR | [x] Array indentation error, expected 8 spaces but found 7 39 | ERROR | [x] Short array syntax must be used to define arrays 45 | ERROR | [x] Whitespace found at end of line 46 | ERROR | [x] Whitespace found at end of line 46 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 49 | ERROR | [x] Short array syntax must be used to define arrays 51 | ERROR | [x] Whitespace found at end of line 52 | ERROR | [x] Short array syntax must be used to define arrays 54 | ERROR | [x] Short array syntax must be used to define arrays 55 | ERROR | [x] Short array syntax must be used to define arrays 60 | ERROR | [x] Short array syntax must be used to define arrays 67 | ERROR | [x] Short array syntax must be used to define arrays 74 | ERROR | [x] Array indentation error, expected 6 spaces but found 7 74 | ERROR | [x] Short array syntax must be used to define arrays 75 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 76 | ERROR | [x] Array indentation error, expected 9 spaces but found 10 77 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 78 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 79 | ERROR | [x] Array closing indentation error, expected 7 spaces but found 6 80 | ERROR | [x] Short array syntax must be used to define arrays 82 | ERROR | [x] Array indentation error, expected 8 spaces but found 10 86 | ERROR | [x] Array indentation error, expected 6 spaces but found 7 86 | ERROR | [x] Short array syntax must be used to define arrays 87 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 88 | ERROR | [x] Array indentation error, expected 9 spaces but found 10 89 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 90 | ERROR | [x] Array indentation error, expected 9 spaces but found 8 91 | ERROR | [x] Array closing indentation error, expected 7 spaces but found 6 92 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 92 | ERROR | [x] Short array syntax must be used to define arrays 93 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 94 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 95 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 96 | ERROR | [x] Array indentation error, expected 10 spaces but found 8 97 | ERROR | [x] Array closing indentation error, expected 8 spaces but found 6 99 | ERROR | [x] Short array syntax must be used to define arrays 101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 101 | ERROR | [x] Short array syntax must be used to define arrays 102 | ERROR | [x] Array indentation error, expected 3 spaces but found 4 103 | ERROR | [x] Array indentation error, expected 3 spaces but found 4 103 | ERROR | [x] Short array syntax must be used to define arrays 104 | ERROR | [x] Short array syntax must be used to define arrays 110 | ERROR | [x] Short array syntax must be used to define arrays 117 | ERROR | [x] Short array syntax must be used to define arrays 123 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 125 | ERROR | [x] Array indentation error, expected 3 spaces but found 4 125 | ERROR | [x] Short array syntax must be used to define arrays 126 | ERROR | [x] Array closing indentation error, expected 1 spaces but found 2 127 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 127 | ERROR | [x] Short array syntax must be used to define arrays 128 | ERROR | [x] Array indentation error, expected 5 spaces but found 4 129 | ERROR | [x] Array indentation error, expected 5 spaces but found 4 129 | ERROR | [x] Short array syntax must be used to define arrays 130 | ERROR | [x] Short array syntax must be used to define arrays 135 | ERROR | [x] Array indentation error, expected 6 spaces but found 9 135 | ERROR | [x] Short array syntax must be used to define arrays 136 | ERROR | [x] Array indentation error, expected 11 spaces but found 8 137 | ERROR | [x] Array indentation error, expected 11 spaces but found 8 138 | ERROR | [x] Array indentation error, expected 11 spaces but found 8 139 | ERROR | [x] Array closing indentation error, expected 9 spaces but found 6 140 | ERROR | [x] Short array syntax must be used to define arrays 147 | ERROR | [x] Short array syntax must be used to define arrays 152 | ERROR | [x] Short array syntax must be used to define arrays 159 | ERROR | [x] Short array syntax must be used to define arrays 167 | ERROR | [x] Array indentation error, expected 5 spaces but found 4 167 | ERROR | [x] Short array syntax must be used to define arrays 167 | ERROR | [x] Expected one space after the comma, 0 found 168 | ERROR | [x] Array closing indentation error, expected 3 spaces but found 2 173 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found 173 | ERROR | [x] Doc comment short description must start with a capital letter 173 | ERROR | [x] Doc comment short description must end with a full stop 174 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found 176 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 178 | ERROR | [x] Array indentation error, expected 4 spaces but found 3 179 | ERROR | [x] Array indentation error, expected 4 spaces but found 3 180 | ERROR | [x] Array indentation error, expected 4 spaces but found 3 183 | ERROR | [x] Expected 1 space after "="; 2 found 184 | ERROR | [x] Expected 1 space after "="; 0 found 185 | ERROR | [x] Expected 1 space after "="; 0 found 186 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 186 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 189 | ERROR | [x] Expected 1 space after "=>"; 0 found 190 | ERROR | [x] Space found before object operator 190 | ERROR | [x] Space found after object operator 190 | WARNING | [x] A comma should follow the last multiline array item. Found: wol_code 200 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 111 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------ FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/tmgmt_wordsonline.routing.yml ---------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 63 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/tmgmt_wordsonline.info.yml ------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 4 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------ 1 | WARNING | [ ] Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | [ ] Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | [ ] Remove "version" from the info file, it will be added by drupal.org packaging automatically 6 | WARNING | [ ] All dependencies must be prefixed with the project name, for example "drupal:" 11 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------ FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/Form/OrderConfirmForm.php -------------------------------------------------------------------------------------------------------- FOUND 415 ERRORS AND 29 WARNINGS AFFECTING 229 LINES -------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] There must be one blank line after the namespace declaration 6 | WARNING | [x] Unused use statement 8 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 12 | WARNING | [x] Unused use statement 14 | WARNING | [x] Unused use statement 15 | WARNING | [x] Unused use statement 16 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 17 | ERROR | [x] Missing class doc comment 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 18 | ERROR | [ ] Class constants must be uppercase; expected FORM_PREFIX but found form_prefix 18 | ERROR | [x] Expected 1 space after "="; 0 found 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 19 | ERROR | [ ] Class constants must be uppercase; expected FORM_SURFIX but found form_surfix 19 | ERROR | [x] Expected 1 space after "="; 0 found 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 20 | ERROR | [ ] Class constants must be uppercase; expected INFO_PREFIX but found info_prefix 20 | ERROR | [x] Expected 1 space after "="; 0 found 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 21 | ERROR | [ ] Class constants must be uppercase; expected INFO_SURFIX but found info_surfix 21 | ERROR | [x] Expected 1 space after "="; 0 found 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 22 | ERROR | [ ] Class constants must be uppercase; expected ACTION_PREFIX but found action_prefix 22 | ERROR | [x] Expected 1 space after "="; 0 found 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 23 | ERROR | [ ] Class constants must be uppercase; expected ACTION_SURFIX but found action_surfix 23 | ERROR | [x] Expected 1 space after "="; 0 found 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Whitespace found at end of line 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Expected 5 space(s) before asterisk; 4 found 34 | ERROR | [x] Expected 5 space(s) before asterisk; 4 found 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Expected one space after the comma, 0 found 35 | ERROR | [x] Incorrect spacing between default value and equals sign for argument "$allowSubmmit"; expected 1 but found 0 35 | ERROR | [x] Whitespace found at end of line 36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 36 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 37 | ERROR | [x] Expected 1 space after "="; 2 found 38 | ERROR | [x] Object operator not indented correctly; expected 8 spaces but found 27 39 | ERROR | [x] Whitespace found at end of line 45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 45 | ERROR | [x] Expected 1 space before "="; 0 found 45 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 46 | WARNING | [ ] Unused variable $status. 46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 46 | ERROR | [x] Expected 1 space after "="; 0 found 47 | WARNING | [ ] Unused variable $rGuid. 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 47 | ERROR | [x] Expected 1 space before "="; 0 found 47 | ERROR | [x] Expected 1 space after "="; 0 found 48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 48 | ERROR | [x] Expected 1 space after IF keyword; 0 found 48 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 48 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 49 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 49 | ERROR | [x] Expected 1 space before "="; 0 found 49 | ERROR | [x] Expected 1 space after "="; 0 found 50 | WARNING | [ ] Unused variable $status. 50 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 51 | WARNING | [ ] Unused variable $rGuid. 51 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 54 | ERROR | [x] Concat operator must be surrounded by a single space 54 | ERROR | [x] Concat operator must be surrounded by a single space 55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 56 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 56 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 57 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 57 | ERROR | [x] Expected 1 space after IF keyword; 0 found 57 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 57 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 58 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 59 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 60 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 61 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 61 | ERROR | [x] Expected 1 space after "="; 0 found 62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 63 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 64 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 64 | ERROR | [x] Expected 1 space after "="; 0 found 64 | ERROR | [x] Whitespace found at end of line 65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 66 | ERROR | [x] Whitespace found at end of line 67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 67 | ERROR | [x] Expected one space after the comma, 0 found 68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 69 | ERROR | [x] Array indentation error, expected 8 spaces but found 16 70 | ERROR | [x] Array closing indentation error, expected 6 spaces but found 10 71 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 71 | ERROR | [x] Expected 1 space after "="; 0 found 71 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 72 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 73 | ERROR | [x] Expected 1 space after IF keyword; 0 found 73 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 74 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 74 | ERROR | [x] Expected 1 space after "="; 2 found 75 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 75 | ERROR | [x] Expected 1 space before "="; 0 found 75 | ERROR | [x] Expected 1 space after "="; 0 found 76 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 76 | ERROR | [x] Expected 1 space after "="; 0 found 77 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 77 | ERROR | [x] Expected 1 space after "="; 0 found 78 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 79 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 79 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 80 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 81 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 81 | ERROR | [x] Expected 1 space after IF keyword; 0 found 81 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 82 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 11 83 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 84 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 84 | ERROR | [x] Expected 1 space after IF keyword; 0 found 84 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 85 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 11 86 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 87 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 88 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 88 | ERROR | [x] Expected 1 space after "="; 0 found 89 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 89 | ERROR | [x] Expected one space after the comma, 0 found 89 | ERROR | [ ] The array declaration extends to column 1156 (the limit is 80). The array content should be split up over multiple lines 89 | ERROR | [x] Expected 1 space between "'@count'" and double arrow; 0 found 89 | ERROR | [x] Expected 1 space between double arrow and "$count"; 0 found 89 | ERROR | [x] Expected 1 space before "=>"; 0 found 89 | ERROR | [x] Expected 1 space after "=>"; 0 found 89 | ERROR | [x] Expected 1 space between comma and "'@source_lang'"; 0 found 89 | ERROR | [x] Expected one space after the comma, 0 found 89 | ERROR | [x] Expected 1 space between "'@source_lang'" and double arrow; 0 found 89 | ERROR | [x] Expected 1 space before "=>"; 0 found 89 | ERROR | [x] Expected 1 space between comma and "'@target_lang'"; 0 found 89 | ERROR | [x] Expected one space after the comma, 0 found 89 | ERROR | [x] Expected 1 space between "'@target_lang'" and double arrow; 0 found 89 | ERROR | [x] Expected 1 space between double arrow and "$target_lang"; 0 found 89 | ERROR | [x] Expected 1 space before "=>"; 0 found 89 | ERROR | [x] Expected 1 space after "=>"; 0 found 89 | ERROR | [x] Expected 1 space between comma and "'@service_level'"; 0 found 89 | ERROR | [x] Expected one space after the comma, 0 found 89 | ERROR | [x] Expected 1 space between "'@service_level'" and double arrow; 0 found 89 | ERROR | [x] Expected 1 space between double arrow and "$service_level"; 0 found 89 | ERROR | [x] Expected 1 space before "=>"; 0 found 89 | ERROR | [x] Expected 1 space after "=>"; 0 found 89 | ERROR | [x] Expected 1 space between comma and "'@content_type'"; 0 found 89 | ERROR | [x] Expected one space after the comma, 0 found 89 | ERROR | [x] Expected 1 space between "'@content_type'" and double arrow; 0 found 89 | ERROR | [x] Expected 1 space between double arrow and "$content_type"; 0 found 89 | ERROR | [x] Expected 1 space before "=>"; 0 found 89 | ERROR | [x] Expected 1 space after "=>"; 0 found 89 | ERROR | [x] Expected 1 space between comma and "'@name'"; 0 found 89 | ERROR | [x] Expected one space after the comma, 0 found 90 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 91 | ERROR | [x] Array indentation error, expected 10 spaces but found 16 93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 93 | ERROR | [x] Closing brace indented incorrectly; expected 6 spaces, found 8 94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 94 | ERROR | [x] Expected one space after the comma, 0 found 95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 96 | ERROR | [x] Array indentation error, expected 10 spaces but found 20 97 | ERROR | [x] Array closing indentation error, expected 8 spaces but found 10 98 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 102 | ERROR | [x] Expected 1 space before "=>"; 0 found 102 | ERROR | [x] Expected 1 space after "=>"; 0 found 105 | WARNING | [x] A comma should follow the last multiline array item. Found: 'onDateChage(this)' 107 | ERROR | [x] Array closing indentation error, expected 8 spaces but found 6 108 | ERROR | [x] Whitespace found at end of line 109 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 111 | ERROR | [x] Expected 1 space after "=>"; 2 found 112 | ERROR | [x] Expected 1 space before "=>"; 0 found 112 | ERROR | [x] Expected 1 space after "=>"; 0 found 114 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 114 | ERROR | [x] Expected one space after the comma, 0 found 115 | ERROR | [x] Whitespace found at end of line 116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 117 | ERROR | [x] Array indentation error, expected 8 spaces but found 16 118 | ERROR | [x] Array closing indentation error, expected 6 spaces but found 10 119 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 120 | ERROR | [x] Expected 1 space after IF keyword; 0 found 120 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 121 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 121 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 122 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 123 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 123 | ERROR | [x] Expected 1 space after IF keyword; 0 found 123 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 123 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 124 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 124 | ERROR | [x] Expected 1 space before "="; 0 found 124 | ERROR | [x] Expected 1 space after "="; 0 found 125 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 125 | ERROR | [x] Expected 1 space before "="; 0 found 125 | ERROR | [x] Expected 1 space after "="; 0 found 126 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 129 | ERROR | [x] Short array syntax must be used to define arrays 131 | ERROR | [x] Expected 1 space before "=>"; 0 found 131 | ERROR | [x] Expected 1 space after "=>"; 0 found 131 | ERROR | [x] Short array syntax must be used to define arrays 131 | ERROR | [x] Expected 1 space between "'class'" and double arrow; 0 found 131 | ERROR | [x] Expected 1 space before "=>"; 0 found 131 | ERROR | [x] Short array syntax must be used to define arrays 131 | ERROR | [x] Expected 1 space between comma and "'btn-layout'"; 0 found 131 | ERROR | [x] Expected one space after the comma, 0 found 131 | ERROR | [x] Expected 1 space between comma and "'btn-text'"; 0 found 131 | ERROR | [x] Expected one space after the comma, 0 found 132 | ERROR | [x] Array closing indentation error, expected 8 spaces but found 6 133 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 136 | ERROR | [x] Expected 1 space after "=>"; 0 found 136 | ERROR | [x] Short array syntax must be used to define arrays 138 | ERROR | [x] Expected 1 space before "=>"; 0 found 138 | ERROR | [x] Expected 1 space after "=>"; 0 found 138 | ERROR | [x] Short array syntax must be used to define arrays 138 | ERROR | [x] Expected 1 space between "'class'" and double arrow; 0 found 138 | ERROR | [x] Expected 1 space before "=>"; 0 found 138 | ERROR | [x] Short array syntax must be used to define arrays 138 | ERROR | [ ] The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines 138 | ERROR | [x] Expected 1 space between comma and "'btn-layout'"; 0 found 138 | ERROR | [x] Expected one space after the comma, 0 found 138 | ERROR | [x] Expected 1 space between comma and "'ml-3'"; 0 found 138 | ERROR | [x] Expected one space after the comma, 0 found 138 | ERROR | [x] Expected 1 space between comma and "'wol-btn'"; 0 found 138 | ERROR | [x] Expected one space after the comma, 0 found 139 | ERROR | [x] Array closing indentation error, expected 8 spaces but found 6 140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 142 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 142 | ERROR | [x] Whitespace found at end of line 143 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 144 | ERROR | [x] Whitespace found at end of line 145 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 145 | ERROR | [x] Expected 1 blank line after function; 0 found 147 | ERROR | [x] Doc comment short description must start with a capital letter 147 | ERROR | [x] Doc comment short description must end with a full stop 149 | ERROR | [x] Additional blank lines found at end of doc comment 150 | ERROR | [x] Visibility must be declared on method "isWeekend" 151 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 152 | ERROR | [x] Expected 1 blank line after function; 0 found 154 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 154 | ERROR | [x] Doc comment short description must start with a capital letter 154 | ERROR | [x] Doc comment short description must end with a full stop 155 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 156 | ERROR | [x] Additional blank lines found at end of doc comment 156 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 158 | ERROR | [x] Whitespace found at end of line 159 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 159 | ERROR | [x] Whitespace found at end of line 160 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 161 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 161 | ERROR | [x] Expected 1 space after "="; 0 found 162 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 162 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 162 | ERROR | [x] Expected one space after the comma, 0 found 162 | ERROR | [x] Expected 1 space between "':job_id'" and double arrow; 0 found 162 | ERROR | [x] Expected 1 space between double arrow and "$job_id"; 0 found 162 | ERROR | [x] Expected 1 space before "=>"; 0 found 162 | ERROR | [x] Expected 1 space after "=>"; 0 found 162 | ERROR | [x] Whitespace found at end of line 163 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 163 | ERROR | [x] Expected 1 space after IF keyword; 0 found 163 | ERROR | [x] Expected 1 space before "=="; 0 found 163 | ERROR | [x] Expected 1 space after "=="; 0 found 163 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 163 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 164 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 164 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 165 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 165 | ERROR | [x] Space found before semicolon; expected "return;" but found "return ;" 166 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 167 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 167 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 167 | ERROR | [x] Whitespace found at end of line 168 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 168 | ERROR | [x] Expected 1 space after IF keyword; 0 found 168 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 168 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 169 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 170 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 171 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 172 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 172 | ERROR | [x] Expected 1 space after "="; 0 found 173 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 174 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 175 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 175 | ERROR | [x] Expected 1 space after "="; 0 found 176 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 177 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 177 | ERROR | [x] Expected 1 space after "="; 0 found 178 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 179 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 180 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 180 | ERROR | [x] Expected 1 space before "/"; 0 found 180 | ERROR | [x] Expected 1 space after "/"; 0 found 181 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 11 181 | ERROR | [x] Expected 1 space after IF keyword; 0 found 181 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 182 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 183 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 183 | ERROR | [x] Closing brace indented incorrectly; expected 11 spaces, found 12 184 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 185 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 186 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 187 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 187 | ERROR | [x] Expected 1 space after IF keyword; 0 found 187 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 188 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 188 | ERROR | [x] Expected 1 space after "="; 2 found 188 | ERROR | [x] Concat operator must be surrounded by a single space 189 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 190 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 190 | ERROR | [x] Concat operator must be surrounded by a single space 191 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 191 | ERROR | [x] Expected 1 space after "="; 3 found 191 | ERROR | [x] Expected one space after the comma, 0 found 191 | ERROR | [x] Expected one space after the comma, 0 found 191 | ERROR | [x] Expected one space after the comma, 0 found 192 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 192 | ERROR | [x] Expected 1 space after IF keyword; 0 found 192 | ERROR | [x] Expected 1 space after "=="; 0 found 192 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 193 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 193 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 194 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 195 | ERROR | [x] Object operator not indented correctly; expected 16 spaces but found 19 195 | ERROR | [x] Whitespace found at end of line 198 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 199 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 200 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 201 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 202 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 202 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 203 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 204 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 205 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 206 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 207 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 208 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 208 | ERROR | [x] Whitespace found at end of line 209 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 209 | ERROR | [x] Expected newline after closing brace 209 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 210 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 210 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 210 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 211 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 212 | ERROR | [x] Whitespace found at end of line 213 | WARNING | [ ] Empty return statement not required here 213 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 214 | ERROR | [x] Expected 1 blank line after function; 0 found 216 | ERROR | [x] Doc comment short description must start with a capital letter 216 | ERROR | [x] Doc comment short description must end with a full stop 218 | ERROR | [x] Additional blank lines found at end of doc comment 220 | ERROR | [x] Whitespace found at end of line 221 | ERROR | [x] Whitespace found at end of line 223 | ERROR | [x] Expected 1 space after "="; 0 found 224 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 224 | ERROR | [x] Expected one space after the comma, 0 found 224 | ERROR | [x] Expected 1 space between "'job_id'" and double arrow; 0 found 224 | ERROR | [x] Expected 1 space between double arrow and "$job_id"; 0 found 224 | ERROR | [x] Expected 1 space before "=>"; 0 found 224 | ERROR | [x] Expected 1 space after "=>"; 0 found 224 | ERROR | [x] Whitespace found at end of line 225 | ERROR | [x] Expected 1 space after IF keyword; 0 found 225 | ERROR | [x] Expected 1 space before "=="; 0 found 225 | ERROR | [x] Expected 1 space after "=="; 0 found 225 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 225 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 227 | ERROR | [x] Expected 1 space after IF keyword; 0 found 227 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 230 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 231 | ERROR | [x] Space found before semicolon; expected "return;" but found "return ;" 233 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 233 | ERROR | [x] Whitespace found at end of line 234 | ERROR | [x] Expected 1 space after IF keyword; 0 found 234 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 234 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 235 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 236 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 237 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 238 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 238 | ERROR | [x] Expected 1 space after "="; 0 found 239 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 240 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 241 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 241 | ERROR | [x] Expected 1 space after "="; 0 found 242 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 242 | ERROR | [x] Expected 1 space after "="; 3 found 242 | ERROR | [x] Expected one space after the comma, 0 found 242 | ERROR | [x] Expected one space after the comma, 0 found 242 | ERROR | [x] Expected one space after the comma, 0 found 243 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 243 | ERROR | [x] Expected 1 space after IF keyword; 0 found 243 | ERROR | [x] Expected 1 space after "=="; 0 found 243 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 244 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 244 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 245 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 246 | ERROR | [x] Object operator not indented correctly; expected 12 spaces but found 15 246 | ERROR | [x] Whitespace found at end of line 248 | ERROR | [x] Whitespace found at end of line 249 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 250 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 250 | ERROR | [x] Expected 1 space after IF keyword; 0 found 250 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 251 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 252 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 253 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 253 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 254 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 255 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 255 | ERROR | [x] Expected newline after closing brace 255 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 256 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 256 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 257 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 257 | ERROR | [x] Space found before semicolon; expected "return;" but found "return ;" 258 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 259 | ERROR | [x] Whitespace found at end of line 260 | ERROR | [x] Expected newline after closing brace 260 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 261 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 261 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 263 | ERROR | [x] Whitespace found at end of line 264 | ERROR | [x] Expected 1 blank line after function; 0 found 266 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 267 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 268 | ERROR | [x] Expected 0 spaces after reference operator for argument "$form"; 1 found 269 | ERROR | [x] Whitespace found at end of line 270 | ERROR | [x] Expected 1 space after "="; 0 found 271 | ERROR | [x] Space found after object operator 272 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 275 | ERROR | [x] Whitespace found at end of line 277 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 278 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 279 | ERROR | [x] Expected 0 spaces after reference operator for argument "$form"; 1 found 279 | ERROR | [x] Whitespace found at end of line 281 | ERROR | [x] Whitespace found at end of line 282 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 414 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/Form/ViewXlfForm.php ------------------------------------------------------------------------------------------------------- FOUND 61 ERRORS AND 15 WARNINGS AFFECTING 49 LINES ------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] There must be one blank line after the namespace declaration 6 | WARNING | [x] Unused use statement 7 | WARNING | [x] Unused use statement 8 | WARNING | [x] Unused use statement 10 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 12 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 14 | WARNING | [x] Unused use statement 15 | WARNING | [x] Unused use statement 16 | WARNING | [x] Unused use statement 17 | WARNING | [x] Unused use statement 17 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 18 | ERROR | [x] Missing class doc comment 18 | ERROR | [x] Expected 1 space before opening brace; found 0 20 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 21 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 22 | ERROR | [x] Expected 1 blank line before function; 0 found 24 | ERROR | [x] Expected 1 blank line after function; 0 found 26 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 27 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 30 | ERROR | [x] Expected 1 space after "="; 0 found 31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 31 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 32 | ERROR | [x] Expected 1 space after "="; 2 found 32 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 33 | ERROR | [x] Whitespace found at end of line 34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 34 | ERROR | [x] Expected one space after the comma, 0 found 34 | ERROR | [x] There should be no white space after an opening "[" 34 | ERROR | [x] Expected 1 space between "'@file'" and double arrow; 0 found 34 | ERROR | [x] Expected 1 space between double arrow and "$downloadIcon"; 0 found 34 | ERROR | [x] Expected 1 space before "=>"; 0 found 34 | ERROR | [x] Expected 1 space after "=>"; 0 found 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 36 | ERROR | [x] Array indentation error, expected 4 spaces but found 6 38 | ERROR | [x] Whitespace found at end of line 39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 39 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 39 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 40 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 40 | ERROR | [x] Short array syntax must be used to define arrays 42 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 42 | WARNING | [ ] Only string literals should be passed to t() where possible 45 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 2 45 | ERROR | [x] Expected one space after the comma, 0 found 45 | ERROR | [ ] The array declaration extends to column 159 (the limit is 80). The array content should be split up over multiple lines 45 | ERROR | [x] Expected 1 space between comma and "'@xml'"; 2 found 45 | ERROR | [x] Expected one space after the comma, 2 found 45 | ERROR | [x] Expected 1 space between "'@xml'" and double arrow; 0 found 45 | ERROR | [x] Expected 1 space between double arrow and "$fi"; 0 found 45 | ERROR | [x] Expected 1 space before "=>"; 0 found 45 | ERROR | [x] Expected 1 space after "=>"; 0 found 46 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 2 47 | ERROR | [x] Array indentation error, expected 4 spaces but found 6 48 | ERROR | [x] Array closing indentation error, expected 2 spaces but found 4 49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 50 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 50 | ERROR | [x] Whitespace found at end of line 51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 52 | ERROR | [x] Closing brace indented incorrectly; expected 2 spaces, found 0 55 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 56 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 57 | ERROR | [x] Expected 0 spaces after reference operator for argument "$form"; 1 found 58 | ERROR | [x] Whitespace found at end of line 60 | ERROR | [x] Whitespace found at end of line 62 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 63 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 64 | ERROR | [x] Expected 0 spaces after reference operator for argument "$form"; 1 found 65 | ERROR | [x] Whitespace found at end of line 67 | ERROR | [x] Expected 1 newline at end of file; 0 found 67 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 71 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/Form/UpdateForm.php -------------------------------------------------------------------------------------------------------- FOUND 127 ERRORS AND 22 WARNINGS AFFECTING 95 LINES -------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] There must be one blank line after the namespace declaration 6 | WARNING | [x] Unused use statement 8 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement 10 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 15 | WARNING | [x] Unused use statement 15 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 16 | ERROR | [x] Missing class doc comment 16 | ERROR | [x] Expected 1 space before opening brace; found 0 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Expected 1 blank line before function; 0 found 22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [x] Expected 1 blank line after function; 0 found 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 25 | ERROR | [x] Expected 7 space(s) before asterisk; 5 found 26 | ERROR | [x] Expected 7 space(s) before asterisk; 5 found 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 29 | ERROR | [x] Array indentation error, expected 8 spaces but found 12 30 | ERROR | [x] Array indentation error, expected 8 spaces but found 12 30 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 31 | ERROR | [x] Array indentation error, expected 8 spaces but found 12 31 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 32 | ERROR | [x] Array indentation error, expected 8 spaces but found 12 33 | ERROR | [x] Array indentation error, expected 8 spaces but found 12 34 | ERROR | [x] Array indentation error, expected 8 spaces but found 12 37 | ERROR | [x] Array closing indentation error, expected 6 spaces but found 10 38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 40 | ERROR | [x] Array indentation error, expected 8 spaces but found 12 41 | ERROR | [x] Array indentation error, expected 8 spaces but found 12 42 | ERROR | [x] Array indentation error, expected 8 spaces but found 12 43 | ERROR | [x] Array closing indentation error, expected 6 spaces but found 8 44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 46 | ERROR | [x] Expected 1 blank line after function; 0 found 48 | ERROR | [x] Doc comment short description must start with a capital letter 48 | ERROR | [x] Doc comment short description must end with a full stop 50 | ERROR | [x] Additional blank lines found at end of doc comment 51 | ERROR | [x] Expected 1 space before opening brace; found 0 52 | ERROR | [x] Expected 1 space after TRY keyword; 0 found 54 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 56 | ERROR | [x] Comments may not appear after statements 56 | ERROR | [x] Inline comments must start with a capital letter 56 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 57 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 57 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 57 | ERROR | [x] There should be no white space after an opening "{" 57 | WARNING | [ ] There must be no blank line following an inline comment 57 | ERROR | [x] Comments may not appear after statements 57 | ERROR | [x] Inline comments must start with a capital letter 57 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 58 | ERROR | [x] Whitespace found at end of line 59 | ERROR | [x] Expected 1 space after IF keyword; 0 found 60 | ERROR | [x] Expected one space after the comma, 0 found 60 | ERROR | [x] Expected one space after the comma, 0 found 61 | ERROR | [x] Inline control structures are not allowed 61 | ERROR | [x] Expected 1 space after IF keyword; 0 found 61 | ERROR | [x] Expected 1 space after "=="; 0 found 62 | ERROR | [x] Comments may not appear after statements 62 | ERROR | [x] Inline comments must start with a capital letter 62 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 63 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 65 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 11 69 | ERROR | [x] Expected newline after closing brace 69 | ERROR | [x] Expected 1 space after CATCH keyword; 0 found 70 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 75 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 75 | ERROR | [x] Doc comment short description must start with a capital letter 75 | ERROR | [x] Doc comment short description must end with a full stop 76 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 77 | ERROR | [x] Additional blank lines found at end of doc comment 77 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 79 | ERROR | [x] Whitespace found at end of line 80 | ERROR | [x] Expected 1 space after TRY keyword; 0 found 81 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 81 | ERROR | [x] Whitespace found at end of line 82 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 83 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 84 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 84 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 84 | ERROR | [x] Expected one space after the comma, 0 found 84 | ERROR | [x] Expected 1 space between "':fid'" and double arrow; 0 found 84 | ERROR | [x] Expected 1 space between double arrow and "$fids"; 0 found 84 | ERROR | [x] Expected 1 space before "=>"; 0 found 84 | ERROR | [x] Expected 1 space after "=>"; 0 found 84 | ERROR | [x] Whitespace found at end of line 85 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 85 | ERROR | [x] Expected 1 space after IF keyword; 0 found 85 | ERROR | [x] Expected 1 space before "!="; 0 found 85 | ERROR | [x] Expected 1 space after "!="; 0 found 85 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 85 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 86 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 11 87 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 11 88 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 11 88 | ERROR | [x] Expected 1 space after "="; 0 found 88 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 88 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 89 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 11 89 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 90 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 11 91 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 91 | ERROR | [x] Whitespace found at end of line 92 | WARNING | [ ] Unused variable $files. 92 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 92 | ERROR | [x] Expected 1 space after "="; 0 found 92 | ERROR | [x] Whitespace found at end of line 93 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 93 | ERROR | [x] Closing brace indented incorrectly; expected 11 spaces, found 14 94 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 95 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 96 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 96 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 97 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 98 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 99 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 100 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 101 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 102 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 103 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 103 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 104 | ERROR | [x] Whitespace found at end of line 105 | ERROR | [x] Expected newline after closing brace 105 | ERROR | [x] Expected 1 space after closing parenthesis; found 6 105 | ERROR | [x] Whitespace found at end of line 107 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 112 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 116 | ERROR | [x] Closing brace indented incorrectly; expected 3 spaces, found 2 119 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 120 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 121 | ERROR | [x] Expected 0 spaces after reference operator for argument "$form"; 1 found 122 | ERROR | [x] Whitespace found at end of line 124 | ERROR | [x] Whitespace found at end of line 126 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 127 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 128 | ERROR | [x] Expected 0 spaces after reference operator for argument "$form"; 1 found 129 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 129 | ERROR | [x] Expected one space after the comma, 0 found 129 | ERROR | [x] Whitespace found at end of line 131 | ERROR | [x] Expected 1 newline at end of file; 0 found 131 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 134 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/WordsOnlineConst.php ----------------------------------------------------------------------------------------------------------- FOUND 73 ERRORS AFFECTING 51 LINES ----------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] There must be one blank line after the namespace declaration 4 | ERROR | [x] Missing class doc comment 4 | ERROR | [x] Expected 1 space before opening brace; found 0 5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 6 | ERROR | [ ] Class constants must be uppercase; expected LANG_CODE_FIELD but found Lang_Code_Field 6 | ERROR | [x] Expected 1 space before "="; 0 found 7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 7 | ERROR | [ ] Class constants must be uppercase; expected LANG_NAME_FIELD but found Lang_Name_Field 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 8 | ERROR | [x] Expected 1 space before "="; 0 found 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 25 | ERROR | [x] Expected 1 space after "="; 0 found 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 26 | ERROR | [x] Expected 1 space before "="; 0 found 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 27 | ERROR | [x] Expected 1 space after "="; 0 found 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 30 | ERROR | [x] The closing brace for the class must have an empty line before it 31 | ERROR | [x] Missing class doc comment 31 | ERROR | [x] Expected 1 space before opening brace; found 0 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Expected 1 space before "="; 0 found 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] The closing brace for the class must have an empty line before it 40 | ERROR | [x] Missing class doc comment 40 | ERROR | [x] Expected 1 space before opening brace; found 0 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | ERROR | [ ] Class constants must be uppercase; expected AUTOMATIONFAILED but found AutomationFailed 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [ ] Class constants must be uppercase; expected QUOTESUBMITTED but found QuoteSubmitted 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 43 | ERROR | [ ] Class constants must be uppercase; expected PAYMENTFAILED but found PaymentFailed 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | ERROR | [ ] Class constants must be uppercase; expected PREPARINGQUOTE but found PreparingQuote 44 | ERROR | [x] Expected 1 space after "="; 0 found 45 | ERROR | [x] The closing brace for the class must have an empty line before it 46 | ERROR | [x] Missing class doc comment 46 | ERROR | [x] Expected 1 space before opening brace; found 0 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 47 | ERROR | [x] Expected 1 space before "="; 0 found 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [ ] Class constants must be uppercase; expected DELIVERED but found Delivered 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 51 | ERROR | [ ] Class constants must be uppercase; expected UNPAID but found Unpaid 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [ ] Class constants must be uppercase; expected QUOTESUBMITTED but found QuoteSubmitted 53 | ERROR | [x] Expected 1 newline at end of file; 0 found 53 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 64 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/WordsOnlineTranslatorUi.php -------------------------------------------------------------------------------------------------------- FOUND 243 ERRORS AND 34 WARNINGS AFFECTING 184 LINES -------------------------------------------------------------------------------------------------------- 9 | WARNING | [x] Unused use statement 10 | WARNING | [x] Unused use statement 12 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 17 | ERROR | [ ] Missing member variable doc comment 18 | ERROR | [ ] Class property $default_service_level should use lowerCamel naming without underscores 18 | ERROR | [ ] Missing member variable doc comment 22 | ERROR | [x] Expected 1 blank line before function; 0 found 25 | WARNING | [ ] Unused variable $translator. 27 | ERROR | [x] Expected 1 space after "="; 2 found 28 | ERROR | [x] Object operator not indented correctly; expected 6 spaces but found 25 33 | ERROR | [x] Expected 1 space after "="; 0 found 33 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 34 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 35 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 36 | ERROR | [x] Expected 1 space after IF keyword; 0 found 36 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 36 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 37 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 9 37 | ERROR | [x] Expected 1 space after "="; 0 found 38 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 9 38 | ERROR | [x] Expected 1 space after "="; 0 found 39 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 9 39 | ERROR | [x] Expected 1 space after "="; 0 found 42 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 43 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 43 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 44 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 44 | ERROR | [x] Expected 1 space after "=>"; 2 found 45 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 45 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 46 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 47 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 48 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 49 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 50 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6 51 | ERROR | [x] Whitespace found at end of line 51 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 52 | ERROR | [x] Whitespace found at end of line 54 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 55 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 55 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 56 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 57 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 57 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 58 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 59 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 60 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 60 | ERROR | [x] Short array syntax must be used to define arrays 61 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 62 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 63 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6 65 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 66 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 66 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 67 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 68 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 68 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 69 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 70 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 71 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 72 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 73 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6 75 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 76 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 76 | ERROR | [x] Expected 1 space after "=>"; 2 found 77 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 77 | ERROR | [x] Expected 1 space before "=>"; 0 found 77 | ERROR | [x] Expected 1 space after "=>"; 0 found 78 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6 80 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 81 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 81 | ERROR | [x] Expected 1 space after "=>"; 2 found 82 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 82 | ERROR | [x] Expected 1 space before "=>"; 0 found 82 | ERROR | [x] Expected 1 space after "=>"; 0 found 83 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6 85 | ERROR | [x] Whitespace found at end of line 88 | ERROR | [x] Expected 1 blank line after function; 0 found 102 | ERROR | [x] Whitespace found at end of line 103 | ERROR | [x] Expected 1 space after TRY keyword; 0 found 104 | ERROR | [x] Whitespace found at end of line 105 | ERROR | [x] Whitespace found at end of line 111 | ERROR | [x] There should be no white space after an opening "(" 111 | ERROR | [x] Expected one space after the comma, 0 found 113 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 113 | WARNING | [ ] Only string literals should be passed to t() where possible 115 | ERROR | [x] Whitespace found at end of line 116 | ERROR | [x] Expected 1 space after IF keyword; 0 found 116 | ERROR | [x] Expected 1 space before "=="; 0 found 116 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 117 | ERROR | [x] Expected 1 space after TRY keyword; 0 found 117 | ERROR | [x] Whitespace found at end of line 118 | ERROR | [ ] Namespaced classes/interfaces/traits should be referenced with use statements 120 | ERROR | [x] Expected 1 space before "="; 0 found 127 | WARNING | [x] A comma should follow the last multiline array item. Found: 'project_key' 129 | ERROR | [x] Expected 1 space before "="; 0 found 134 | ERROR | [x] Expected 1 space after "=>"; 2 found 136 | ERROR | [x] Expected 1 space before "=>"; 0 found 136 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 139 | ERROR | [x] Object operator not indented correctly; expected 12 spaces but found 15 140 | WARNING | [ ] Only string literals should be passed to t() where possible 141 | ERROR | [x] Whitespace found at end of line 142 | ERROR | [x] Expected newline after closing brace 142 | ERROR | [x] Expected 1 space after CATCH keyword; 0 found 142 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 146 | ERROR | [x] Expected newline after closing brace 146 | ERROR | [x] Expected 1 space after closing parenthesis; found 6 146 | ERROR | [x] Whitespace found at end of line 150 | ERROR | [x] Whitespace found at end of line 151 | ERROR | [x] Expected 1 blank line after function; 0 found 158 | ERROR | [x] Expected 1 space after "="; 2 found 160 | WARNING | [ ] Unused variable $triggering_element. 161 | WARNING | [ ] Unused variable $translator_settings. 162 | ERROR | [x] Short array syntax must be used to define arrays 163 | ERROR | [x] Whitespace found at end of line 164 | ERROR | [x] Short array syntax must be used to define arrays 165 | ERROR | [x] Expected 1 space after "="; 0 found 167 | ERROR | [x] Expected 1 space after IF keyword; 0 found 167 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 167 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 171 | ERROR | [x] Expected 1 space after "="; 0 found 174 | ERROR | [x] Expected 1 space after "="; 0 found 175 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 175 | ERROR | [x] Expected 1 space after IF keyword; 0 found 175 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 175 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 176 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 177 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 178 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 178 | ERROR | [x] Expected 1 space after IF keyword; 0 found 178 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 178 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 179 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 179 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 180 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 181 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 182 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 182 | ERROR | [x] Expected 1 space after "="; 0 found 183 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 183 | ERROR | [x] Expected one space after the comma, 0 found 183 | ERROR | [x] Expected one space after the comma, 0 found 184 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 184 | ERROR | [x] Expected 1 space after IF keyword; 0 found 184 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 185 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 185 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 186 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8 186 | ERROR | [x] Expected 1 space after "="; 0 found 187 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 188 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 189 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 190 | ERROR | [x] Expected newline after closing brace 190 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 191 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 198 | ERROR | [x] Expected 1 space before "=>"; 0 found 198 | ERROR | [x] Expected 1 space after "=>"; 0 found 201 | ERROR | [x] Short array syntax must be used to define arrays 202 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 205 | ERROR | [x] Expected 1 space before "=>"; 0 found 205 | ERROR | [x] Expected 1 space after "=>"; 0 found 205 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 210 | ERROR | [x] Expected 1 space after "=>"; 0 found 211 | ERROR | [x] Expected 1 space after "=>"; 0 found 212 | WARNING | [x] A comma should follow the last multiline array item. Found: 'onContentTypeChange(this)' 213 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 217 | ERROR | [x] Space found after object operator 218 | WARNING | [ ] Unused variable $servicesarray. 218 | ERROR | [x] Short array syntax must be used to define arrays 220 | ERROR | [x] Space found after square bracket; expected "["Standard"" but found "[ "Standard"" 221 | ERROR | [x] Space found after square bracket; expected "["Enterprise"" but found "[ "Enterprise"" 223 | ERROR | [x] Short array syntax must be used to define arrays 224 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 227 | ERROR | [x] Expected 1 space after "=>"; 2 found 227 | ERROR | [x] Space found after object operator 230 | WARNING | [x] A comma should follow the last multiline array item. Found: '</div>' 232 | ERROR | [x] Expected 1 space after "="; 2 found 232 | ERROR | [x] Short array syntax must be used to define arrays 233 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 233 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 233 | ERROR | [x] Concat operator must be surrounded by a single space 233 | ERROR | [x] Concat operator must be surrounded by a single space 239 | ERROR | [x] Expected 1 space after "=>"; 2 found 239 | ERROR | [x] Expected one space after the comma, 0 found 239 | ERROR | [x] Comments may not appear after statements 239 | ERROR | [x] No space found before comment text; expected "// date('Y-m-d')," but found "//date('Y-m-d')," 239 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 240 | WARNING | [x] A comma should follow the last multiline array item. Found: "onDateChage(this)" 244 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6 245 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 245 | ERROR | [x] Expected 1 space after "="; 0 found 246 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 246 | ERROR | [x] Expected 1 space after IF keyword; 0 found 246 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 247 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 248 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 249 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 251 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 252 | ERROR | [x] Expected 1 space after "=>"; 2 found 257 | ERROR | [x] Array closing indentation error, expected 6 spaces but found 8 258 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 258 | ERROR | [x] Expected 1 space after "="; 2 found 258 | ERROR | [x] Short array syntax must be used to define arrays 259 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 260 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 261 | ERROR | [x] Whitespace found at end of line 262 | ERROR | [x] Expected 1 space after "=>"; 0 found 265 | ERROR | [x] Array closing indentation error, expected 6 spaces but found 8 266 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 266 | ERROR | [x] Expected 1 space before "="; 0 found 266 | ERROR | [x] Expected 1 space after "="; 0 found 267 | ERROR | [x] Whitespace found at end of line 268 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 268 | ERROR | [x] Expected 1 space after IF keyword; 0 found 268 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 268 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 269 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 269 | ERROR | [x] Expected 1 space after "="; 2 found 269 | ERROR | [x] Short array syntax must be used to define arrays 270 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 271 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 272 | ERROR | [x] Whitespace found at end of line 273 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 276 | ERROR | [x] Array closing indentation error, expected 8 spaces but found 10 277 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 277 | ERROR | [x] Expected newline after closing brace 277 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 278 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 278 | ERROR | [x] Expected 1 space after "="; 2 found 278 | ERROR | [x] Short array syntax must be used to define arrays 279 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 280 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 281 | ERROR | [x] Whitespace found at end of line 285 | ERROR | [x] Array closing indentation error, expected 8 spaces but found 10 286 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 287 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 287 | ERROR | [x] Whitespace found at end of line 288 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 289 | ERROR | [x] Expected 1 blank line after function; 0 found 290 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 291 | ERROR | [x] Doc comment short description must start with a capital letter 291 | ERROR | [x] Doc comment short description must end with a full stop 293 | ERROR | [x] Additional blank lines found at end of doc comment 294 | ERROR | [x] Visibility must be declared on method "getProject" 294 | ERROR | [x] Expected 0 spaces after opening parenthesis; 1 found 294 | ERROR | [x] There should be no white space after an opening "(" 294 | ERROR | [x] Expected one space after the comma, 0 found 294 | ERROR | [ ] Arguments with default values must be at the end of the argument list 294 | ERROR | [x] Expected one space after the comma, 0 found 296 | ERROR | [x] Expected 1 space after "="; 0 found 296 | ERROR | [x] Short array syntax must be used to define arrays 297 | ERROR | [x] Concat operator must be surrounded by a single space 297 | ERROR | [x] Concat operator must be surrounded by a single space 299 | ERROR | [x] Whitespace found at end of line 302 | ERROR | [x] Concat operator must be surrounded by a single space 303 | ERROR | [x] Expected 1 space before "=>"; 0 found 303 | ERROR | [x] Expected 1 space after "=>"; 0 found 306 | ERROR | [x] Expected 1 space before "="; 0 found 308 | ERROR | [x] Whitespace found at end of line 311 | ERROR | [x] Whitespace found at end of line 314 | ERROR | [x] Whitespace found at end of line 324 | ERROR | [x] Expected 1 space after IF keyword; 0 found 324 | ERROR | [x] Expected 1 space after "=="; 0 found 324 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 325 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 326 | ERROR | [x] Expected 1 space after "="; 0 found 326 | ERROR | [x] Expected one space after the comma, 0 found 328 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 329 | ERROR | [x] Expected 1 space after "="; 0 found 331 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 332 | ERROR | [x] Expected 1 space after "="; 0 found 332 | ERROR | [x] Expected one space after the comma, 0 found 337 | ERROR | [x] Expected 1 blank line after function; 0 found 338 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 339 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 340 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 349 | ERROR | [x] Expected 1 newline at end of file; 0 found 349 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 245 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/Entity/WOFile.php ---------------------------------------------------------------------------------------------------------- FOUND 43 ERRORS AFFECTING 27 LINES ---------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 2 | ERROR | [x] There must be one blank line after the namespace declaration 3 | ERROR | [x] Missing class doc comment 4 | ERROR | [x] Opening brace should be on the same line as the declaration 5 | ERROR | [ ] Class property $FileName should use lowerCamel naming without underscores 5 | ERROR | [ ] Missing member variable doc comment 6 | ERROR | [ ] Class property $Content should use lowerCamel naming without underscores 6 | ERROR | [ ] Missing member variable doc comment 7 | ERROR | [x] Missing function doc comment 7 | ERROR | [x] Expected 1 blank line before function; 0 found 8 | ERROR | [x] Opening brace should be on the same line as the declaration 11 | ERROR | [x] Expected 1 blank line after function; 2 found 12 | ERROR | [x] Whitespace found at end of line 13 | ERROR | [x] Whitespace found at end of line 15 | ERROR | [x] Missing class doc comment 15 | ERROR | [x] Expected 1 space before opening brace; found 0 16 | ERROR | [x] Scope keyword "public" must be followed by a single space; found 2 16 | ERROR | [ ] Missing member variable doc comment 16 | ERROR | [x] Space found before semicolon; expected "$sourceLanguage;" but found "$sourceLanguage ;" 17 | ERROR | [x] Scope keyword "public" must be followed by a single space; found 2 17 | ERROR | [ ] Missing member variable doc comment 17 | ERROR | [x] Space found before semicolon; expected "$targetLanguage;" but found "$targetLanguage ;" 18 | ERROR | [x] Missing function doc comment 18 | ERROR | [x] Expected 1 blank line before function; 0 found 19 | ERROR | [x] Opening brace should be on the same line as the declaration 22 | ERROR | [x] Expected 1 blank line after function; 0 found 23 | ERROR | [x] The closing brace for the class must have an empty line before it 24 | ERROR | [x] Missing class doc comment 24 | ERROR | [x] Expected 1 space before opening brace; found 0 25 | ERROR | [x] Scope keyword "public" must be followed by a single space; found 2 25 | ERROR | [ ] Class property $service_name should use lowerCamel naming without underscores 25 | ERROR | [ ] Missing member variable doc comment 25 | ERROR | [x] Space found before semicolon; expected "$service_name;" but found "$service_name ;" 26 | ERROR | [ ] Class property $content_type should use lowerCamel naming without underscores 26 | ERROR | [ ] Missing member variable doc comment 27 | ERROR | [x] Missing function doc comment 27 | ERROR | [x] Expected 1 blank line before function; 0 found 28 | ERROR | [x] Opening brace should be on the same line as the declaration 31 | ERROR | [x] Whitespace found at end of line 32 | ERROR | [x] Expected 1 blank line after function; 0 found 33 | ERROR | [x] The closing brace for the class must have an empty line before it 35 | ERROR | [x] Expected 1 newline at end of file; 0 found 35 | ERROR | [x] A closing tag is not permitted at the end of a PHP file ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 33 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/Entity/WOLLangPair.php ------------------------------------------------------------------------------------------------------------- FOUND 16 ERRORS AFFECTING 9 LINES ------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 4 | ERROR | [x] Missing class doc comment 4 | ERROR | [x] Expected 1 space before opening brace; found 0 5 | ERROR | [x] Scope keyword "public" must be followed by a single space; found 2 5 | ERROR | [ ] Missing member variable doc comment 5 | ERROR | [x] Space found before semicolon; expected "$sourceLanguage;" but found "$sourceLanguage ;" 6 | ERROR | [x] Scope keyword "public" must be followed by a single space; found 2 6 | ERROR | [ ] Missing member variable doc comment 6 | ERROR | [x] Space found before semicolon; expected "$targetLanguage;" but found "$targetLanguage ;" 7 | ERROR | [x] Missing function doc comment 7 | ERROR | [x] Expected 1 blank line before function; 0 found 8 | ERROR | [x] Opening brace should be on the same line as the declaration 11 | ERROR | [x] Expected 1 blank line after function; 0 found 12 | ERROR | [x] The closing brace for the class must have an empty line before it 15 | ERROR | [x] Expected 1 newline at end of file; 0 found 15 | ERROR | [x] A closing tag is not permitted at the end of a PHP file ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/Entity/WOLServiceLevel.php ----------------------------------------------------------------------------------------------------------------- FOUND 17 ERRORS AFFECTING 10 LINES ----------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 4 | ERROR | [x] Missing class doc comment 4 | ERROR | [x] Expected 1 space before opening brace; found 0 5 | ERROR | [x] Scope keyword "public" must be followed by a single space; found 2 5 | ERROR | [ ] Class property $service_name should use lowerCamel naming without underscores 5 | ERROR | [ ] Missing member variable doc comment 5 | ERROR | [x] Space found before semicolon; expected "$service_name;" but found "$service_name ;" 6 | ERROR | [ ] Class property $content_type should use lowerCamel naming without underscores 6 | ERROR | [ ] Missing member variable doc comment 7 | ERROR | [x] Missing function doc comment 7 | ERROR | [x] Expected 1 blank line before function; 0 found 8 | ERROR | [x] Opening brace should be on the same line as the declaration 11 | ERROR | [x] Whitespace found at end of line 12 | ERROR | [x] Expected 1 blank line after function; 0 found 13 | ERROR | [x] The closing brace for the class must have an empty line before it 15 | ERROR | [x] Expected 1 newline at end of file; 0 found 15 | ERROR | [x] A closing tag is not permitted at the end of a PHP file ----------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/Entity/WordsOnlineResponse.php --------------------------------------------------------------------------------------------------------------------- FOUND 17 ERRORS AFFECTING 14 LINES --------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 2 | ERROR | [x] There must be one blank line after the namespace declaration 3 | ERROR | [x] Missing class doc comment 4 | ERROR | [x] Opening brace should be on the same line as the declaration 5 | ERROR | [ ] Missing member variable doc comment 6 | ERROR | [ ] Missing member variable doc comment 7 | ERROR | [ ] Missing member variable doc comment 8 | ERROR | [ ] Missing member variable doc comment 9 | ERROR | [x] Missing function doc comment 9 | ERROR | [x] Expected 1 blank line before function; 0 found 9 | ERROR | [x] Expected one space after the comma, 0 found 10 | ERROR | [x] Opening brace should be on the same line as the declaration 15 | ERROR | [x] Expected 1 blank line after function; 2 found 16 | ERROR | [x] Whitespace found at end of line 17 | ERROR | [x] Whitespace found at end of line 20 | ERROR | [x] Expected 1 newline at end of file; 0 found 20 | ERROR | [x] A closing tag is not permitted at the end of a PHP file --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/Plugin/tmgmt/Translator/WordsOnlineTranslator.php -------------------------------------------------------------------------------------------------------- FOUND 250 ERRORS AND 33 WARNINGS AFFECTING 175 LINES -------------------------------------------------------------------------------------------------------- 6 | WARNING | [x] Unused use statement 8 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 12 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 14 | WARNING | [x] Unused use statement 15 | WARNING | [x] Unused use statement 18 | WARNING | [x] Unused use statement 19 | WARNING | [x] Unused use statement 25 | WARNING | [x] Unused use statement 26 | WARNING | [x] Unused use statement 27 | WARNING | [x] Unused use statement 28 | WARNING | [x] Unused use statement 29 | WARNING | [x] Unused use statement 30 | WARNING | [x] Unused use statement 33 | WARNING | [x] Unused use statement 34 | WARNING | [x] Unused use statement 35 | WARNING | [x] Unused use statement 36 | WARNING | [x] Unused use statement 37 | WARNING | [x] Unused use statement 38 | WARNING | [x] Unused use statement 39 | WARNING | [x] Unused use statement 40 | WARNING | [x] Unused use statement 40 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 56 | ERROR | [x] Data types in @var tags need to be fully namespaced 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 68 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 69 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 70 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 71 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 72 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 73 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 74 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 75 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 76 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 77 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 78 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 78 | ERROR | [ ] Doc comment for parameter $format_manager does not match actual variable name <undefined> 79 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 80 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 81 | ERROR | [x] Expected 1 blank line before function; 0 found 85 | ERROR | [x] Expected 1 blank line after function; 0 found 98 | ERROR | [x] Expected 1 blank line after function; 0 found 99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 100 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 101 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 105 | ERROR | [x] Expected 1 space after "="; 2 found 106 | ERROR | [x] Object operator not indented correctly; expected 6 spaces but found 25 109 | ERROR | [x] Expected 1 space after IF keyword; 0 found 109 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 109 | ERROR | [x] Expected 1 space before ">"; 0 found 109 | ERROR | [x] Expected 1 space after ">"; 0 found 109 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 110 | ERROR | [x] There should be no white space before a closing ")" 111 | ERROR | [x] Expected 1 space after "="; 0 found 112 | ERROR | [x] Expected 1 space before "="; 0 found 112 | ERROR | [x] Expected 1 space after "="; 0 found 113 | ERROR | [x] Inline control structures are not allowed 113 | ERROR | [x] Expected 1 space after IF keyword; 0 found 113 | ERROR | [x] Expected 1 space before "!="; 0 found 113 | ERROR | [x] Expected 1 space after "!="; 0 found 118 | ERROR | [x] Expected 1 blank line after function; 0 found 127 | ERROR | [x] Expected 1 blank line after function; 0 found 128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 129 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 130 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 133 | ERROR | [x] Expected 1 space after "=>"; 0 found 133 | WARNING | [x] A comma should follow the last multiline array item. Found: '' 149 | ERROR | [x] Expected 1 blank line after function; 0 found 170 | ERROR | [ ] Type hint "array" missing for $params 176 | ERROR | [x] Concat operator must be surrounded by a single space 176 | ERROR | [x] Whitespace found at end of line 185 | ERROR | [x] Concat operator must be surrounded by a single space 186 | WARNING | [x] A comma should follow the last multiline array item. Found: 'application/json' 195 | ERROR | [x] Whitespace found at end of line 199 | ERROR | [x] Whitespace found at end of line 203 | ERROR | [x] Whitespace found at end of line 207 | ERROR | [x] Whitespace found at end of line 207 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 208 | ERROR | [x] Whitespace found at end of line 218 | ERROR | [x] Whitespace found at end of line 220 | ERROR | [x] Expected 1 space after IF keyword; 0 found 220 | ERROR | [x] Expected 1 space after "=="; 0 found 220 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 221 | ERROR | [x] Expected 1 space before "="; 0 found 221 | ERROR | [x] Expected 1 space after "="; 0 found 225 | ERROR | [x] Expected 1 blank line after function; 0 found 233 | ERROR | [x] Whitespace found at end of line 234 | ERROR | [x] Expected 1 blank line after function; 0 found 242 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 243 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 244 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 252 | WARNING | [ ] Unused variable $files. 252 | ERROR | [x] Expected 1 space before "="; 0 found 252 | ERROR | [x] Expected 1 space after "="; 0 found 253 | ERROR | [x] Expected 1 space after "="; 0 found 255 | ERROR | [x] Each PHP statement must be on a line by itself 257 | ERROR | [x] Expected 1 space after IF keyword; 0 found 257 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 257 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 258 | ERROR | [x] Expected 1 space after "="; 0 found 259 | ERROR | [x] Whitespace found at end of line 263 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 263 | ERROR | [x] Expected 1 space after IF keyword; 0 found 263 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 264 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 11 265 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 266 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 266 | ERROR | [x] Expected 1 space after IF keyword; 0 found 266 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 267 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 11 268 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 272 | ERROR | [x] Expected 1 space before "="; 0 found 273 | ERROR | [x] Expected 1 space before "="; 0 found 274 | ERROR | [x] Expected 1 space before "="; 0 found 274 | ERROR | [x] Expected 1 space after "="; 0 found 275 | ERROR | [x] Expected 1 space before "="; 0 found 275 | ERROR | [x] Expected 1 space after "="; 0 found 276 | ERROR | [x] Expected 1 space after "="; 0 found 277 | ERROR | [x] Expected 1 space before "="; 0 found 277 | ERROR | [x] Expected 1 space after "="; 0 found 277 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 277 | ERROR | [x] Expected 1 space before "?"; 0 found 277 | ERROR | [x] Expected 1 space before ":"; 0 found 277 | ERROR | [x] Expected 1 space after ":"; 0 found 278 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 279 | ERROR | [x] Expected 1 space after "="; 0 found 280 | ERROR | [x] Whitespace found at end of line 285 | ERROR | [x] Expected one space after the comma, 0 found 289 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 290 | ERROR | [x] Expected 1 space after IF keyword; 0 found 290 | ERROR | [x] There should be no white space after an opening "(" 290 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found 290 | ERROR | [x] Expected 1 space after ">="; 0 found 290 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 293 | ERROR | [x] Concat operator must be surrounded by a single space 295 | ERROR | [x] Expected newline after closing brace 295 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 297 | WARNING | [ ] Unused variable $file. 299 | ERROR | [x] Concat operator must be surrounded by a single space 307 | ERROR | [x] Expected 1 space after "="; 2 found 309 | ERROR | [x] Expected 1 space after "="; 2 found 310 | ERROR | [x] Expected 1 space after "="; 2 found 311 | ERROR | [x] Expected one space after the comma, 0 found 311 | ERROR | [ ] The array declaration extends to column 205 (the limit is 80). The array content should be split up over multiple lines 311 | ERROR | [x] Expected 1 space between double arrow and "$job"; 0 found 311 | ERROR | [x] Expected 1 space after "=>"; 0 found 311 | ERROR | [x] Expected 1 space between comma and "':job_item_id'"; 0 found 311 | ERROR | [x] Expected one space after the comma, 0 found 311 | ERROR | [x] Expected 1 space between double arrow and "$job_item_id"; 0 found 311 | ERROR | [x] Expected 1 space after "=>"; 0 found 311 | ERROR | [x] Whitespace found at end of line 312 | ERROR | [x] Expected 1 space after IF keyword; 0 found 312 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 312 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 313 | ERROR | [x] Expected one space after the comma, 0 found 313 | ERROR | [ ] The array declaration extends to column 195 (the limit is 80). The array content should be split up over multiple lines 313 | ERROR | [x] Expected 1 space between double arrow and "$job"; 0 found 313 | ERROR | [x] Expected 1 space after "=>"; 0 found 313 | ERROR | [x] Expected 1 space between comma and "':job_item_id'"; 0 found 313 | ERROR | [x] Expected one space after the comma, 0 found 313 | ERROR | [x] Expected 1 space between double arrow and "$job_item_id"; 0 found 313 | ERROR | [x] Expected 1 space after "=>"; 0 found 313 | ERROR | [x] Whitespace found at end of line 316 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 13 318 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 319 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 319 | ERROR | [x] Closing brace indented incorrectly; expected 8 spaces, found 10 322 | ERROR | [x] Expected one space after the comma, 0 found 322 | ERROR | [ ] The array declaration extends to column 188 (the limit is 80). The array content should be split up over multiple lines 322 | ERROR | [x] Expected 1 space between double arrow and "$job"; 0 found 322 | ERROR | [x] Expected 1 space after "=>"; 0 found 322 | ERROR | [x] Expected 1 space between comma and "':s'"; 0 found 322 | ERROR | [x] Expected one space after the comma, 0 found 322 | ERROR | [x] Expected 1 space between double arrow and "WordsOnlineConst"; 0 found 322 | ERROR | [x] Expected 1 space after "=>"; 0 found 322 | ERROR | [x] There should be no white space before a closing "]" 322 | ERROR | [x] Whitespace found at end of line 323 | ERROR | [x] Expected 1 space after IF keyword; 0 found 323 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 323 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 324 | ERROR | [x] Expected 1 space before "="; 0 found 324 | ERROR | [x] Expected 1 space after "="; 0 found 325 | ERROR | [x] Expected 1 space before "="; 0 found 325 | ERROR | [x] Expected 1 space after "="; 0 found 326 | ERROR | [x] Expected 1 space before "="; 0 found 326 | ERROR | [x] Expected 1 space after "="; 0 found 331 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 13 334 | ERROR | [x] Expected 1 space before "="; 0 found 334 | ERROR | [x] Expected 1 space after "="; 0 found 335 | ERROR | [x] Whitespace found at end of line 336 | ERROR | [x] Expected 1 space after "="; 0 found 336 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 337 | ERROR | [x] Expected 1 space after IF keyword; 0 found 337 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 337 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 341 | ERROR | [x] Expected 1 space after "="; 0 found 341 | ERROR | [x] Whitespace found at end of line 344 | ERROR | [x] Expected 1 space after "="; 0 found 345 | ERROR | [x] Expected one space after the comma, 0 found 345 | ERROR | [x] Expected one space after the comma, 0 found 345 | ERROR | [x] Concat operator must be surrounded by a single space 345 | ERROR | [x] Expected one space after the comma, 0 found 346 | ERROR | [x] Expected newline after closing brace 346 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 347 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 349 | ERROR | [x] Expected 1 space after IF keyword; 0 found 349 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 349 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 350 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7 353 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 353 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 353 | ERROR | [x] Concat operator must be surrounded by a single space 353 | ERROR | [x] Concat operator must be surrounded by a single space 353 | ERROR | [x] Concat operator must be surrounded by a single space 358 | ERROR | [x] Whitespace found at end of line 361 | ERROR | [x] Expected 1 blank line after function; 0 found 363 | ERROR | [x] Doc comment short description must start with a capital letter 363 | ERROR | [x] Doc comment short description must end with a full stop 365 | ERROR | [x] Additional blank lines found at end of doc comment 366 | ERROR | [x] Visibility must be declared on method "createOrder" 366 | ERROR | [x] Expected one space after the comma, 0 found 366 | ERROR | [ ] Arguments with default values must be at the end of the argument list 366 | ERROR | [x] Expected one space after the comma, 0 found 368 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 369 | ERROR | [x] Concat operator must be surrounded by a single space 370 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 374 | ERROR | [x] Concat operator must be surrounded by a single space 375 | ERROR | [x] Expected 1 space before "=>"; 0 found 375 | ERROR | [x] Expected 1 space after "=>"; 0 found 381 | ERROR | [x] Expected 1 space after "=>"; 2 found 382 | ERROR | [x] There should be no white space after an opening "(" 384 | WARNING | [x] A comma should follow the last multiline array item. Found: '<Content-type header>' 385 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 390 | ERROR | [x] Whitespace found at end of line 394 | ERROR | [x] Whitespace found at end of line 402 | ERROR | [x] Whitespace found at end of line 406 | ERROR | [x] Whitespace found at end of line 409 | ERROR | [x] Expected 1 space after "=>"; 2 found 410 | ERROR | [x] Whitespace found at end of line 414 | ERROR | [x] Whitespace found at end of line 418 | ERROR | [x] Whitespace found at end of line 421 | ERROR | [x] Expected 0 spaces between "]" and comma; 1 found 422 | ERROR | [x] Whitespace found at end of line 426 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 427 | ERROR | [x] Whitespace found at end of line 429 | ERROR | [x] Expected 1 space before "="; 0 found 431 | ERROR | [x] Whitespace found at end of line 437 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 440 | ERROR | [x] Expected 1 space after "="; 0 found 443 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 445 | ERROR | [x] Whitespace found at end of line 446 | ERROR | [x] Expected 1 space after IF keyword; 0 found 446 | ERROR | [x] Expected 1 space after "=="; 0 found 446 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 447 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 449 | ERROR | [x] Object operator not indented correctly; expected 8 spaces but found 11 449 | ERROR | [x] Whitespace found at end of line 450 | ERROR | [ ] The array declaration extends to column 104 (the limit is 80). The array content should be split up over multiple lines 450 | ERROR | [x] Expected 1 space between comma and "'request_guid'"; 0 found 450 | ERROR | [x] Expected one space after the comma, 0 found 450 | ERROR | [x] Expected 1 space between "'request_guid'" and double arrow; 0 found 450 | ERROR | [x] Expected 1 space between double arrow and "$orderResponse"; 0 found 450 | ERROR | [x] Expected 1 space before "=>"; 0 found 450 | ERROR | [x] Expected 1 space after "=>"; 0 found 453 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 454 | ERROR | [x] Expected newline after closing brace 454 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 455 | ERROR | [x] Expected 1 space after IF keyword; 0 found 455 | ERROR | [x] Expected 1 space before "!="; 0 found 455 | ERROR | [x] Expected 1 space after "!="; 0 found 455 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 455 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 455 | ERROR | [x] There should be no white space before a closing ")" 455 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 456 | ERROR | [x] Expected 1 space after "="; 2 found 456 | ERROR | [x] Concat operator must be surrounded by a single space 456 | ERROR | [x] Concat operator must be surrounded by a single space 458 | ERROR | [x] There should be no white space after an opening "(" 460 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 462 | ERROR | [x] Expected 1 newline at end of file; 0 found 462 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 271 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/Controller/UpdateController.php ---------------------------------------------------------------------------------------------------------------------- FOUND 16 ERRORS AND 10 WARNINGS AFFECTING 21 LINES ---------------------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 6 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement 10 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 12 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 14 | WARNING | [x] Unused use statement 15 | WARNING | [x] Unused use statement 16 | WARNING | [x] Unused use statement 16 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 17 | ERROR | [x] Missing class doc comment 19 | ERROR | [x] Doc comment short description must start with a capital letter 19 | ERROR | [x] Doc comment short description must end with a full stop 21 | ERROR | [x] Additional blank lines found at end of doc comment 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Expected 1 blank line before function; 0 found 23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 24 | ERROR | [x] Whitespace found at end of line 25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 26 | ERROR | [x] Whitespace found at end of line 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 28 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 6 29 | ERROR | [x] Expected 1 newline at end of file; 0 found 29 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/Controller/OrderController.php -------------------------------------------------------------------------------------------------------- FOUND 1033 ERRORS AND 58 WARNINGS AFFECTING 477 LINES -------------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 6 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 15 | WARNING | [x] Unused use statement 16 | WARNING | [x] Unused use statement 18 | WARNING | [x] Unused use statement 19 | WARNING | [x] Unused use statement 25 | ERROR | [x] There must be one blank line after the last USE statement; 0 found; 26 | ERROR | [x] Missing class doc comment 29 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 29 | ERROR | [x] Doc comment short description must start with a capital letter 29 | ERROR | [x] Doc comment short description must end with a full stop 30 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 31 | ERROR | [x] Additional blank lines found at end of doc comment 31 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 32 | ERROR | [x] Expected 1 blank line before function; 0 found 39 | ERROR | [x] Line indented incorrectly; expected at least 8 spaces, found 6 40 | ERROR | [x] Line indented incorrectly; expected at least 8 spaces, found 6 41 | ERROR | [x] Whitespace found at end of line 43 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 44 | ERROR | [x] Object operator not indented correctly; expected 8 spaces but found 24 45 | ERROR | [ ] The array declaration extends to column 105 (the limit is 80). The array content should be split up over multiple lines 51 | ERROR | [x] Whitespace found at end of line 52 | ERROR | [x] Expected one space after the comma, 0 found 52 | ERROR | [x] Expected one space after the comma, 0 found 56 | ERROR | [x] Expected 1 blank line after function; 0 found 58 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 58 | ERROR | [x] Doc comment short description must start with a capital letter 58 | ERROR | [x] Doc comment short description must end with a full stop 59 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 60 | ERROR | [x] Additional blank lines found at end of doc comment 60 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 61 | ERROR | [x] Expected 1 space before opening brace; found 0 62 | ERROR | [x] Expected 1 space after "="; 0 found 63 | ERROR | [x] Expected 1 space before "="; 0 found 63 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 64 | ERROR | [x] Expected 1 space after IF keyword; 0 found 64 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 65 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5 65 | ERROR | [x] Expected 1 space after "="; 0 found 67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3 68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3 68 | ERROR | [x] Expected 1 space after "="; 0 found 69 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3 69 | ERROR | [x] Expected 1 space after IF keyword; 0 found 69 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 70 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5 70 | ERROR | [x] Expected 1 space after "="; 0 found 71 | ERROR | [x] Closing brace indented incorrectly; expected 3 spaces, found 4 72 | ERROR | [x] Expected 1 space after IF keyword; 0 found 72 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 73 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7 73 | ERROR | [x] Expected 1 space after "="; 0 found 75 | ERROR | [x] Expected one space after the comma, 0 found 75 | ERROR | [x] Expected one space after the comma, 0 found 76 | ERROR | [x] Expected 1 space after IF keyword; 0 found 76 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 76 | ERROR | [x] There should be no white space before a closing ")" 76 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 78 | ERROR | [x] Whitespace found at end of line 80 | ERROR | [x] Expected 1 space after IF keyword; 0 found 80 | ERROR | [x] Expected 1 space after ">"; 0 found 80 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 81 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 83 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 83 | ERROR | [x] Expected one space after the comma, 0 found 83 | ERROR | [x] Expected 1 space between double arrow and "(string)"; 0 found 83 | ERROR | [x] Expected 1 space after "=>"; 0 found 83 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found 84 | ERROR | [x] Expected 1 space after IF keyword; 0 found 84 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 84 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 87 | ERROR | [x] Expected 1 space after IF keyword; 0 found 87 | ERROR | [x] Expected 1 space after "!="; 0 found 87 | ERROR | [x] There should be no white space before a closing ")" 87 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 89 | ERROR | [x] Object operator not indented correctly; expected 16 spaces but found 19 89 | ERROR | [x] Whitespace found at end of line 92 | ERROR | [x] Expected 1 space after "="; 0 found 95 | ERROR | [x] Expected 1 space after IF keyword; 0 found 95 | ERROR | [x] There should be no white space before a closing ")" 95 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 97 | ERROR | [x] Object operator not indented correctly; expected 16 spaces but found 19 97 | ERROR | [x] Whitespace found at end of line 100 | ERROR | [x] Expected 1 space after "="; 0 found 103 | ERROR | [x] Expected 1 space after IF keyword; 0 found 103 | ERROR | [x] Expected 1 space after closing parenthesis; found 13 105 | ERROR | [x] Expected 1 space after IF keyword; 0 found 105 | ERROR | [x] There should be no white space after an opening "(" 105 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 106 | ERROR | [x] Expected 1 space after "="; 0 found 111 | ERROR | [x] Expected 1 space after IF keyword; 0 found 111 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 113 | ERROR | [x] Expected 1 space after IF keyword; 0 found 113 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 114 | ERROR | [x] Expected 1 space after "="; 0 found 118 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 9 118 | ERROR | [x] Closing brace indented incorrectly; expected 10 spaces, found 9 122 | ERROR | [x] Expected 1 space between ""status"" and double arrow; 0 found 122 | ERROR | [x] Expected 1 space between double arrow and "'success'"; 0 found 122 | ERROR | [x] Expected 1 space before "=>"; 0 found 122 | ERROR | [x] Expected 1 space after "=>"; 0 found 122 | ERROR | [x] Expected 1 space between comma and "'changed'"; 0 found 122 | ERROR | [x] Expected one space after the comma, 0 found 122 | ERROR | [x] Expected 1 space between "'changed'" and double arrow; 0 found 122 | ERROR | [x] Expected 1 space before "=>"; 0 found 123 | ERROR | [x] Expected 1 blank line after function; 0 found 125 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 125 | ERROR | [x] Doc comment short description must start with a capital letter 125 | ERROR | [x] Doc comment short description must end with a full stop 126 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 127 | ERROR | [x] Additional blank lines found at end of doc comment 127 | ERROR | [x] Expected 3 space(s) before asterisk; 2 found 128 | ERROR | [x] Expected 1 space before opening brace; found 0 129 | ERROR | [x] Expected 1 space before "="; 0 found 129 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 130 | ERROR | [x] Expected 1 space after IF keyword; 0 found 130 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 131 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 5 131 | ERROR | [x] Expected 1 space after "="; 0 found 134 | ERROR | [x] Expected 1 space after "="; 0 found 135 | ERROR | [x] Expected 1 space after IF keyword; 0 found 135 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 136 | ERROR | [x] Expected 1 space after "="; 0 found 138 | ERROR | [x] Expected 1 space after IF keyword; 0 found 138 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 139 | ERROR | [x] Expected 1 space after "="; 0 found 145 | ERROR | [x] Expected 1 space after "=>"; 2 found 146 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 149 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 149 | ERROR | [x] Expected 1 space before "=>"; 0 found 150 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 150 | ERROR | [x] Expected 1 space after "=>"; 0 found 150 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 153 | ERROR | [x] Expected one space after the comma, 0 found 153 | ERROR | [x] Expected one space after the comma, 0 found 154 | ERROR | [x] Whitespace found at end of line 155 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 155 | ERROR | [x] Expected 1 space before "="; 0 found 155 | ERROR | [x] Expected 1 space after "="; 0 found 156 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 156 | ERROR | [x] Expected 1 space after "="; 0 found 157 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 157 | ERROR | [x] Expected 1 space after "="; 0 found 158 | ERROR | [x] Expected 1 space after IF keyword; 0 found 158 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 158 | ERROR | [x] There should be no white space before a closing ")" 158 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 161 | ERROR | [x] Expected 1 space after IF keyword; 0 found 161 | ERROR | [x] Expected 1 space before "%"; 0 found 161 | ERROR | [x] Expected 1 space after "%"; 0 found 161 | ERROR | [x] Expected 1 space after ">"; 0 found 161 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 162 | ERROR | [x] Expected 1 space after "="; 0 found 162 | ERROR | [x] Expected 1 space before "/"; 0 found 162 | ERROR | [x] Expected 1 space after "/"; 0 found 162 | ERROR | [x] Expected 1 space before "+"; 0 found 162 | ERROR | [x] Expected 1 space after "+"; 0 found 163 | ERROR | [x] Expected newline after closing brace 163 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 164 | ERROR | [x] Expected 1 space after "="; 0 found 164 | ERROR | [x] Expected 1 space before "/"; 0 found 164 | ERROR | [x] Expected 1 space after "/"; 0 found 166 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 166 | ERROR | [x] Whitespace found at end of line 167 | ERROR | [x] Expected 1 space after IF keyword; 0 found 167 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 167 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 168 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 11 169 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 11 170 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 11 171 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 11 171 | ERROR | [x] Expected 1 space after "="; 0 found 173 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 174 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 177 | ERROR | [x] Expected 1 space after "="; 0 found 178 | ERROR | [x] Expected 1 space after "="; 0 found 179 | ERROR | [x] Expected 1 space after "="; 0 found 180 | ERROR | [x] Expected 1 space after "="; 0 found 182 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 183 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 11 183 | ERROR | [x] Expected 1 space after IF keyword; 0 found 183 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 183 | ERROR | [x] Whitespace found at end of line 186 | ERROR | [x] Expected 1 space after IF keyword; 0 found 186 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 191 | ERROR | [x] Space after closing parenthesis of function call prohibited 191 | ERROR | [x] Space found before semicolon; expected ");" but found ") ;" 193 | ERROR | [x] Expected 1 space after IF keyword; 0 found 193 | ERROR | [x] There should be no white space before a closing ")" 193 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 194 | ERROR | [x] Expected 1 space after IF keyword; 0 found 194 | ERROR | [x] There should be no white space after an opening "(" 194 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 197 | ERROR | [x] Expected 1 space after "="; 0 found 198 | ERROR | [x] Expected one space after the comma, 0 found 198 | ERROR | [x] Expected one space after the comma, 0 found 198 | ERROR | [x] Expected one space after the comma, 0 found 201 | ERROR | [x] Expected 1 space after IF keyword; 0 found 201 | ERROR | [x] Expected 1 space before ">"; 0 found 201 | ERROR | [x] Expected 1 space after ">"; 0 found 201 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 202 | ERROR | [x] Expected 1 space after "="; 2 found 202 | ERROR | [x] Concat operator must be surrounded by a single space 202 | ERROR | [x] Concat operator must be surrounded by a single space 203 | ERROR | [x] Expected newline after closing brace 203 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 204 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 19 204 | ERROR | [x] Expected 1 space after "="; 2 found 204 | ERROR | [x] Concat operator must be surrounded by a single space 204 | ERROR | [x] Concat operator must be surrounded by a single space 204 | ERROR | [x] Concat operator must be surrounded by a single space 204 | ERROR | [x] Concat operator must be surrounded by a single space 204 | ERROR | [x] Concat operator must be surrounded by a single space 207 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces 207 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 207 | ERROR | [x] There should be no white space after an opening "(" 207 | WARNING | [ ] Only string literals should be passed to t() where possible 207 | ERROR | [x] Short array syntax must be used to define arrays 208 | ERROR | [x] Array indentation error, expected 18 spaces but found 17 213 | ERROR | [x] Object operator not indented correctly; expected 18 spaces but found 21 213 | ERROR | [x] Whitespace found at end of line 218 | ERROR | [x] Expected 1 space after IF keyword; 0 found 218 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 220 | ERROR | [x] Object operator not indented correctly; expected 18 spaces but found 21 220 | ERROR | [x] Whitespace found at end of line 224 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 227 | ERROR | [x] Expected 1 space after IF keyword; 0 found 227 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 228 | ERROR | [x] Concat operator must be surrounded by a single space 228 | ERROR | [x] Concat operator must be surrounded by a single space 228 | ERROR | [x] Concat operator must be surrounded by a single space 229 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces 229 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 229 | WARNING | [ ] Only string literals should be passed to t() where possible 229 | ERROR | [x] Short array syntax must be used to define arrays 230 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 230 | ERROR | [x] Expected 1 space after "=>"; 0 found 234 | ERROR | [x] Object operator not indented correctly; expected 18 spaces but found 21 234 | ERROR | [x] Whitespace found at end of line 239 | ERROR | [x] Expected 1 space after IF keyword; 0 found 239 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 239 | ERROR | [x] Whitespace found at end of line 240 | ERROR | [x] Concat operator must be surrounded by a single space 240 | ERROR | [x] Concat operator must be surrounded by a single space 241 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces 241 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 241 | WARNING | [ ] Only string literals should be passed to t() where possible 241 | ERROR | [x] Short array syntax must be used to define arrays 242 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 242 | ERROR | [x] Expected 1 space after "=>"; 0 found 246 | ERROR | [x] Object operator not indented correctly; expected 18 spaces but found 21 246 | ERROR | [x] Whitespace found at end of line 251 | ERROR | [x] Expected 1 space after IF keyword; 0 found 251 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 252 | ERROR | [x] Concat operator must be surrounded by a single space 252 | ERROR | [x] Concat operator must be surrounded by a single space 253 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces 253 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 253 | WARNING | [ ] Only string literals should be passed to t() where possible 253 | ERROR | [x] Short array syntax must be used to define arrays 254 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 254 | ERROR | [x] Expected 1 space after "=>"; 0 found 259 | ERROR | [x] Expected 1 space after IF keyword; 0 found 259 | ERROR | [x] There should be no white space after an opening "(" 259 | ERROR | [x] There should be no white space before a closing ")" 259 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 260 | ERROR | [x] Expected 1 space after IF keyword; 0 found 260 | ERROR | [x] There should be no white space after an opening "(" 260 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 263 | ERROR | [x] Expected 1 space after "="; 0 found 264 | ERROR | [x] Expected one space after the comma, 0 found 264 | ERROR | [x] Expected one space after the comma, 0 found 264 | ERROR | [x] Expected one space after the comma, 0 found 268 | ERROR | [x] Expected 1 space after IF keyword; 0 found 268 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 269 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 269 | ERROR | [x] Expected 1 space before "="; 0 found 269 | ERROR | [x] Expected 1 space after "="; 2 found 269 | ERROR | [x] Concat operator must be surrounded by a single space 269 | ERROR | [x] Concat operator must be surrounded by a single space 270 | ERROR | [x] Expected newline after closing brace 270 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 271 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 21 271 | ERROR | [x] Expected 1 space before "="; 0 found 271 | ERROR | [x] Expected 1 space after "="; 2 found 271 | ERROR | [x] Concat operator must be surrounded by a single space 271 | ERROR | [x] Concat operator must be surrounded by a single space 271 | ERROR | [x] Concat operator must be surrounded by a single space 271 | ERROR | [x] Concat operator must be surrounded by a single space 271 | ERROR | [x] Concat operator must be surrounded by a single space 274 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces 274 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 274 | WARNING | [ ] Only string literals should be passed to t() where possible 274 | ERROR | [x] Short array syntax must be used to define arrays 275 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 275 | ERROR | [x] Expected 1 space after "=>"; 0 found 277 | ERROR | [x] Concat operator must be surrounded by a single space 277 | ERROR | [x] Concat operator must be surrounded by a single space 278 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces 278 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 278 | WARNING | [ ] Only string literals should be passed to t() where possible 278 | ERROR | [x] Short array syntax must be used to define arrays 279 | ERROR | [x] Array indentation error, expected 18 spaces but found 16 279 | ERROR | [x] Expected 1 space after "=>"; 0 found 281 | ERROR | [x] Expected 1 space after "="; 0 found 281 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 281 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 281 | ERROR | [x] Concat operator must be surrounded by a single space 281 | ERROR | [x] Concat operator must be surrounded by a single space 282 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 282 | ERROR | [x] Short array syntax must be used to define arrays 282 | ERROR | [ ] The array declaration extends to column 167 (the limit is 80). The array content should be split up over multiple lines 282 | ERROR | [x] Expected 1 space between comma and "'@linkView'"; 2 found 282 | ERROR | [x] Expected one space after the comma, 2 found 282 | ERROR | [x] Expected 1 space between double arrow and "$download_link"; 0 found 282 | ERROR | [x] Expected 1 space after "=>"; 0 found 282 | ERROR | [x] Expected 1 space between double arrow and "$upload_link"; 0 found 282 | ERROR | [x] Expected 1 space after "=>"; 0 found 286 | ERROR | [x] Expected 1 space after IF keyword; 0 found 286 | ERROR | [x] There should be no white space after an opening "(" 286 | ERROR | [x] Expected 1 space after closing parenthesis; found 15 288 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 288 | ERROR | [x] Expected 1 space after IF keyword; 0 found 288 | ERROR | [x] There should be no white space after an opening "(" 288 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 289 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 289 | ERROR | [x] There should be no white space after an opening "(" 289 | ERROR | [x] There should be no white space before a closing ")" 290 | ERROR | [x] Object operator not indented correctly; expected 22 spaces but found 25 290 | ERROR | [x] Whitespace found at end of line 293 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 294 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 294 | ERROR | [x] Expected 1 space before "="; 0 found 294 | ERROR | [x] Expected 1 space after "="; 0 found 295 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 295 | ERROR | [x] Expected 1 space after "="; 2 found 295 | ERROR | [x] Concat operator must be surrounded by a single space 295 | ERROR | [x] Concat operator must be surrounded by a single space 296 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 296 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces 296 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 296 | WARNING | [ ] Only string literals should be passed to t() where possible 296 | ERROR | [x] Short array syntax must be used to define arrays 297 | ERROR | [x] Array indentation error, expected 20 spaces but found 19 297 | ERROR | [x] Expected 1 space after "=>"; 0 found 299 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 19 299 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 299 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 299 | ERROR | [x] Concat operator must be surrounded by a single space 299 | ERROR | [x] Concat operator must be surrounded by a single space 300 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 19 300 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 300 | ERROR | [x] Short array syntax must be used to define arrays 300 | ERROR | [ ] The array declaration extends to column 170 (the limit is 80). The array content should be split up over multiple lines 300 | ERROR | [x] Expected 1 space between comma and "'@linkView'"; 2 found 300 | ERROR | [x] Expected one space after the comma, 2 found 300 | ERROR | [x] Expected 1 space between double arrow and "$download_link"; 0 found 300 | ERROR | [x] Expected 1 space after "=>"; 0 found 300 | ERROR | [x] Expected 1 space between double arrow and "$upload_link"; 0 found 300 | ERROR | [x] Expected 1 space after "=>"; 0 found 304 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 13 304 | ERROR | [x] Closing brace indented incorrectly; expected 12 spaces, found 13 305 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 305 | ERROR | [x] Closing brace indented incorrectly; expected 11 spaces, found 12 306 | ERROR | [x] Whitespace found at end of line 308 | ERROR | [x] Expected 1 space before "="; 0 found 308 | ERROR | [x] Expected 1 space after "="; 0 found 309 | ERROR | [x] Expected 1 space before "=>"; 0 found 309 | ERROR | [x] Expected 1 space after "=>"; 0 found 310 | ERROR | [x] Expected 1 space after "=>"; 0 found 314 | ERROR | [x] Concat operator must be surrounded by a single space 314 | ERROR | [x] Concat operator must be surrounded by a single space 315 | ERROR | [x] Expected 1 space after "=>"; 0 found 317 | ERROR | [x] Expected 1 space after "=>"; 0 found 317 | WARNING | [x] A comma should follow the last multiline array item. Found: $operation 318 | ERROR | [x] Whitespace found at end of line 320 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 320 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 5 321 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 321 | ERROR | [x] Expected one space after the comma, 0 found 322 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 323 | ERROR | [x] Array indentation error, expected 7 spaces but found 15 324 | ERROR | [x] Array closing indentation error, expected 5 spaces but found 10 325 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 326 | ERROR | [x] Array indentation error, expected 7 spaces but found 6 327 | ERROR | [x] Array indentation error, expected 7 spaces but found 6 328 | ERROR | [x] Array indentation error, expected 7 spaces but found 6 328 | ERROR | [x] Expected 1 space after "=>"; 2 found 329 | ERROR | [x] Array indentation error, expected 7 spaces but found 6 329 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 329 | WARNING | [ ] Only string literals should be passed to t() where possible 330 | ERROR | [x] Array indentation error, expected 7 spaces but found 6 331 | ERROR | [x] Array closing indentation error, expected 5 spaces but found 4 332 | ERROR | [x] Whitespace found at end of line 337 | ERROR | [x] Expected 1 space before "=>"; 0 found 337 | ERROR | [x] Expected 1 space after "=>"; 0 found 337 | ERROR | [x] Short array syntax must be used to define arrays 337 | ERROR | [ ] The array declaration extends to column 106 (the limit is 80). The array content should be split up over multiple lines 337 | ERROR | [x] Expected 1 space between "'class'" and double arrow; 0 found 337 | ERROR | [x] Expected 1 space before "=>"; 0 found 337 | ERROR | [x] Short array syntax must be used to define arrays 337 | ERROR | [x] Expected 1 space between comma and "'btn-layout'"; 0 found 337 | ERROR | [x] Expected one space after the comma, 0 found 337 | ERROR | [x] Expected 1 space between comma and "'ml-3'"; 0 found 337 | ERROR | [x] Expected one space after the comma, 0 found 337 | ERROR | [x] Expected 1 space between comma and "'wol-btn'"; 0 found 337 | ERROR | [x] Expected one space after the comma, 0 found 337 | ERROR | [x] There should be no white space before a closing ")" 337 | ERROR | [x] Expected one space after the comma, 0 found 337 | ERROR | [x] Expected 1 space between "'onclick'" and double arrow; 0 found 337 | ERROR | [x] Expected 1 space between double arrow and "'searchJob()'"; 0 found 337 | ERROR | [x] Expected 1 space before "=>"; 0 found 337 | ERROR | [x] Expected 1 space after "=>"; 0 found 338 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 2 339 | ERROR | [x] Short array syntax must be used to define arrays 341 | ERROR | [x] Space found after square bracket; expected "["15"" but found "[ "15"" 342 | ERROR | [x] Space found after square bracket; expected "["20"" but found "[ "20"" 344 | ERROR | [x] Short array syntax must be used to define arrays 348 | ERROR | [x] Expected 1 space after "=>"; 2 found 350 | ERROR | [x] Expected 1 space before "=>"; 0 found 350 | ERROR | [x] Expected 1 space after "=>"; 0 found 350 | ERROR | [x] Short array syntax must be used to define arrays 350 | ERROR | [x] Expected 1 space between "'onchange'" and double arrow; 0 found 350 | ERROR | [x] Expected 1 space between double arrow and "'changePageLimit()'"; 0 found 350 | ERROR | [x] Expected 1 space before "=>"; 0 found 350 | ERROR | [x] Expected 1 space after "=>"; 0 found 352 | ERROR | [x] Expected one space after the comma, 0 found 354 | ERROR | [x] Array indentation error, expected 6 spaces but found 12 355 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6 356 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 356 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3 357 | ERROR | [x] Array indentation error, expected 5 spaces but found 6 358 | ERROR | [x] Array indentation error, expected 5 spaces but found 6 359 | ERROR | [x] Array indentation error, expected 5 spaces but found 6 360 | ERROR | [x] Array indentation error, expected 5 spaces but found 6 361 | ERROR | [x] Array indentation error, expected 5 spaces but found 6 361 | ERROR | [x] Expected 1 space before "=>"; 0 found 361 | ERROR | [x] Expected 1 space after "=>"; 0 found 361 | ERROR | [x] Short array syntax must be used to define arrays 361 | ERROR | [x] Expected 1 space between "'class'" and double arrow; 0 found 361 | ERROR | [x] Expected 1 space before "=>"; 0 found 361 | ERROR | [x] Short array syntax must be used to define arrays 362 | ERROR | [x] Array closing indentation error, expected 3 spaces but found 4 365 | WARNING | [x] A comma should follow the last multiline array item. Found: 'pager' 367 | ERROR | [x] Expected 1 space after "="; 0 found 368 | ERROR | [x] Expected 1 space after IF keyword; 0 found 368 | ERROR | [x] Expected 1 space before ">"; 0 found 368 | ERROR | [x] Expected 1 space after ">"; 0 found 368 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 369 | ERROR | [x] Expected 1 space after "="; 0 found 369 | ERROR | [x] Concat operator must be surrounded by a single space 370 | ERROR | [x] Expected 1 space after IF keyword; 0 found 370 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 370 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 371 | ERROR | [x] Expected 1 space after "="; 0 found 374 | ERROR | [x] Expected 1 space before "="; 0 found 375 | ERROR | [x] Expected 1 space after IF keyword; 0 found 375 | ERROR | [x] Expected 1 space before "=="; 0 found 375 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 376 | ERROR | [x] Expected 1 space after "="; 0 found 378 | ERROR | [x] Concat operator must be surrounded by a single space 378 | ERROR | [x] Concat operator must be surrounded by a single space 378 | ERROR | [x] Concat operator must be surrounded by a single space 379 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 379 | ERROR | [x] Closing brace indented incorrectly; expected 6 spaces, found 8 380 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 380 | ERROR | [x] Expected 1 space before "="; 0 found 380 | ERROR | [x] Expected 1 space after "="; 0 found 380 | ERROR | [x] Concat operator must be surrounded by a single space 382 | ERROR | [x] Expected 1 space after "="; 0 found 382 | ERROR | [x] Concat operator must be surrounded by a single space 383 | ERROR | [x] Expected one space after the comma, 0 found 385 | ERROR | [x] Array indentation error, expected 6 spaces but found 14 386 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6 387 | ERROR | [x] Whitespace found at end of line 388 | ERROR | [x] Whitespace found at end of line 393 | ERROR | [x] Doc comment short description must start with a capital letter 393 | ERROR | [x] Doc comment short description must end with a full stop 395 | ERROR | [x] Additional blank lines found at end of doc comment 396 | ERROR | [x] Expected 0 spaces after opening parenthesis; 1 found 396 | ERROR | [x] There should be no white space after an opening "(" 396 | ERROR | [x] Expected 0 spaces between argument "$filter" and comma; 1 found 396 | ERROR | [x] Expected one space after the comma, 0 found 396 | ERROR | [x] Expected one space after the comma, 0 found 396 | ERROR | [x] Incorrect spacing between argument "$top" and equals sign; expected 1 but found 0 396 | ERROR | [x] Incorrect spacing between default value and equals sign for argument "$top"; expected 1 but found 0 396 | ERROR | [x] Expected 1 space before opening brace; found 0 397 | ERROR | [x] Expected 1 space before "="; 0 found 397 | ERROR | [x] Expected 1 space after "="; 0 found 398 | ERROR | [x] Expected 1 space after IF keyword; 0 found 398 | ERROR | [x] Expected 1 space before "!="; 0 found 398 | ERROR | [x] Expected 1 space after "!="; 0 found 398 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 398 | ERROR | [x] Expected 1 space before "!="; 0 found 398 | ERROR | [x] Expected 1 space after "!="; 0 found 398 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 399 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7 399 | ERROR | [x] Expected 1 space before "="; 0 found 399 | ERROR | [x] Expected 1 space after "="; 0 found 400 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7 400 | ERROR | [x] Expected 1 space after IF keyword; 0 found 400 | ERROR | [x] Expected 1 space before ">"; 0 found 400 | ERROR | [x] Expected 1 space after ">"; 0 found 400 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 401 | ERROR | [x] Expected 1 space after "="; 0 found 401 | ERROR | [x] Expected 1 space after "-"; 0 found 402 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7 403 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 403 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 5 404 | ERROR | [x] Expected 1 space after "="; 0 found 406 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 406 | ERROR | [x] Whitespace found at end of line 407 | ERROR | [x] Expected 1 space after IF keyword; 0 found 407 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 407 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 408 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 409 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 410 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 411 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 411 | ERROR | [x] Expected 1 space after "="; 0 found 412 | ERROR | [x] Whitespace found at end of line 413 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 414 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 415 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 415 | ERROR | [x] Expected 1 space after "="; 0 found 416 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 416 | ERROR | [x] Concat operator must be surrounded by a single space 416 | ERROR | [x] Concat operator must be surrounded by a single space 416 | ERROR | [x] Concat operator must be surrounded by a single space 416 | ERROR | [x] Concat operator must be surrounded by a single space 416 | ERROR | [x] Concat operator must be surrounded by a single space 417 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 417 | ERROR | [x] Expected 1 space after IF keyword; 0 found 417 | ERROR | [x] Expected 1 space before "!="; 0 found 417 | ERROR | [x] Expected 1 space after "!="; 0 found 417 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 417 | ERROR | [x] Expected 1 space before "!="; 0 found 417 | ERROR | [x] Expected 1 space after "!="; 0 found 417 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 418 | ERROR | [x] Expected 1 space after "="; 0 found 418 | ERROR | [x] Concat operator must be surrounded by a single space 418 | ERROR | [x] Concat operator must be surrounded by a single space 419 | ERROR | [x] Expected 1 space after IF keyword; 0 found 419 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 420 | ERROR | [x] Expected 1 space after "="; 0 found 420 | ERROR | [x] Concat operator must be surrounded by a single space 420 | ERROR | [x] Concat operator must be surrounded by a single space 422 | ERROR | [x] Expected 1 space before "="; 0 found 422 | ERROR | [x] Concat operator must be surrounded by a single space 422 | ERROR | [x] Concat operator must be surrounded by a single space 422 | ERROR | [x] Concat operator must be surrounded by a single space 422 | ERROR | [x] Concat operator must be surrounded by a single space 422 | ERROR | [x] Concat operator must be surrounded by a single space 422 | ERROR | [x] Concat operator must be surrounded by a single space 422 | ERROR | [x] Concat operator must be surrounded by a single space 422 | ERROR | [x] Concat operator must be surrounded by a single space 422 | ERROR | [x] Concat operator must be surrounded by a single space 423 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 424 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 424 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 426 | ERROR | [x] Concat operator must be surrounded by a single space 428 | ERROR | [x] Expected 1 space before "=>"; 0 found 428 | ERROR | [x] Expected 1 space after "=>"; 0 found 428 | WARNING | [x] A comma should follow the last multiline array item. Found: 'ClientAPI' 430 | ERROR | [x] Expected 1 space before "=>"; 0 found 430 | ERROR | [x] Expected 1 space after "=>"; 0 found 430 | WARNING | [x] A comma should follow the last multiline array item. Found: 3600 432 | ERROR | [x] Whitespace found at end of line 433 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 434 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 435 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 435 | ERROR | [x] Expected 1 space after IF keyword; 0 found 435 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 436 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 437 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 438 | ERROR | [x] Whitespace found at end of line 439 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 441 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 442 | ERROR | [x] Whitespace found at end of line 443 | ERROR | [x] Expected 1 blank line after function; 0 found 445 | ERROR | [x] Doc comment short description must start with a capital letter 445 | ERROR | [x] Doc comment short description must end with a full stop 447 | ERROR | [x] Additional blank lines found at end of doc comment 448 | ERROR | [x] Expected 1 space before opening brace; found 0 449 | ERROR | [x] Expected 1 space before "="; 0 found 449 | ERROR | [x] Expected 1 space after "="; 0 found 453 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 453 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 453 | ERROR | [x] Whitespace found at end of line 454 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 454 | ERROR | [x] Expected 1 space after IF keyword; 0 found 454 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 454 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 455 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 456 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 457 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 458 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 458 | ERROR | [x] Expected 1 space after "="; 0 found 458 | ERROR | [x] Whitespace found at end of line 459 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 460 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 461 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 461 | ERROR | [x] Expected 1 space after "="; 0 found 462 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 462 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 462 | ERROR | [x] Expected one space after the comma, 0 found 462 | ERROR | [x] Expected 1 space between double arrow and "$job_id"; 0 found 462 | ERROR | [x] Expected 1 space after "=>"; 0 found 462 | ERROR | [x] Whitespace found at end of line 463 | ERROR | [x] Whitespace found at end of line 464 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 464 | ERROR | [x] Expected 1 space after IF keyword; 0 found 464 | ERROR | [x] Expected 1 space before "!="; 0 found 464 | ERROR | [x] Expected 1 space after "!="; 0 found 464 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 464 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 465 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8 465 | ERROR | [x] Expected 1 space after "="; 2 found 465 | ERROR | [x] Expected one space after the comma, 0 found 466 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8 466 | ERROR | [x] Expected 1 space after IF keyword; 0 found 466 | ERROR | [x] Expected 1 space before "!="; 0 found 466 | ERROR | [x] Expected 1 space after "!="; 0 found 466 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 466 | ERROR | [x] Expected 1 space before "=="; 0 found 466 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 467 | ERROR | [x] Expected 1 space before "="; 0 found 467 | ERROR | [x] Expected 1 space after "="; 0 found 468 | ERROR | [x] Expected 1 space before "="; 0 found 468 | ERROR | [x] Expected 1 space after "="; 0 found 469 | ERROR | [x] Closing brace indented incorrectly; expected 8 spaces, found 10 470 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 471 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 472 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 472 | ERROR | [x] Expected newline after closing brace 472 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 473 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 474 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 475 | ERROR | [x] Expected newline after closing brace 475 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 478 | ERROR | [x] Whitespace found at end of line 479 | ERROR | [x] Expected 1 blank line after function; 0 found 481 | ERROR | [x] Doc comment short description must start with a capital letter 481 | ERROR | [x] Doc comment short description must end with a full stop 483 | ERROR | [x] Additional blank lines found at end of doc comment 484 | ERROR | [ ] Public method name "OrderController::CheckHasFiles" is not in lowerCamel format 484 | ERROR | [x] Expected 1 space before opening brace; found 0 484 | ERROR | [x] Whitespace found at end of line 485 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 485 | ERROR | [x] Whitespace found at end of line 486 | ERROR | [x] Expected 1 space after IF keyword; 0 found 486 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 486 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 487 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 488 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 489 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 490 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 490 | ERROR | [x] Expected 1 space after "="; 0 found 491 | ERROR | [x] Whitespace found at end of line 492 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 493 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 494 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 494 | ERROR | [x] Expected 1 space after "="; 0 found 495 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 495 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 496 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 496 | ERROR | [x] Expected 1 space after "="; 2 found 497 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 498 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 498 | ERROR | [x] Expected one space after the comma, 0 found 498 | ERROR | [ ] The array declaration extends to column 104 (the limit is 80). The array content should be split up over multiple lines 498 | ERROR | [x] Expected 1 space between comma and "WordsOnlineConst"; 0 found 498 | ERROR | [x] Expected one space after the comma, 0 found 498 | ERROR | [x] Expected one space after the comma, 0 found 499 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 499 | ERROR | [x] Expected one space after the comma, 0 found 500 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 501 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 501 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 502 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 502 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 503 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 503 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 504 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 504 | ERROR | [x] Expected one space after the comma, 0 found 505 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 505 | ERROR | [x] Expected 1 space after IF keyword; 0 found 505 | ERROR | [x] Expected 1 space before "!="; 0 found 505 | ERROR | [x] Expected 1 space after "!="; 0 found 505 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 505 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 505 | ERROR | [x] Whitespace found at end of line 506 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 506 | ERROR | [x] Expected 1 space after IF keyword; 0 found 506 | ERROR | [x] Expected 1 space before "!="; 0 found 506 | ERROR | [x] Expected 1 space after "!="; 0 found 506 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 506 | ERROR | [x] Expected 1 space before ">"; 0 found 506 | ERROR | [x] Expected 1 space after ">"; 0 found 506 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 507 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 14 508 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 14 508 | ERROR | [x] Expected 1 space after IF keyword; 0 found 508 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 509 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 509 | ERROR | [x] Expected 1 space after "="; 0 found 510 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 511 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 512 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 513 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 513 | ERROR | [x] Expected 1 space before "="; 0 found 513 | ERROR | [x] Expected 1 space after "="; 0 found 514 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 514 | ERROR | [x] Expected 1 space after IF keyword; 0 found 514 | ERROR | [x] There should be no white space before a closing ")" 514 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 515 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 515 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 516 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 517 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 517 | ERROR | [x] Expected 1 space after IF keyword; 0 found 517 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 517 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 517 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 518 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 518 | ERROR | [x] Expected 1 space before "="; 0 found 518 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 519 | ERROR | [x] Whitespace found at end of line 520 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 521 | ERROR | [x] Object operator not indented correctly; expected 20 spaces but found 23 521 | ERROR | [x] Whitespace found at end of line 525 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 525 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 525 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 526 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 526 | ERROR | [x] Expected 1 space after "="; 0 found 527 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 527 | ERROR | [x] Expected 1 space before "="; 0 found 527 | ERROR | [x] Expected one space after the comma, 0 found 527 | ERROR | [x] Expected one space after the comma, 0 found 528 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 528 | ERROR | [x] Expected 1 space after "="; 0 found 528 | ERROR | [x] Concat operator must be surrounded by a single space 529 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 530 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 530 | ERROR | [x] Expected 1 space after "="; 0 found 531 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 531 | ERROR | [x] Expected 1 space before "="; 0 found 531 | ERROR | [x] Expected 1 space after "="; 0 found 531 | ERROR | [x] Space found before semicolon; expected "fileContent;" but found "fileContent ;" 532 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 532 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 533 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 533 | ERROR | [x] There should be no white space after an opening "(" 533 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 533 | ERROR | [x] There should be no white space after an opening "(" 533 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 534 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 22 534 | ERROR | [x] Expected one space after the comma, 0 found 534 | ERROR | [x] Expected one space after the comma, 0 found 535 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 535 | ERROR | [x] Expected newline after closing brace 535 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 536 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 22 536 | ERROR | [x] Expected 1 space after IF keyword; 0 found 536 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 536 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 537 | ERROR | [x] Line indented incorrectly; expected 22 spaces, found 24 537 | ERROR | [x] Expected one space after the comma, 0 found 537 | ERROR | [x] Expected one space after the comma, 0 found 537 | ERROR | [x] Expected one space after the comma, 0 found 538 | ERROR | [x] Line indented incorrectly; expected 22 spaces, found 24 539 | ERROR | [x] Object operator not indented correctly; expected 26 spaces but found 29 539 | ERROR | [x] Whitespace found at end of line 542 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 22 542 | ERROR | [x] Expected newline after closing brace 542 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 543 | ERROR | [x] Line indented incorrectly; expected 22 spaces, found 24 543 | ERROR | [x] Expected one space after the comma, 0 found 543 | ERROR | [x] Expected one space after the comma, 0 found 543 | ERROR | [x] Expected one space after the comma, 0 found 544 | ERROR | [x] Line indented incorrectly; expected 22 spaces, found 24 545 | ERROR | [x] Object operator not indented correctly; expected 26 spaces but found 29 545 | ERROR | [x] Whitespace found at end of line 548 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 26 548 | ERROR | [x] Closing brace indented incorrectly; expected 22 spaces, found 26 549 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 25 549 | ERROR | [x] Expected 1 space before "="; 0 found 549 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 550 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 24 550 | ERROR | [x] Closing brace indented incorrectly; expected 20 spaces, found 24 551 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 22 551 | ERROR | [x] Closing brace indented incorrectly; expected 18 spaces, found 22 552 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 22 552 | ERROR | [x] Expected 1 space after IF keyword; 0 found 552 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 553 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 24 553 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 554 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 22 555 | ERROR | [x] Whitespace found at end of line 556 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 20 556 | ERROR | [x] Closing brace indented incorrectly; expected 16 spaces, found 20 556 | ERROR | [x] Expected newline after closing brace 556 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 557 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 22 558 | ERROR | [x] Object operator not indented correctly; expected 24 spaces but found 27 558 | ERROR | [x] Whitespace found at end of line 561 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 20 562 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 18 562 | ERROR | [x] Closing brace indented incorrectly; expected 14 spaces, found 18 563 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 16 563 | ERROR | [x] Closing brace indented incorrectly; expected 12 spaces, found 16 564 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 564 | ERROR | [x] Closing brace indented incorrectly; expected 10 spaces, found 12 565 | ERROR | [x] Whitespace found at end of line 566 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 566 | ERROR | [x] Closing brace indented incorrectly; expected 8 spaces, found 10 567 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 567 | ERROR | [x] Expected 1 space between ""status"" and double arrow; 0 found 567 | ERROR | [x] Expected 1 space between double arrow and "'success'"; 0 found 567 | ERROR | [x] Expected 1 space before "=>"; 0 found 567 | ERROR | [x] Expected 1 space after "=>"; 0 found 567 | ERROR | [x] Expected 1 space between comma and "'changed'"; 0 found 567 | ERROR | [x] Expected one space after the comma, 0 found 567 | ERROR | [x] Expected 1 space between "'changed'" and double arrow; 0 found 567 | ERROR | [x] Expected 1 space between double arrow and "$has_change"; 0 found 567 | ERROR | [x] Expected 1 space before "=>"; 0 found 567 | ERROR | [x] Expected 1 space after "=>"; 0 found 568 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 568 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 6 568 | ERROR | [x] Expected newline after closing brace 568 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 569 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 569 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 569 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 570 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 570 | ERROR | [x] Expected 1 space between ""status"" and double arrow; 0 found 570 | ERROR | [x] Expected 1 space between double arrow and "'error'"; 0 found 570 | ERROR | [x] Expected 1 space before "=>"; 0 found 570 | ERROR | [x] Expected 1 space after "=>"; 0 found 570 | ERROR | [x] Expected 1 space between comma and "'changed'"; 0 found 570 | ERROR | [x] Expected one space after the comma, 0 found 570 | ERROR | [x] Expected 1 space between "'changed'" and double arrow; 0 found 570 | ERROR | [x] Expected 1 space before "=>"; 0 found 570 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 571 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 572 | ERROR | [x] Whitespace found at end of line 573 | ERROR | [x] Expected 1 blank line after function; 0 found 589 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 591 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 599 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 601 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 602 | ERROR | [x] Expected 1 blank line after function; 0 found 603 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 604 | ERROR | [x] Expected 1 space(s) before asterisk; 3 found 604 | ERROR | [x] Doc comment short description must start with a capital letter 604 | ERROR | [x] Doc comment short description must end with a full stop 605 | ERROR | [x] Expected 1 space(s) before asterisk; 3 found 606 | ERROR | [x] Additional blank lines found at end of doc comment 606 | ERROR | [x] Expected 1 space(s) before asterisk; 3 found 607 | ERROR | [ ] Public method name "OrderController::sendErrorToWO" is not in lowerCamel format 607 | ERROR | [x] Expected one space after the comma, 0 found 607 | ERROR | [x] Expected one space after the comma, 0 found 607 | ERROR | [x] Expected 1 space before opening brace; found 0 608 | ERROR | [x] Expected 1 space after "="; 3 found 609 | ERROR | [x] Expected one space after the comma, 0 found 609 | ERROR | [x] Expected one space after the comma, 0 found 609 | ERROR | [x] Expected one space after the comma, 0 found 610 | ERROR | [x] Whitespace found at end of line 611 | ERROR | [x] Expected 1 blank line after function; 0 found 613 | ERROR | [x] Doc comment short description must start with a capital letter 613 | ERROR | [x] Doc comment short description must end with a full stop 615 | ERROR | [x] Additional blank lines found at end of doc comment 616 | ERROR | [x] Expected 1 space before opening brace; found 0 619 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 619 | ERROR | [x] Whitespace found at end of line 620 | ERROR | [x] Expected 1 space after IF keyword; 0 found 620 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 620 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 624 | ERROR | [x] Expected 1 space after "="; 0 found 625 | ERROR | [x] Whitespace found at end of line 628 | ERROR | [x] Expected 1 space after "="; 0 found 629 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 629 | ERROR | [x] Expected one space after the comma, 0 found 629 | ERROR | [x] Expected 1 space between "':job_id'" and double arrow; 0 found 629 | ERROR | [x] Expected 1 space between double arrow and "$job_id"; 0 found 629 | ERROR | [x] Expected 1 space before "=>"; 0 found 629 | ERROR | [x] Expected 1 space after "=>"; 0 found 630 | ERROR | [x] Whitespace found at end of line 631 | ERROR | [x] Expected 1 space after IF keyword; 0 found 631 | ERROR | [x] Expected 1 space before "!="; 0 found 631 | ERROR | [x] Expected 1 space after "!="; 0 found 631 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 631 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 631 | ERROR | [x] Whitespace found at end of line 632 | ERROR | [x] Expected one space after the comma, 0 found 633 | ERROR | [x] Expected 1 space after IF keyword; 0 found 633 | ERROR | [x] Expected 1 space before "!="; 0 found 633 | ERROR | [x] Expected 1 space after "!="; 0 found 633 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 633 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 634 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 14 634 | ERROR | [x] Expected 1 space after IF keyword; 0 found 634 | ERROR | [x] Expected 1 space before "!="; 0 found 634 | ERROR | [x] Expected 1 space after "!="; 0 found 634 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 634 | ERROR | [x] Expected 1 space before ">"; 0 found 634 | ERROR | [x] Expected 1 space after ">"; 0 found 634 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 635 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 635 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 636 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 636 | ERROR | [x] Expected 1 space after "="; 0 found 637 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 638 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 638 | ERROR | [x] Expected 1 space after IF keyword; 0 found 638 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 639 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 639 | ERROR | [x] Expected 1 space before "="; 0 found 639 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 640 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 641 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 642 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 643 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 643 | ERROR | [x] Expected 1 space before "="; 0 found 643 | ERROR | [x] Expected 1 space after "="; 0 found 644 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 644 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 644 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 645 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 645 | ERROR | [x] Expected 1 space after "="; 0 found 646 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 646 | ERROR | [x] Expected 1 space before "="; 0 found 646 | ERROR | [x] Expected one space after the comma, 0 found 646 | ERROR | [x] Expected one space after the comma, 0 found 647 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 647 | ERROR | [x] Expected 1 space after "="; 0 found 647 | ERROR | [x] Concat operator must be surrounded by a single space 648 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 649 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 649 | ERROR | [x] Expected 1 space after "="; 0 found 650 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 650 | ERROR | [x] Expected 1 space before "="; 0 found 650 | ERROR | [x] Expected 1 space after "="; 0 found 650 | ERROR | [x] Space found before semicolon; expected "fileContent;" but found "fileContent ;" 651 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 651 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 652 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 652 | ERROR | [x] There should be no white space after an opening "(" 652 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 652 | ERROR | [x] There should be no white space after an opening "(" 652 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 653 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 22 653 | ERROR | [x] Expected one space after the comma, 0 found 653 | ERROR | [x] Expected one space after the comma, 0 found 654 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 654 | ERROR | [x] Expected newline after closing brace 654 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 655 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 22 655 | ERROR | [x] Expected 1 space after IF keyword; 0 found 655 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 655 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 656 | ERROR | [x] Line indented incorrectly; expected 22 spaces, found 24 656 | ERROR | [x] Expected one space after the comma, 0 found 656 | ERROR | [x] Expected one space after the comma, 0 found 656 | ERROR | [x] Expected one space after the comma, 0 found 657 | ERROR | [x] Line indented incorrectly; expected 22 spaces, found 24 658 | ERROR | [x] Object operator not indented correctly; expected 26 spaces but found 29 658 | ERROR | [x] Whitespace found at end of line 661 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 22 661 | ERROR | [x] Expected newline after closing brace 661 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 662 | ERROR | [x] Line indented incorrectly; expected 22 spaces, found 24 662 | ERROR | [x] Expected one space after the comma, 0 found 662 | ERROR | [x] Expected one space after the comma, 0 found 662 | ERROR | [x] Expected one space after the comma, 0 found 663 | ERROR | [x] Line indented incorrectly; expected 22 spaces, found 24 664 | ERROR | [x] Object operator not indented correctly; expected 26 spaces but found 29 664 | ERROR | [x] Whitespace found at end of line 667 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 24 667 | ERROR | [x] Closing brace indented incorrectly; expected 22 spaces, found 24 668 | ERROR | [x] Line indented incorrectly; expected 20 spaces, found 24 668 | ERROR | [x] Expected 1 space before "="; 0 found 668 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 669 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 20 670 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 671 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 671 | ERROR | [x] Expected 1 space after IF keyword; 0 found 671 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 672 | ERROR | [x] Line indented incorrectly; expected 18 spaces, found 24 672 | ERROR | [x] Expected 1 space after "="; 0 found 673 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 18 674 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 675 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 16 675 | ERROR | [x] Expected 1 space between ""status"" and double arrow; 0 found 675 | ERROR | [x] Expected 1 space between double arrow and "$status"; 0 found 675 | ERROR | [x] Expected 1 space before "=>"; 0 found 675 | ERROR | [x] Expected 1 space after "=>"; 0 found 676 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 14 677 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 12 677 | ERROR | [x] Closing brace indented incorrectly; expected 10 spaces, found 12 679 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10 679 | ERROR | [x] Closing brace indented incorrectly; expected 8 spaces, found 10 680 | ERROR | [x] Expected newline after closing brace 680 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 681 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 681 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 684 | ERROR | [x] Expected 1 space between ""status"" and double arrow; 0 found 684 | ERROR | [x] Expected 1 space between double arrow and "'error'"; 0 found 684 | ERROR | [x] Expected 1 space before "=>"; 0 found 684 | ERROR | [x] Expected 1 space after "=>"; 0 found 685 | ERROR | [x] Expected 1 blank line after function; 0 found 687 | ERROR | [x] Doc comment short description must start with a capital letter 687 | ERROR | [x] Doc comment short description must end with a full stop 689 | ERROR | [x] Additional blank lines found at end of doc comment 690 | ERROR | [x] Expected 1 space before opening brace; found 0 694 | ERROR | [x] Whitespace found at end of line 695 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 695 | ERROR | [x] Whitespace found at end of line 696 | ERROR | [x] Expected 1 space after IF keyword; 0 found 696 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 696 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 700 | ERROR | [x] Expected 1 space after "="; 0 found 703 | ERROR | [x] Expected 1 space after "="; 0 found 704 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 704 | ERROR | [x] Expected one space after the comma, 0 found 704 | ERROR | [x] Expected 1 space between double arrow and "$job_id"; 0 found 704 | ERROR | [x] Expected 1 space after "=>"; 0 found 705 | ERROR | [x] Expected 1 space after IF keyword; 0 found 705 | ERROR | [x] Expected 1 space before "!="; 0 found 705 | ERROR | [x] Expected 1 space after "!="; 0 found 705 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 705 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 706 | ERROR | [x] Expected one space after the comma, 0 found 707 | ERROR | [x] Expected 1 space after IF keyword; 0 found 707 | ERROR | [x] Expected 1 space before "!="; 0 found 707 | ERROR | [x] Expected 1 space after "!="; 0 found 707 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 707 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 708 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 11 708 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 708 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 709 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 13 709 | ERROR | [x] Expected 1 space after "="; 0 found 710 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 13 710 | ERROR | [x] Expected 1 space before "="; 0 found 710 | ERROR | [x] Expected one space after the comma, 0 found 710 | ERROR | [x] Expected one space after the comma, 0 found 711 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 13 711 | ERROR | [x] Expected 1 space after "="; 0 found 711 | ERROR | [x] Concat operator must be surrounded by a single space 712 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 13 713 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 13 713 | ERROR | [x] Expected 1 space after "="; 0 found 714 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 13 714 | ERROR | [x] Expected 1 space before "="; 0 found 714 | ERROR | [x] Expected 1 space after "="; 0 found 714 | ERROR | [x] Space found before semicolon; expected "fileContent;" but found "fileContent ;" 715 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 13 715 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 716 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 13 716 | ERROR | [x] Expected 1 space after "="; 0 found 717 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 13 717 | ERROR | [x] There should be no white space after an opening "(" 717 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 717 | ERROR | [x] There should be no white space after an opening "(" 717 | ERROR | [x] There should be no white space before a closing ")" 717 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 718 | ERROR | [x] Line indented incorrectly; expected 16 spaces, found 15 718 | ERROR | [x] Expected 1 space after "="; 3 found 719 | ERROR | [x] Closing brace indented incorrectly; expected 13 spaces, found 14 720 | ERROR | [x] Line indented incorrectly; expected 14 spaces, found 13 720 | ERROR | [x] Expected 1 space after comma in argument list; 2 found 720 | ERROR | [x] Expected one space after the comma, 2 found 721 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 11 722 | ERROR | [x] Whitespace found at end of line 724 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 7 724 | ERROR | [x] Closing brace indented incorrectly; expected 8 spaces, found 7 725 | ERROR | [x] Expected newline after closing brace 725 | ERROR | [x] Expected 1 space after ELSE keyword; 0 found 726 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 726 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 729 | ERROR | [x] Expected one space after the comma, 0 found 730 | ERROR | [x] Whitespace found at end of line 732 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 732 | ERROR | [x] Closing brace indented incorrectly; expected 2 spaces, found 0 732 | ERROR | [x] Expected 1 blank line after function; 0 found 733 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1038 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: /Users/projects/drupal-d10/modules/wordsonline_connector/src/Common/ZipHandle.php ------------------------------------------------------------------------------------- FOUND 230 ERRORS AND 1 WARNING AFFECTING 112 LINES ------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 8 | ERROR | [x] Missing class doc comment 8 | ERROR | [x] Expected 1 space before opening brace; found 0 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 9 | ERROR | [ ] Missing member variable doc comment 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 10 | ERROR | [ ] Missing member variable doc comment 12 | ERROR | [x] Doc comment short description must start with a capital letter 12 | ERROR | [x] Doc comment short description must end with a full stop 14 | ERROR | [x] Additional blank lines found at end of doc comment 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 15 | ERROR | [x] Expected 1 blank line before function; 0 found 16 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 17 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 19 | ERROR | [x] Closing brace indented incorrectly; expected 3 spaces, found 4 19 | ERROR | [x] Expected 1 blank line after function; 0 found 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 21 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 21 | ERROR | [x] Doc comment short description must start with a capital letter 21 | ERROR | [x] Doc comment short description must end with a full stop 22 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 23 | ERROR | [x] Additional blank lines found at end of doc comment 23 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Scope keyword "public" must be followed by a single space; found 2 24 | ERROR | [ ] Public method name "ZipHandle::unzip_file" is not in lowerCamel format 25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 26 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 27 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 29 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 29 | ERROR | [x] Expected 1 space after "="; 0 found 30 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 31 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 31 | ERROR | [x] Expected 1 space before "="; 0 found 31 | ERROR | [x] Expected 1 space after "="; 0 found 31 | ERROR | [x] Expected 1 space before "<"; 0 found 31 | ERROR | [x] Expected 1 space after "<"; 0 found 32 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 33 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 33 | ERROR | [x] Expected 1 space after "="; 0 found 34 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 34 | ERROR | [x] Expected 1 space after "="; 0 found 34 | ERROR | [x] Space after closing parenthesis of function call prohibited 34 | ERROR | [x] Space found before semicolon; expected ");" but found ") ;" 35 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 12 36 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 39 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8 40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 41 | ERROR | [x] Whitespace found at end of line 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Expected 1 blank line after function; 0 found 43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 44 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 44 | ERROR | [x] Doc comment short description must start with a capital letter 44 | ERROR | [x] Doc comment short description must end with a full stop 45 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 46 | ERROR | [x] Additional blank lines found at end of doc comment 46 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 47 | ERROR | [ ] Public method name "ZipHandle::handle_content" is not in lowerCamel format 47 | ERROR | [x] Expected 1 space before opening brace; found 0 48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 48 | ERROR | [x] Expected 1 space after IF keyword; 0 found 48 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 48 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 49 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 50 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 52 | ERROR | [x] Space found before comma in argument list 53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 53 | ERROR | [x] Space found before comma in argument list 54 | ERROR | [x] Whitespace found at end of line 55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 56 | ERROR | [x] Expected 1 blank line after function; 0 found 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found 58 | ERROR | [x] Doc comment short description must start with a capital letter 58 | ERROR | [x] Doc comment short description must end with a full stop 59 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found 60 | ERROR | [x] Additional blank lines found at end of doc comment 60 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [ ] Public method name "ZipHandle::replace_bpt" is not in lowerCamel format 61 | ERROR | [x] Incorrect spacing between default value and equals sign for argument "$index"; expected 1 but found 0 61 | ERROR | [x] Expected 1 space before opening brace; found 0 62 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10 62 | ERROR | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces 62 | ERROR | [x] Expected one space after the comma, 0 found 62 | ERROR | [x] Expected one space after the comma, 0 found 63 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10 63 | ERROR | [x] Expected 1 space after IF keyword; 0 found 63 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 64 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 64 | ERROR | [x] Expected one space after the comma, 0 found 64 | ERROR | [x] Expected one space after the comma, 0 found 65 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 65 | ERROR | [x] Expected one space after the comma, 0 found 65 | ERROR | [x] Expected 1 space after "+"; 0 found 66 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 67 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 67 | ERROR | [x] Expected 1 space after "-"; 0 found 68 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 68 | ERROR | [x] Expected one space after the comma, 0 found 69 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 70 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 70 | ERROR | [x] Expected 1 space after IF keyword; 0 found 70 | ERROR | [x] Expected 1 space after "+"; 0 found 70 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 71 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 71 | ERROR | [x] Expected 1 space after "="; 0 found 72 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 72 | ERROR | [x] Expected 1 space after FOR keyword; 0 found 72 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 73 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 73 | ERROR | [x] Expected 1 space after IF keyword; 0 found 73 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 74 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 74 | ERROR | [x] Expected one space after the comma, 0 found 74 | ERROR | [x] Expected one space after the comma, 0 found 74 | ERROR | [x] Expected 1 space before "+"; 0 found 74 | ERROR | [x] Expected 1 space after "+"; 0 found 74 | ERROR | [x] Concat operator must be surrounded by a single space 74 | ERROR | [x] Expected one space after the comma, 0 found 75 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 76 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 77 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 77 | ERROR | [x] Expected 1 space after IF keyword; 0 found 77 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 78 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 78 | ERROR | [x] Expected one space after the comma, 0 found 78 | ERROR | [x] Expected one space after the comma, 0 found 78 | ERROR | [x] Expected 1 space before "+"; 0 found 78 | ERROR | [x] Expected 1 space after "+"; 0 found 78 | ERROR | [x] Concat operator must be surrounded by a single space 78 | ERROR | [x] Expected one space after the comma, 0 found 79 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24 80 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20 81 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 82 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 82 | ERROR | [x] Expected one space after the comma, 0 found 82 | ERROR | [x] Expected one space after the comma, 0 found 82 | ERROR | [x] Expected one space after the comma, 0 found 83 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 84 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 85 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10 88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 88 | ERROR | [x] Expected 1 blank line after function; 0 found 89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 90 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 90 | ERROR | [x] Doc comment short description must start with a capital letter 90 | ERROR | [x] Doc comment short description must end with a full stop 91 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 92 | ERROR | [x] Additional blank lines found at end of doc comment 92 | ERROR | [x] Expected 4 space(s) before asterisk; 3 found 93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 93 | ERROR | [ ] Public method name "ZipHandle::replace_ept" is not in lowerCamel format 93 | ERROR | [x] Incorrect spacing between default value and equals sign for argument "$index"; expected 1 but found 0 93 | ERROR | [x] Expected 1 space before opening brace; found 0 94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 94 | ERROR | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces 94 | ERROR | [x] Expected one space after the comma, 0 found 94 | ERROR | [x] Expected one space after the comma, 0 found 95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 95 | ERROR | [x] Expected 1 space after IF keyword; 0 found 95 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 96 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 96 | ERROR | [x] Expected one space after the comma, 0 found 96 | ERROR | [x] Expected one space after the comma, 0 found 97 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 97 | ERROR | [x] Expected one space after the comma, 0 found 97 | ERROR | [x] Expected 1 space after "+"; 0 found 98 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 99 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 99 | ERROR | [x] Expected 1 space after "-"; 0 found 100 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 100 | ERROR | [x] Expected one space after the comma, 0 found 101 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 102 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 102 | ERROR | [x] Expected 1 space after IF keyword; 0 found 102 | ERROR | [x] Expected 1 space after "+"; 0 found 102 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 103 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 103 | ERROR | [x] Expected 1 space after "="; 0 found 104 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 104 | ERROR | [x] Expected 1 space after FOR keyword; 0 found 104 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 105 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 18 105 | ERROR | [x] Expected 1 space after IF keyword; 0 found 105 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 106 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 22 106 | ERROR | [x] Expected one space after the comma, 0 found 106 | ERROR | [x] Expected one space after the comma, 0 found 106 | ERROR | [x] Expected 1 space before "+"; 0 found 106 | ERROR | [x] Expected 1 space after "+"; 0 found 106 | ERROR | [x] Concat operator must be surrounded by a single space 106 | ERROR | [x] Expected one space after the comma, 0 found 107 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 22 108 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 18 109 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 18 109 | ERROR | [x] Expected 1 space after IF keyword; 0 found 109 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 110 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 22 110 | ERROR | [x] Expected one space after the comma, 0 found 110 | ERROR | [x] Expected one space after the comma, 0 found 110 | ERROR | [x] Expected 1 space before "+"; 0 found 110 | ERROR | [x] Expected 1 space after "+"; 0 found 110 | ERROR | [x] Concat operator must be surrounded by a single space 110 | ERROR | [x] Expected one space after the comma, 0 found 111 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 22 112 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 18 113 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 114 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 114 | ERROR | [x] Expected one space after the comma, 0 found 114 | ERROR | [x] Expected one space after the comma, 0 found 114 | ERROR | [x] Expected one space after the comma, 0 found 115 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 116 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 14 117 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10 118 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 119 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 120 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 2 121 | ERROR | [x] Expected 1 newline at end of file; 0 found 121 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 225 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------- Time: 569ms; Memory: 20MB - đŸ‡®đŸ‡¹Italy apaderno Brescia, đŸ‡®đŸ‡¹
(The branch name is 1.0.x, not 1.0.0.)
- Status changed to Fixed
about 1 year ago 8:37am 3 April 2023 - Status changed to Needs review
about 1 year ago 8:41am 3 April 2023 - Status changed to Needs work
about 1 year ago 8:56am 3 April 2023 - đŸ‡®đŸ‡³India vishal.kadam Mumbai
There are PHPCS issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml wordsonline_connector/ FILE: wordsonline_connector/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 102 characters 4 | WARNING | Line exceeds 80 characters; contains 111 characters 6 | WARNING | Line exceeds 80 characters; contains 118 characters 23 | WARNING | Line exceeds 80 characters; contains 82 characters ---------------------------------------------------------------------- FILE: wordsonline_connector/src/Controller/OrderController.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 13 WARNINGS AFFECTING 13 LINES -------------------------------------------------------------------------------- 129 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 369 | WARNING | Only string literals should be passed to t() where possible 405 | WARNING | Only string literals should be passed to t() where possible 430 | WARNING | Only string literals should be passed to t() where possible 455 | WARNING | Only string literals should be passed to t() where possible 493 | WARNING | Only string literals should be passed to t() where possible 500 | WARNING | Only string literals should be passed to t() where possible 508 | WARNING | Only string literals should be passed to t() where possible 538 | WARNING | Only string literals should be passed to t() where possible 546 | WARNING | Only string literals should be passed to t() where possible 582 | WARNING | Only string literals should be passed to t() where possible 950 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 1113 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead -------------------------------------------------------------------------------- FILE: wordsonline_connector/src/Form/OrderConfirmForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------- 108 | WARNING | Unused variable $status. 109 | WARNING | Unused variable $rGuid. 112 | WARNING | Unused variable $status. 113 | WARNING | Unused variable $rGuid. -------------------------------------------------------------------------------- FILE: wordsonline_connector/src/Form/UpdateForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------- 156 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 172 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 197 | WARNING | Unused variable $files. 212 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead -------------------------------------------------------------------------------- FILE: wordsonline_connector/src/Form/ViewXlfForm.php -------------------------------------------------------------------------------- FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------- 42 | ERROR | Doc comment for parameter $configuration does not match actual variable name <undefined> 44 | ERROR | Superfluous parameter comment 46 | ERROR | Superfluous parameter comment 105 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 105 | WARNING | Only string literals should be passed to t() where possible -------------------------------------------------------------------------------- FILE: wordsonline_connector/src/Plugin/tmgmt/Translator/WordsOnlineTranslator.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------- 298 | WARNING | Unused variable $files. 428 | WARNING | Only string literals should be passed to t() where possible -------------------------------------------------------------------------------- FILE: wordsonline_connector/src/WordsOnlineTranslatorUi.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES -------------------------------------------------------------------------------- 77 | WARNING | Unused variable $translator. 162 | WARNING | Only string literals should be passed to t() where possible 187 | WARNING | Only string literals should be passed to t() where possible 213 | WARNING | Unused variable $triggering_element. 214 | WARNING | Unused variable $translator_settings. 271 | WARNING | Unused variable $servicesarray. 287 | WARNING | Only string literals should be passed to t() where possible -------------------------------------------------------------------------------- FILE: wordsonline_connector/tmgmt_wordsonline.info.yml -------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------- 6 | WARNING | [ ] All dependencies must be prefixed with the project name, for example "drupal:" 8 | ERROR | [x] Expected 1 newline at end of file; 2 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: wordsonline_connector/tmgmt_wordsonline.module -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------- 426 | WARNING | Hook implementations should not duplicate @param documentation 438 | WARNING | Hook implementations should not duplicate @param documentation 440 | WARNING | Hook implementations should not duplicate @param documentation -------------------------------------------------------------------------------- - Status changed to Needs review
about 1 year ago 9:23am 3 April 2023 - Status changed to Needs work
about 1 year ago 9:43am 3 April 2023 - Status changed to Needs review
about 1 year ago 3:26am 4 April 2023 - đŸ‡®đŸ‡³India vishal.kadam Mumbai
@luannguyen
I have reviewed the changes, and they look fine to me.
Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.
Thanks
Thanks for your feedback, Vishal.kadam.
Do you know how long we need to wait?
Thanks.- đŸ‡®đŸ‡³India Rashmisoni Bangalore
@luannguyen : I have tested on 1.0.x branch. Please find the text file for PHPSTAN issues.
Command run :
php -d memory_limit=4G ../../vendor/bin/phpstan analyse wordsonline_connector - Status changed to Needs work
about 1 year ago 9:19am 4 April 2023 - đŸ‡®đŸ‡¹Italy apaderno Brescia, đŸ‡®đŸ‡¹
- The following points are just a start and don't necessarily encompass all of the changes that may be necessary
- A specific point may just be an example and may apply in other places
- A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance
Since the project machine name (its short name as indicated in https://www.drupal.org/node/3345120/edit → ) is wordsonline_connector the module must contain the wordsonline_connector.module, wordsonline_connector.info.yml, wordsonline_connector.install, wordsonline_connector.libraries, wordsonline_connector.links.menu.yml, wordsonline_connector.routing.yml, and wordsonline_connector.services files. All the functions (not the methods) implemented by the module must have a name starting with wordsonline_connector_. The namespaces used by the modules nees to start with
Drupal\wordsonline_connector\.
The project machine name cannot be changed anymore; those files, all the functions, and the namespaces must be renamed.src/Controller/OrderController.php
/** * Controller for handle order. */ class OrderController extends ControllerBase implements ContainerInjectionInterface {The parent class already implements that interface; there is not need to implement it again.
/** * {@inheritdoc} * * @param \Symfony\Component\DependencyInjection\ContainerInterface $container * Container. */ public static function create(ContainerInterface $container) {There is no need to document the parameters, since the documentation comment is already using
{@inheritdoc}.// Then fetch all active or continuous jobs using those translators. $job_ids = \Drupal::entityQuery("tmgmt_job") ->condition("translator", $wordsonline_translator_ids, "IN") ->condition( "state", [ JobInterface::STATE_ACTIVE, JobInterface::STATE_CONTINUOUS, ], "IN" ) ->execute();Controllers need to use injected dependencies, even for dependencies that are used from a single line in all the controller code.
$download_link = $this->t( '<a href=":url" class="use-ajax btn" data-dialog-type="modal" title="download">Download</a>', [ ":url" => $down, ] ); $upload_link = $this->t( '<a class="btn" onclick="reimport(@job_id )" title="Import">Import </a>', [ "@job_id" => $job_id, ] ); $operation = $this->t( "@linkApprove @linkView @linkUpload", [ "@linkApprove" => $edit_link, "@linkView" => $download_link, "@linkUpload" => $upload_link, ] ); }That is not how links are added to a translatable string. Links are added directly to the literal strings passed to
t()or$this->t().
With the current code, links are sanitized twice, which means that<a href="link">Link title</a>would be changed to<a href="link">Link title<a>.$this->t('Cannot find WordsOnline provider settings. Please contact <a href="mailto:helpdesk@wordsonline.com"> helpdesk@wordsonline.com</a> to obtain WordsOnline provider settings.' )Any link added to translatable strings must be added through placeholders. that is also valid for email links.
src/Entity/WOFile.php
/** * WordsOnline File. */ class WOFile {The short description says does not describe the purpose of the class. It is also wrong as a class is not a file.
A Drupal entity implements at least an entity interface; differently, it is not a Drupal entity, and it should not use the namespace it uses. It also uses an annotation, which does not happen in this and other classes under that namespace.src/Form/OrderConfirmForm.php
/** * Messenger. * * @var \Drupal\Core\Messenger\Messenger */ protected $messenger;That property is already defined from the parent class.
$markup = new FormattableMarkup("<div class='wol-order-info'>", []); $form['order_info'] = [ '#markup' => $markup, ];There is no need to use a
FormattableMarkupinstance, since the string passed to the class constructor does not contain placeholders. Then,#markupaccepts also a string.if ($req == NULL) { $this->messenger->addMessage("Can not find job"); return; }Strings passed to the messenger must be translatable.
Hi Rassoni,
I setup phpstan by follow steps in https://www.drupal.org/docs/develop/development-tools/phpstan/getting-st... → with the phpstan.neon file config:
parameters:
level: 0
paths:
- wordsonline_connector/srcBut the validation result is not same your report. I attached my report here.
Can you please help check it or tell me how to config phpstan to get same your report?Thanks and Best Regard,
Luan
Hello Rassoni,
I checked your validation result file. Then I noticed that there are some reported errors related to tmgmt seem incorrect.
Access to constant STATE_ACTIVE on an unknown class Drupal\tmgmt\JobInterface.
Access to constant STATE_CONTINUOUS on an unknown class Drupal\tmgmt\JobInterface.You can check JobInterface file on git.
https://git.drupalcode.org/project/tmgmt/-/blob/8.x-1.x/src/JobInterface...Call to static method load() on an unknown class Drupal\tmgmt\Entity\Job.
Static method load is exists on class Drupal\tmgmt\Entity\Job because it is inherited from class ContentEntityInterface through interface JobInterface.
Parameter $job of method
Drupal\tmgmt_wordsonline\Controller\OrderController::importTranslation() has invalid type Drupal\tmgmt\JobInterface.Because Drupal\tmgmt\Entity\Job is inherited from Drupal\tmgmt\JobInterface , this should not be an error.
\Drupal calls should be avoided in classes, use dependency injection
insteadLine 651,681,704,715,726
I can't find these error.
https://git.drupalcode.org/project/wordsonline_connector/-/blob/1.0.x/sr...Please check and feedback me on this.
Thanks and Best Regards.
Luan- đŸ‡®đŸ‡³India Rashmisoni Bangalore
@luannguyen Yes, I have not passed any level on command so it will check all issues.
If you passing level 0 then only
basic checks, unknown classes, unknown functions, unknown methods called on $this, wrong number of arguments passed to those methods and functions, always undefined variablesYou can refer this document for level https://phpstan.org/user-guide/rule-levels
- đŸ‡®đŸ‡³India Rashmisoni Bangalore
@luannguyen : As per #21 comment.
tmgmtissues if we are avoiding then below issue needs to fix related toDrupal calls.------ ------------------------------------------------------------------------------ Line src/Common/ZipHandle.php ------ ------------------------------------------------------------------------------ 68 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ @Rassoni,
I checked your attached file but It's not same #23 → . Are you latest report file incorrect?- đŸ‡®đŸ‡¹Italy apaderno Brescia, đŸ‡®đŸ‡¹
PHPStan gives false positives when it is not correctly set or all the dependencies are not downloaded.
I would avoid using PHPStan in these applications, especially when the report is not first checked. (A reviewer should also verify what reported by PHP_CodeSniffer before posting its reports on an application.) - đŸ‡®đŸ‡¹Italy apaderno Brescia, đŸ‡®đŸ‡¹
Drupal\tmgmt_wordsonline\Common\ZipHandleis not a service, a controller, nor a form builder class; this means it cannot use dependency injection. Saying that all the classes must use dependency injection is not correct; in fact, a class that implements only static method cannot use dependency injection.(That is why I say that what a tool reports must be first verified. We do not want to force changes that are not necessary or, worse, not correct.)
- đŸ‡®đŸ‡³India Rashmisoni Bangalore
Thank you @apaderno for more clarity regarding issue for phpstan.
@luannguyen: Yes, #18 and #20 reports are different. As mention on #23 file PHPSTAN issues. Running command is generating same issues.
I am following below steps to regenerate the phpstan issues.
- Installed PHPSTAN via https://github.com/mglaman/phpstan-drupal
- Not configured any level on PHPSTAN.neon file. if required adding level in command.
- running this command
php -d memory_limit=4G vendor/bin/phpstan analyse modules/contrib/wordsonline_connector
if you check #18 and #23 files all PHPSTAN issues are already verified.
Major issues are related totmgmtas per comment #21 we can go forward.Call to static method load() on an unknown class Drupal\tmgmt\Entity\Job.
Static method load is exists on class Drupal\tmgmt\Entity\Job because it is inherited from class ContentEntityInterface through interface JobInterface.
Parameter $job of method
Drupal\tmgmt_wordsonline\Controller\OrderController::importTranslation() has invalid type Drupal\tmgmt\JobInterface.Because Drupal\tmgmt\Entity\Job is inherited from Drupal\tmgmt\JobInterface , this should not be an error.
\Drupal calls should be avoided in classes, use dependency injection
insteadAll issues are already answered and regarding #23 issues already covered by #26 comments.
Major if checking #18 and #23 files major issues are already rectified and answered.
Please let me know if we need to check any other way to generate PHPSTAN file like #20
@apaderno,@Rassoni
Yes, I check and see PHPStan gives false positives and the phpstan report is not trustable.
We already passed PHP_CodeSniffer validated by vishal.kadam reviewer. He confirmed on #16 →
Can we skip(don't fix) phpstan report by Rassoni?
We will fix issues reported in Apaderno on #19 → , then request review again?
Thanks,
Luan- đŸ‡®đŸ‡¹Italy apaderno Brescia, đŸ‡®đŸ‡¹
@luannguyen Yes, let us do that.
- Status changed to Needs review
about 1 year ago 2:48am 6 April 2023 @apaderno,
I fixed issues in your report except below one:src/Form/OrderConfirmForm.php
/**
* Messenger.
*
* @var \Drupal\Core\Messenger\Messenger
*/
protected $messenger;
That property is already defined from the parent class.Because $messenger variable is used in multiple functions (buildForm, confirmOrder, setCancel), but confirmOrder and setCancel functions only receive variable from buildForm function through FormStateInterface.
I don't have any solution to fix this now.
Do you have any suggestion to help me on this?Thanks
Luan- đŸ‡®đŸ‡¹Italy apaderno Brescia, đŸ‡®đŸ‡¹
Do not define the
$messengerproperty in your class. On the constructor, just call$this->setMessenger($messenger); when you need the messenger service, call$this->messenger().As a side note, on
create()there is no need to use local variables for the services. Given how the code is formatted, code lines will not get longer than 80 characters./** * {@inheritdoc} */ public static function create(ContainerInterface $container) { return new static( $container->get('database'), $container->get('messenger') ); } @apaderno
I fixed all your report issues following your suggestion.
Please help review it.
I appreciate your soon feedback, so I have time to fix it any remaining issues as today is my deadline on this task
Thanks and Best Regards.
Luan- Assigned to apaderno
- Status changed to RTBC
about 1 year ago 4:58pm 7 April 2023 - đŸ‡®đŸ‡¹Italy apaderno Brescia, đŸ‡®đŸ‡¹
Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
- Dries → ' post on Responsible maintainers
- Best practices for creating and maintaining projects →
- Maintaining a drupal.org project with Git →
- Commit messages - providing history and credit →
- Release naming conventions → .
- Helping maintainers in the issue queues →
You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.I thank all the reviewers.
- Status changed to Fixed
about 1 year ago 8:18am 8 April 2023 - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 3:02am 10 April 2023 Dear Apadermo and Review team,
On behalf of Jonckers team, I am writing to express our sincere gratitude to you and reviewer team for your hard work and dedication in helping us pass the Drupal module security certification. Your expertise and attention to detail were invaluable in ensuring that our module met the standards of security.
We are grateful for your guidance throughout the certification process. Your feedback and suggestions helped us identify and address potential vulnerabilities in our module, which has made it more secure and reliable.
We appreciate the time and effort that you and reviewer team put into this project. Your professionalism and commitment to excellence are truly commendable. We look forward to working with you again in the future.
Thank you once again for your outstanding work.
Sincerely,
Jonckers VN Developer Team LeadNgoc
- Status changed to Fixed
about 1 year ago 3:04am 10 April 2023 - Status changed to Fixed
about 1 year ago 3:09am 24 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.