- Issue created by @ressa
- First commit to issue fork.
- last update
over 1 year ago 29,198 pass, 1 fail - @rassoni opened merge request.
- last update
over 1 year ago 30,320 pass - @rassoni opened merge request.
- last update
over 1 year ago 30,320 pass - last update
over 1 year ago 30,320 pass - last update
over 1 year ago 30,320 pass - last update
over 1 year ago 30,320 pass - last update
over 1 year ago 29,206 pass - last update
over 1 year ago 29,206 pass - last update
over 1 year ago 29,206 pass - last update
over 1 year ago 29,207 pass - Status changed to Needs review
over 1 year ago 9:38pm 17 April 2023 - π©π°Denmark ressa Copenhagen
Thanks @Rassoni, I think that looks great. To me, it looks ready to get committed, but let's maybe wait and see how the community feel about it. Have a nice day!
- Status changed to RTBC
over 1 year ago 2:53pm 18 April 2023 - πΊπΈUnited States smustgrave
Change seems simple enough and updates make sense. Wonder how long that Drupal 9 keyword will be needed though.
- π©π°Denmark ressa Copenhagen
Thanks for a fast response @smustgrave. And yes, maybe we should just drop "Drupal 9"?
Regarding improving the Composer package experience, there's also π Add README.md to composer project templates Needs work . It's only mentioned here, but I think expanding the README.md in line with for example palantirnet/drupal-rector would make the Recommended page rank better in a search for "Drupal" on Packages.org. What do you think?
- last update
over 1 year ago 29,283 pass - last update
over 1 year ago 29,283 pass - π©π°Denmark ressa Copenhagen
Thanks for taking a look at it @quietone. It make sense to not include specific versions, but can't we at least add "Drupal" as a key word?
"keywords": ["Drupal"],
That should be low maintenance :)
- Status changed to Needs review
over 1 year ago 9:47am 19 April 2023 - π©π°Denmark ressa Copenhagen
@quietone:
... text on packagist is not displaying the latest description.
Maybe because it pulls it from the default version of https://github.com/drupal/recommended-project which is currently 9.1?
Setting it to be the current official release 10.0 could fix it: https://github.com/drupal/recommended-project/tree/10.0.x
Publish It
[...] Once you entered your public repository URL in there, your package will be automatically crawled periodically. You just have to make sure you keep the composer.json file up to date.
If this is true, then changing default version to the current official release should probably be added to the checklist of tasks, when minor versions of Drupal (10.1, 10.2, etc.) are released every half year or so.
Generally speaking, it's also just good practice. I realized the importance of this during the updating of plenty of
README.md
's the last few months, to make sure show the latest updated version is used :) - π©π°Denmark ressa Copenhagen
- Status changed to RTBC
over 1 year ago 4:05pm 19 April 2023 - πΊπΈUnited States smustgrave
Going to remark it and see what the committer things for
"keywords": ["Drupal"],
- π³πΏNew Zealand quietone
I asked about the packagist description in #composer and #hestenet has updated it.
Before setting an issue to RTBC it is useful to check that the issue Meta data is correct. This helps the next reviewer/committer to select what to work on. For this issue, the title is not correct and is misleading to others. Per List of issue fields β the title is "A description of what the issue is intended to resolve.". It is also used for the commit message and having it correct is useful when people search the git log in the futur
- Status changed to Active
over 1 year ago 8:25am 20 April 2023 - π©π°Denmark ressa Copenhagen
Great that the description has been updated on packagist.org, @quietone.
Do you know if @hestenet updated the description directly on packagist.org, or if it pulled the data from https://github.com/drupal/recommended-project after the default branch was updated from 9.1 to 10.1 yesterday?
Since description and keywords are still both in play, it would make sense to add keywords but also keep description in the title, I think.
What is you opinion on adding
"keywords": ["Drupal"],
in composer.json? - π΅π±Poland wwalc
Unsure if it is the right issue, but if you could change the About description on GitHub of https://github.com/drupal/recommended-project that would be great too. Confused me for a while.
It states the following:
> About
Project template for Drupal 8 projects with a relocated document rootWhile it is for more recent Drupal versions as well.
- π©π°Denmark ressa Copenhagen
Good catch @wwalc, I never noticed that before.
If you're interested, there's an issue about adding a README to that repository, π Add README.md to composer project templates Needs work .