Unused local variable $key (at line 49) in file.field.inc

Running for 10.1 but don't expect a failure.

If we're going to remove this I think we should take the opportunity to make the code inside more consistent. In the loop we have

    foreach (Element::children($widget) as $sub_key) {
      if (isset($widget[$sub_key]['#type']) && $widget[$sub_key]['#type'] == 'submit') {
        hide($widget[$sub_key]);
        $operations_elements[] = &$widget[$sub_key];
      }
    }

and

    foreach (Element::children($operations_elements) as $key) {
      show($operations_elements[$key]);
    }

I think now we're removing the $key from the containing loop we should be changing the first internal Element::children() to use $key instead of $sub_key because now sub_ is pretty meaningless.

Change parent to the issue implementing the sniff.

Addressed the points mentioned in #38

foreach (Element::children($operations_elements) as $sub_key) {

Will let the committer decide this one but not sure if this should be sub_key but since we used $key in the loop above it maybe it's fine.

No, making this sub key is super confusing, back to needs work imho.

Addressed the points mentioned in #38 in Patch #40, Currently, Parent loops is not using $key So used $key instead of $sub_key and that loop ended in line no 65. IMO line number 91 changes not required as it starts with different loop. Please review.

Sorry wrong interdiff.

Checked the patch given on #43 , it apply's cleanly and have also addressed the previous comments

+RTBC

@aziza_a, adding a screenshot that code applies is not helpful, the bots tell us that. Please don't do that.

The patch in #43 has made the changes I requested in #42, looks good to me now.

In general I don't think we should treat array keys in foreach loops as unused but in this case it's improving readability overall so seems like a good change. Committed/pushed to 10.1.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.