- Issue created by @jay jangid
- @jay-jangid opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:00am 1 February 2023 - Status changed to Needs work
almost 2 years ago 7:30am 1 February 2023 - 🇩🇪Germany Anybody Porta Westfalica
@Jay Jangid are you sure TRUE / FALSE should also be uppercase in JS?
Please provide a link to the docs to prove that. Thanks :) - Status changed to Needs review
almost 2 years ago 5:11am 7 February 2023 - 🇮🇳India jay jangid Jaipur
Hey @Anybody , as you said here I attached reference link please check.
https://www.drupal.org/docs/develop/standards/javascript/javascript-codi... → .True and False in JS are capitialised because they are constants and it is common practice to capitialise constants in JS.
- Status changed to Needs work
almost 2 years ago 7:19am 7 February 2023 - 🇩🇪Germany Anybody Porta Westfalica
@Jay Jangid lol. Where can I see that on that page?
I only see
this.clickCallback = function (e) { return false; };
as a boolean example on that page. Never saw TRUE or FALSE as constants captialized in Drupal JS before... Show me the code, please.
- First commit to issue fork.
- @kkalashnikov opened merge request.
- 🇮🇳India kkalashnikov Ghaziabad, India
Removed commented code in below MR
- 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.
- Assigned to akshaydalvi212
- 🇩🇪Germany Anybody Porta Westfalica
Let's close this, we'll fix it in a future release. Not interested in useless credit bull***
- Status changed to Closed: won't fix
almost 2 years ago 7:18am 30 March 2023