Fix the issues reported by phpcs

FILE: ~/projects/drupal-d10/modules/contrib/easy_email/easy_email.routing.yml ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 27 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/easy_email.module -------------------------------------------------------------------------------- FOUND 56 ERRORS AND 2 WARNINGS AFFECTING 58 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 144 | ERROR | [x] Missing function doc comment 155 | ERROR | [x] Expected 1 blank line after function; 2 found 158 | ERROR | [x] Missing function doc comment 164 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 169 | ERROR | [x] Missing function doc comment 174 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 178 | ERROR | [x] Missing function doc comment 264 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 311 | ERROR | [x] Missing function doc comment 332 | ERROR | [x] Missing function doc comment 362 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 365 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 369 | ERROR | [x] Missing function doc comment 403 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 406 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 410 | ERROR | [x] Missing function doc comment 444 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 447 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 451 | ERROR | [x] Missing function doc comment 452 | ERROR | [x] Expected 1 space after "="; 2 found 481 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 484 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 488 | ERROR | [x] Missing function doc comment 522 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 525 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 529 | ERROR | [x] Missing function doc comment 530 | ERROR | [x] Expected 1 space after "="; 2 found 559 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 562 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 566 | ERROR | [x] Missing function doc comment 609 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 612 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 616 | ERROR | [x] Missing function doc comment 641 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 644 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 648 | ERROR | [x] Missing function doc comment 673 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 676 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 680 | ERROR | [x] Missing function doc comment 705 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 708 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 712 | ERROR | [x] Missing function doc comment 742 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 745 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 749 | ERROR | [x] Missing function doc comment 750 | ERROR | [x] Expected 1 space after "="; 2 found 778 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 781 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 785 | ERROR | [x] Missing function doc comment 786 | ERROR | [x] Expected 1 space after "="; 2 found 814 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 817 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 821 | ERROR | [x] Missing function doc comment 822 | ERROR | [x] Expected 1 space after "="; 2 found 850 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 853 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 860 | ERROR | [x] Doc comment long description must end with a full stop -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 58 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/css/easy-email-preview.css -------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------- 47 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/easy_email.page.inc --------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 3 LINES --------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 81 | ERROR | [x] Expected 1 space after comma in argument list; 2 found 81 | ERROR | [x] Expected one space after the comma, 2 found 92 | ERROR | [x] Expected 1 newline at end of file; 2 found --------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/tests/src/Functional/EasyEmailTemplateCreateTest.php ------------------------------------------------------------------------------------- FOUND 40 ERRORS AND 1 WARNING AFFECTING 41 LINES ------------------------------------------------------------------------------------- 3 | ERROR | [x] There must be one blank line after the namespace declaration 7 | ERROR | [x] Doc comment short description must end with a full stop 10 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 14 | ERROR | [x] Doc comment short description must end with a full stop 29 | ERROR | [x] Concat operator must be surrounded by a single space 66 | ERROR | [x] Concat operator must be surrounded by a single space 88 | ERROR | [x] Doc comment short description must end with a full stop 102 | ERROR | [x] Concat operator must be surrounded by a single space 127 | ERROR | [x] Doc comment short description must end with a full stop 141 | ERROR | [x] Concat operator must be surrounded by a single space 165 | ERROR | [x] Doc comment short description must end with a full stop 179 | ERROR | [x] Concat operator must be surrounded by a single space 203 | ERROR | [x] Doc comment short description must end with a full stop 210 | ERROR | [ ] Public method name "EasyEmailTemplateCreateTest::testCreateNoCCUidTemplate" is not in lowerCamel format 217 | ERROR | [x] Concat operator must be surrounded by a single space 241 | ERROR | [x] Doc comment short description must end with a full stop 248 | ERROR | [ ] Public method name "EasyEmailTemplateCreateTest::testCreateNoCCAddressTemplate" is not in lowerCamel format 255 | ERROR | [x] Concat operator must be surrounded by a single space 279 | ERROR | [x] Doc comment short description must end with a full stop 286 | ERROR | [ ] Public method name "EasyEmailTemplateCreateTest::testCreateNoBCCUidTemplate" is not in lowerCamel format 293 | ERROR | [x] Concat operator must be surrounded by a single space 317 | ERROR | [x] Doc comment short description must end with a full stop 324 | ERROR | [ ] Public method name "EasyEmailTemplateCreateTest::testCreateNoBCCAddressTemplate" is not in lowerCamel format 331 | ERROR | [x] Concat operator must be surrounded by a single space 355 | ERROR | [x] Doc comment short description must end with a full stop 369 | ERROR | [x] Concat operator must be surrounded by a single space 393 | ERROR | [x] Doc comment short description must end with a full stop 407 | ERROR | [x] Concat operator must be surrounded by a single space 431 | ERROR | [x] Doc comment short description must end with a full stop 445 | ERROR | [x] Concat operator must be surrounded by a single space 469 | ERROR | [x] Doc comment short description must end with a full stop 487 | ERROR | [x] Concat operator must be surrounded by a single space 512 | ERROR | [x] Doc comment short description must end with a full stop 526 | ERROR | [x] Concat operator must be surrounded by a single space 550 | ERROR | [x] Doc comment short description must end with a full stop 564 | ERROR | [x] Concat operator must be surrounded by a single space 588 | ERROR | [x] Doc comment short description must end with a full stop 602 | ERROR | [x] Concat operator must be surrounded by a single space 626 | ERROR | [x] Doc comment short description must end with a full stop 640 | ERROR | [x] Concat operator must be surrounded by a single space 663 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 36 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/tests/src/Functional/EasyEmailSendTest.php --------------------------------------------------------------------------------- FOUND 30 ERRORS AND 35 WARNINGS AFFECTING 63 LINES --------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 8 | ERROR | [x] Doc comment short description must end with a full stop 11 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 15 | ERROR | [x] Doc comment short description must end with a full stop 37 | WARNING | [x] A comma should follow the last multiline array item. Found: '[easy_email:field_user:0:entity:mail]' 44 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 168 | WARNING | [x] A comma should follow the last multiline array item. Found: '[easy_email:field_user:0:entity:mail]' 175 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 305 | WARNING | [x] A comma should follow the last multiline array item. Found: '[easy_email:field_user:0:entity:mail]' 312 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 426 | ERROR | [x] Doc comment short description must end with a full stop 450 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 468 | WARNING | [ ] Unused variable $site_config. 495 | ERROR | [x] Doc comment short description must end with a full stop 521 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 560 | ERROR | [x] Doc comment short description must end with a full stop 585 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 626 | ERROR | [x] Doc comment short description must end with a full stop 651 | WARNING | [x] A comma should follow the last multiline array item. Found: '[easy_email:field_user:0:entity:mail]' 658 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 704 | ERROR | [x] Doc comment short description must end with a full stop 729 | WARNING | [x] A comma should follow the last multiline array item. Found: '[easy_email:field_user:0:entity:mail]' 736 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 782 | ERROR | [x] Expected 1 blank line after function; 2 found 786 | ERROR | [x] Doc comment short description must end with a full stop 811 | WARNING | [x] A comma should follow the last multiline array item. Found: '[easy_email:field_user:0:entity:mail]' 818 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 864 | ERROR | [x] Doc comment short description must end with a full stop 889 | WARNING | [x] A comma should follow the last multiline array item. Found: '[easy_email:field_user:0:entity:mail]' 896 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 945 | ERROR | [x] Doc comment short description must end with a full stop 970 | WARNING | [x] A comma should follow the last multiline array item. Found: '[easy_email:field_user:0:entity:mail]' 977 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 1049 | WARNING | [x] A comma should follow the last multiline array item. Found: '[easy_email:field_user:0:entity:mail]' 1056 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 1137 | WARNING | [x] A comma should follow the last multiline array item. Found: '[easy_email:field_user:0:entity:mail]' 1144 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 1236 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 1275 | WARNING | [ ] Line exceeds 80 characters; contains 121 characters 1275 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 1302 | WARNING | [x] There must be no blank line following an inline comment 1302 | WARNING | [ ] There must be no blank line following an inline comment 1314 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters 1336 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 1349 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters 1371 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 1377 | ERROR | [x] Doc comment short description must end with a full stop 1401 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 1409 | ERROR | [x] Each PHP statement must be on a line by itself 1419 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 1422 | ERROR | [x] Each PHP statement must be on a line by itself 1437 | ERROR | [x] Doc comment short description must end with a full stop 1461 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 1468 | ERROR | [x] Each PHP statement must be on a line by itself 1478 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 1481 | ERROR | [x] Each PHP statement must be on a line by itself 1487 | ERROR | [x] Each PHP statement must be on a line by itself 1496 | ERROR | [x] Doc comment short description must end with a full stop 1521 | WARNING | [x] A comma should follow the last multiline array item. Found: 'html' 1528 | ERROR | [x] Each PHP statement must be on a line by itself 1538 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 1541 | ERROR | [x] Each PHP statement must be on a line by itself 1547 | ERROR | [x] Each PHP statement must be on a line by itself 1553 | ERROR | [x] Expected 1 blank line after function; 0 found 1554 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------- PHPCBF CAN FIX THE 59 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/tests/src/Functional/EasyEmailTemplatePreviewTest.php ---------------------------------------------------------------------------------------------- FOUND 37 ERRORS AND 2 WARNINGS AFFECTING 39 LINES ---------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 8 | ERROR | [x] Doc comment short description must end with a full stop 11 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 16 | ERROR | [x] Doc comment short description must end with a full stop 23 | ERROR | [x] Expected 1 blank line before function; 2 found 35 | ERROR | [x] Concat operator must be surrounded by a single space 39 | ERROR | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 43 | ERROR | [ ] The array declaration extends to column 153 (the limit is 80). The array content should be split up over multiple lines 48 | ERROR | [x] Concat operator must be surrounded by a single space 86 | ERROR | [x] Expected 1 blank line after function; 2 found 90 | ERROR | [x] Doc comment short description must end with a full stop 109 | ERROR | [x] Concat operator must be surrounded by a single space 113 | ERROR | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 117 | ERROR | [ ] The array declaration extends to column 153 (the limit is 80). The array content should be split up over multiple lines 122 | ERROR | [x] Concat operator must be surrounded by a single space 163 | ERROR | [x] Doc comment short description must end with a full stop 182 | ERROR | [x] Concat operator must be surrounded by a single space 186 | ERROR | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 190 | ERROR | [ ] The array declaration extends to column 153 (the limit is 80). The array content should be split up over multiple lines 196 | ERROR | [x] Concat operator must be surrounded by a single space 237 | ERROR | [x] Doc comment short description must end with a full stop 257 | ERROR | [x] Concat operator must be surrounded by a single space 261 | ERROR | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 270 | ERROR | [x] Concat operator must be surrounded by a single space 308 | ERROR | [x] Doc comment short description must end with a full stop 328 | ERROR | [x] Concat operator must be surrounded by a single space 333 | ERROR | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 341 | ERROR | [x] Concat operator must be surrounded by a single space 378 | ERROR | [x] Doc comment short description must end with a full stop 398 | ERROR | [x] Concat operator must be surrounded by a single space 403 | ERROR | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 407 | ERROR | [ ] The array declaration extends to column 153 (the limit is 80). The array content should be split up over multiple lines 411 | ERROR | [x] Concat operator must be surrounded by a single space 448 | ERROR | [x] Doc comment short description must end with a full stop 467 | ERROR | [x] Concat operator must be surrounded by a single space 471 | ERROR | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 475 | ERROR | [ ] The array declaration extends to column 173 (the limit is 80). The array content should be split up over multiple lines 481 | ERROR | [x] Concat operator must be surrounded by a single space 521 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/tests/src/Functional/EasyEmailTestBase.php ----------------------------------------------------------------------------------------------- FOUND 25 ERRORS AND 3 WARNINGS AFFECTING 27 LINES ----------------------------------------------------------------------------------------------- 11 | WARNING | [x] Unused use statement 16 | ERROR | [x] Doc comment short description must end with a full stop 17 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 45 | ERROR | [ ] Missing short description in doc comment 55 | ERROR | [x] Missing function doc comment 77 | ERROR | [x] Missing function doc comment 82 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 87 | ERROR | [x] Missing function doc comment 102 | ERROR | [ ] Missing short description in doc comment 103 | ERROR | [ ] Missing parameter comment 104 | ERROR | [ ] Missing parameter comment 106 | ERROR | [ ] Description for the @return value is missing 111 | ERROR | [ ] Type hint "array" missing for $values 127 | ERROR | [ ] Description for the @return value is missing 160 | ERROR | [ ] Missing short description in doc comment 161 | ERROR | [ ] Missing parameter comment 162 | ERROR | [ ] Missing parameter comment 163 | ERROR | [ ] Missing parameter comment 199 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 202 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 206 | ERROR | [ ] Missing short description in doc comment 207 | ERROR | [ ] Missing parameter comment 208 | ERROR | [ ] Missing parameter comment 215 | ERROR | [ ] Missing short description in doc comment 216 | ERROR | [ ] Missing parameter comment 218 | ERROR | [ ] Description for the @return value is missing 230 | ERROR | [x] Expected 1 space before "+"; 0 found 230 | ERROR | [x] Expected 1 space after "+"; 0 found ----------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/README.md ----------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 13 WARNINGS AFFECTING 13 LINES ----------------------------------------------------------------------------------------- 1 | WARNING | Line exceeds 80 characters; contains 130 characters 10 | WARNING | Line exceeds 80 characters; contains 504 characters 19 | WARNING | Line exceeds 80 characters; contains 156 characters 20 | WARNING | Line exceeds 80 characters; contains 99 characters 22 | WARNING | Line exceeds 80 characters; contains 82 characters 23 | WARNING | Line exceeds 80 characters; contains 192 characters 24 | WARNING | Line exceeds 80 characters; contains 157 characters 25 | WARNING | Line exceeds 80 characters; contains 331 characters 31 | WARNING | Line exceeds 80 characters; contains 100 characters 32 | WARNING | Line exceeds 80 characters; contains 170 characters 33 | WARNING | Line exceeds 80 characters; contains 123 characters 34 | WARNING | Line exceeds 80 characters; contains 134 characters 35 | WARNING | Line exceeds 80 characters; contains 111 characters ----------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/easy_email.install -------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/config/schema/easy_email_override.schema.yml ------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------- 35 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/easy_email_override.emails.yml ------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------- 99 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/easy_email_override.links.task.yml ----------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------- 5 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/easy_email_override.links.menu.yml ----------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------- 8 | ERROR | [x] Expected 1 newline at end of file; 2 found ----------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/easy_email_override.links.action.yml ------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/src/Form/EmailOverrideForm.php ------------------------------------------------------------------------------------------- FOUND 19 ERRORS AND 3 WARNINGS AFFECTING 21 LINES ------------------------------------------------------------------------------------------- 14 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 17 | ERROR | [ ] Missing short description in doc comment 22 | ERROR | [ ] Missing short description in doc comment 27 | ERROR | [ ] Missing short description in doc comment 32 | ERROR | [ ] Missing short description in doc comment 40 | ERROR | [ ] Missing parameter comment 41 | ERROR | [ ] Missing parameter comment 42 | ERROR | [ ] Missing parameter comment 42 | ERROR | [x] Data types in @param tags need to be fully namespaced 49 | ERROR | [x] Expected 1 blank line after function; 2 found 52 | ERROR | [x] Missing function doc comment 60 | ERROR | [ ] Missing short description in doc comment 61 | ERROR | [ ] Description for the @return value is missing 72 | ERROR | [ ] Missing short description in doc comment 73 | ERROR | [ ] Description for the @return value is missing 93 | ERROR | [x] Missing function doc comment 101 | ERROR | [x] Missing function doc comment 142 | ERROR | [ ] Missing short description in doc comment 143 | ERROR | [ ] Missing parameter comment 145 | ERROR | [ ] Description for the @return value is missing 266 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 272 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/src/Entity/EmailOverride.php ----------------------------------------------------------------------------------------- FOUND 35 ERRORS AFFECTING 35 LINES ----------------------------------------------------------------------------------------- 65 | ERROR | Missing short description in doc comment 70 | ERROR | Missing short description in doc comment 75 | ERROR | Missing short description in doc comment 80 | ERROR | Missing short description in doc comment 85 | ERROR | Missing short description in doc comment 86 | ERROR | Description for the @return value is missing 92 | ERROR | Missing short description in doc comment 93 | ERROR | Missing parameter comment 95 | ERROR | Description for the @return value is missing 102 | ERROR | Missing short description in doc comment 103 | ERROR | Description for the @return value is missing 109 | ERROR | Missing short description in doc comment 110 | ERROR | Missing parameter comment 112 | ERROR | Description for the @return value is missing 119 | ERROR | Missing short description in doc comment 120 | ERROR | Description for the @return value is missing 126 | ERROR | Missing short description in doc comment 127 | ERROR | Missing parameter comment 129 | ERROR | Description for the @return value is missing 131 | ERROR | Type hint "array" missing for $param_map 136 | ERROR | Missing short description in doc comment 137 | ERROR | Description for the @return value is missing 143 | ERROR | Missing short description in doc comment 144 | ERROR | Missing parameter comment 146 | ERROR | Description for the @return value is missing 153 | ERROR | Missing short description in doc comment 154 | ERROR | Description for the @return value is missing 160 | ERROR | Missing short description in doc comment 161 | ERROR | Missing parameter comment 163 | ERROR | Description for the @return value is missing 170 | ERROR | Missing short description in doc comment 171 | ERROR | Description for the @return value is missing 177 | ERROR | Missing short description in doc comment 178 | ERROR | Missing parameter comment 180 | ERROR | Description for the @return value is missing ----------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/src/Entity/EmailOverrideInterface.php -------------------------------------------------------------------------------------------------- FOUND 30 ERRORS AFFECTING 30 LINES -------------------------------------------------------------------------------------------------- 12 | ERROR | Missing short description in doc comment 13 | ERROR | Description for the @return value is missing 17 | ERROR | Missing short description in doc comment 18 | ERROR | Missing parameter comment 20 | ERROR | Description for the @return value is missing 24 | ERROR | Missing short description in doc comment 25 | ERROR | Description for the @return value is missing 29 | ERROR | Missing short description in doc comment 30 | ERROR | Missing parameter comment 32 | ERROR | Description for the @return value is missing 36 | ERROR | Missing short description in doc comment 37 | ERROR | Description for the @return value is missing 41 | ERROR | Missing short description in doc comment 42 | ERROR | Missing parameter comment 44 | ERROR | Description for the @return value is missing 46 | ERROR | Type hint "array" missing for $paramMap 48 | ERROR | Missing short description in doc comment 49 | ERROR | Description for the @return value is missing 53 | ERROR | Missing short description in doc comment 54 | ERROR | Missing parameter comment 56 | ERROR | Description for the @return value is missing 60 | ERROR | Missing short description in doc comment 61 | ERROR | Description for the @return value is missing 65 | ERROR | Missing short description in doc comment 66 | ERROR | Missing parameter comment 68 | ERROR | Description for the @return value is missing 72 | ERROR | Missing short description in doc comment 73 | ERROR | Description for the @return value is missing 77 | ERROR | Missing short description in doc comment 78 | ERROR | Missing parameter comment -------------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/src/Plugin/Email/Email.php --------------------------------------------------------------------------------------- FOUND 7 ERRORS AFFECTING 7 LINES --------------------------------------------------------------------------------------- 8 | ERROR | [x] Doc comment short description must end with a full stop 12 | ERROR | [x] Missing function doc comment 16 | ERROR | [x] Missing function doc comment 20 | ERROR | [x] Missing function doc comment 24 | ERROR | [x] Missing function doc comment 28 | ERROR | [x] Missing function doc comment 32 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/src/Plugin/Email/EmailInterface.php ------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------ 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 4 | ERROR | [x] Missing interface doc comment 46 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------ FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/src/Service/MailManager.php ---------------------------------------------------------------------------------------- FOUND 8 ERRORS AND 5 WARNINGS AFFECTING 11 LINES ---------------------------------------------------------------------------------------- 8 | WARNING | [x] Unused use statement 8 | ERROR | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements 30 | ERROR | [ ] Missing parameter comment 31 | ERROR | [ ] Missing parameter comment 32 | ERROR | [ ] Missing parameter comment 32 | ERROR | [x] Data types in @param tags need to be fully namespaced 34 | ERROR | [x] Expected 1 blank line before function; 2 found 39 | ERROR | [ ] Missing short description in doc comment 46 | ERROR | [ ] Missing short description in doc comment 50 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 52 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 59 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters 69 | WARNING | [ ] Unused variable $result. ---------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/src/Service/DeclaredEmailManager.php ------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES ------------------------------------------------------------------------------------------------- 65 | ERROR | [x] Expected 1 space after "="; 2 found 73 | WARNING | [ ] Only string literals should be passed to t() where possible 84 | ERROR | [x] Short array syntax must be used to define arrays 101 | ERROR | [x] Expected 1 blank line after function; 2 found 104 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/modules/easy_email_override/src/EmailOverrideHtmlRouteProvider.php --------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------- 7 | WARNING | [x] Unused use statement 23 | WARNING | [x] There must be no blank line following an inline comment 23 | WARNING | [ ] There must be no blank line following an inline comment --------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/easy_email.links.action.yml --------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------- 17 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/easy_email.libraries.yml ------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------ 12 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------ FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/EasyEmailStorageInterface.php --------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------- 21 | ERROR | [x] Doc comment short description must end with a full stop 23 | ERROR | [ ] Description for the @return value is missing --------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Form/EasyEmailRevisionRevertForm.php ------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 4 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------- 33 | ERROR | Class property $EasyEmailStorage should use lowerCamel naming without underscores 76 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 90 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 119 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 122 | ERROR | The array declaration extends to column 170 (the limit is 80). The array content should be split up over multiple lines 123 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 123 | ERROR | The array declaration extends to column 227 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Form/EasyEmailTypeForm.php ----------------------------------------------------------------------- FOUND 9 ERRORS AND 3 WARNINGS AFFECTING 12 LINES ----------------------------------------------------------------------- 13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 26 | ERROR | [ ] Missing parameter comment 32 | ERROR | [x] Missing function doc comment 36 | ERROR | [x] Expected 1 blank line after function; 2 found 147 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 218 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 231 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 241 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 323 | ERROR | [ ] Missing short description in doc comment 324 | ERROR | [ ] Missing parameter comment 325 | ERROR | [ ] Missing parameter comment 327 | ERROR | [ ] Description for the @return value is missing ----------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Form/EasyEmailForm.php ---------------------------------------------------------------------------------------------- FOUND 19 ERRORS AND 11 WARNINGS AFFECTING 28 LINES ---------------------------------------------------------------------------------------------- 11 | WARNING | [x] Unused use statement 39 | ERROR | [ ] Doc comment for parameter $current_user does not match actual variable name <undefined> 59 | ERROR | [ ] Missing short description in doc comment 60 | ERROR | [ ] Description for the @return value is missing 70 | WARNING | [x] Inline @var declarations should use the /** */ delimiters 308 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 309 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 345 | ERROR | [ ] Missing parameter comment 346 | ERROR | [ ] Missing parameter comment 347 | ERROR | [ ] Missing parameter comment 347 | ERROR | [ ] Doc comment for parameter $entity does not match actual variable name <undefined> 347 | ERROR | [x] Data types in @param tags need to be fully namespaced 358 | ERROR | [ ] The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines 367 | ERROR | [ ] Missing parameter comment 368 | ERROR | [ ] Missing parameter comment 370 | ERROR | [ ] Description for the @return value is missing 371 | ERROR | [x] Separate the @return and @throws sections by a blank line. 382 | ERROR | [x] Missing function doc comment 386 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 392 | ERROR | [x] Expected 1 blank line after function; 2 found 409 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 410 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 420 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 424 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 428 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 430 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 437 | ERROR | [ ] Missing short description in doc comment 438 | ERROR | [ ] Missing parameter comment 439 | ERROR | [ ] Missing parameter comment 441 | ERROR | [ ] Description for the @return value is missing ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Form/EasyEmailRevisionRevertTranslationForm.php ------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------ 71 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 71 | ERROR | The array declaration extends to column 274 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------ FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Form/EasyEmailRevisionDeleteForm.php ------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 5 LINES ------------------------------------------------------------------------------------------- 32 | ERROR | Class property $EasyEmailStorage should use lowerCamel naming without underscores 76 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 90 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 109 | ERROR | The array declaration extends to column 169 (the limit is 80). The array content should be split up over multiple lines 110 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 110 | ERROR | The array declaration extends to column 250 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Entity/EasyEmailViewsData.php --------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE --------------------------------------------------------------------------- 19 | WARNING | [x] There must be no blank line following an inline comment 19 | WARNING | [ ] There must be no blank line following an inline comment --------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Entity/EasyEmailInterface.php --------------------------------------------------------------------------- FOUND 100 ERRORS AND 4 WARNINGS AFFECTING 95 LINES --------------------------------------------------------------------------- 8 | WARNING | [x] Unused use statement 40 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 71 | ERROR | [ ] Type hint "array" missing for $accounts 77 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters 90 | ERROR | [ ] Type hint "array" missing for $uids 93 | ERROR | [x] Doc comment short description must end with a full stop 95 | ERROR | [ ] Missing parameter comment 102 | ERROR | [x] Doc comment short description must end with a full stop 104 | ERROR | [ ] Missing parameter comment 126 | ERROR | [ ] Type hint "array" missing for $addresses 131 | ERROR | [ ] Missing parameter comment 140 | ERROR | [ ] Missing parameter comment 152 | ERROR | [ ] Public method name "EasyEmailInterface::getCC" is not in lowerCamel format 162 | ERROR | [ ] Public method name "EasyEmailInterface::setCC" is not in lowerCamel format 162 | ERROR | [ ] Type hint "array" missing for $accounts 171 | ERROR | [ ] Public method name "EasyEmailInterface::getCCIds" is not in lowerCamel format 181 | ERROR | [ ] Public method name "EasyEmailInterface::setCCIds" is not in lowerCamel format 181 | ERROR | [ ] Type hint "array" missing for $uids 184 | ERROR | [x] Doc comment short description must end with a full stop 186 | ERROR | [ ] Missing parameter comment 190 | ERROR | [ ] Public method name "EasyEmailInterface::addCC" is not in lowerCamel format 193 | ERROR | [x] Doc comment short description must end with a full stop 195 | ERROR | [ ] Missing parameter comment 199 | ERROR | [ ] Public method name "EasyEmailInterface::removeCC" is not in lowerCamel format 207 | ERROR | [ ] Public method name "EasyEmailInterface::getCCAddresses" is not in lowerCamel format 217 | ERROR | [ ] Public method name "EasyEmailInterface::setCCAddresses" is not in lowerCamel format 217 | ERROR | [ ] Type hint "array" missing for $addresses 222 | ERROR | [ ] Missing parameter comment 226 | ERROR | [ ] Public method name "EasyEmailInterface::addCCAddress" is not in lowerCamel format 231 | ERROR | [ ] Missing parameter comment 235 | ERROR | [ ] Public method name "EasyEmailInterface::removeCCAddress" is not in lowerCamel format 243 | ERROR | [ ] Public method name "EasyEmailInterface::getBCC" is not in lowerCamel format 253 | ERROR | [ ] Public method name "EasyEmailInterface::setBCC" is not in lowerCamel format 253 | ERROR | [ ] Type hint "array" missing for $accounts 262 | ERROR | [ ] Public method name "EasyEmailInterface::getBCCIds" is not in lowerCamel format 272 | ERROR | [ ] Public method name "EasyEmailInterface::setBCCIds" is not in lowerCamel format 272 | ERROR | [ ] Type hint "array" missing for $uids 275 | ERROR | [x] Doc comment short description must end with a full stop 277 | ERROR | [ ] Missing parameter comment 281 | ERROR | [ ] Public method name "EasyEmailInterface::addBCC" is not in lowerCamel format 284 | ERROR | [x] Doc comment short description must end with a full stop 286 | ERROR | [ ] Missing parameter comment 290 | ERROR | [ ] Public method name "EasyEmailInterface::removeBCC" is not in lowerCamel format 298 | ERROR | [ ] Public method name "EasyEmailInterface::getBCCAddresses" is not in lowerCamel format 308 | ERROR | [ ] Public method name "EasyEmailInterface::setBCCAddresses" is not in lowerCamel format 308 | ERROR | [ ] Type hint "array" missing for $addresses 313 | ERROR | [ ] Missing parameter comment 317 | ERROR | [ ] Public method name "EasyEmailInterface::addBCCAddress" is not in lowerCamel format 322 | ERROR | [ ] Missing parameter comment 326 | ERROR | [ ] Public method name "EasyEmailInterface::removeBCCAddress" is not in lowerCamel format 329 | ERROR | [x] Doc comment short description must end with a full stop 331 | ERROR | [ ] Description for the @return value is missing 336 | ERROR | [x] Doc comment short description must end with a full stop 338 | ERROR | [ ] Missing parameter comment 345 | ERROR | [x] Doc comment short description must end with a full stop 347 | ERROR | [ ] Description for the @return value is missing 352 | ERROR | [x] Doc comment short description must end with a full stop 354 | ERROR | [ ] Missing parameter comment 361 | ERROR | [x] Doc comment short description must end with a full stop 363 | ERROR | [ ] Description for the @return value is missing 368 | ERROR | [x] Doc comment short description must end with a full stop 370 | ERROR | [ ] Missing parameter comment 377 | ERROR | [x] Doc comment short description must end with a full stop 379 | ERROR | [ ] Description for the @return value is missing 384 | ERROR | [x] Doc comment short description must end with a full stop 386 | ERROR | [ ] Missing parameter comment 393 | ERROR | [x] Doc comment short description must end with a full stop 395 | ERROR | [ ] Description for the @return value is missing 400 | ERROR | [x] Doc comment short description must end with a full stop 403 | ERROR | [x] Parameter comment must end with a full stop 405 | ERROR | [x] Parameter comment must end with a full stop 412 | ERROR | [x] Doc comment short description must end with a full stop 414 | ERROR | [ ] Description for the @return value is missing 419 | ERROR | [x] Doc comment short description must end with a full stop 421 | ERROR | [ ] Missing parameter comment 428 | ERROR | [x] Doc comment short description must end with a full stop 430 | ERROR | [ ] Description for the @return value is missing 435 | ERROR | [x] Doc comment short description must end with a full stop 437 | ERROR | [ ] Missing parameter comment 459 | ERROR | [ ] Type hint "\Drupal\file\FileInterface" missing for $files 465 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters 478 | ERROR | [ ] Type hint "array" missing for $fids 516 | ERROR | [ ] Type hint "array" missing for $paths 521 | ERROR | [ ] Missing parameter comment 530 | ERROR | [ ] Missing parameter comment 536 | ERROR | [ ] Missing short description in doc comment 537 | ERROR | [ ] Description for the @return value is missing 541 | ERROR | [ ] Missing short description in doc comment 542 | ERROR | [ ] Missing parameter comment 544 | ERROR | [x] Expected "this" but found "$this;" for function return type 544 | ERROR | [ ] Description for the @return value is missing 546 | ERROR | [ ] Type hint "array" missing for $attachments 548 | ERROR | [ ] Missing short description in doc comment 549 | ERROR | [ ] Missing parameter comment 549 | ERROR | [x] Expected "object" but found "stdClass" for parameter type 555 | ERROR | [ ] Missing short description in doc comment 556 | ERROR | [ ] Missing parameter comment 556 | ERROR | [x] Expected "object" but found "stdClass" for parameter type 595 | ERROR | [x] Expected 1 blank line after function; 2 found 602 | ERROR | [x] Parameter comment must end with a full stop 648 | ERROR | [x] Doc comment short description must end with a full stop 650 | ERROR | [ ] Description for the @return value is missing 655 | ERROR | [x] Doc comment short description must end with a full stop 657 | ERROR | [ ] Missing parameter comment --------------------------------------------------------------------------- PHPCBF CAN FIX THE 30 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Entity/EasyEmailType.php ---------------------------------------------------------------------- FOUND 90 ERRORS AND 1 WARNING AFFECTING 90 LINES ---------------------------------------------------------------------- 80 | ERROR | [x] Doc comment short description must end with a full stop 87 | ERROR | [x] Doc comment short description must end with a full stop 94 | ERROR | [x] Doc comment short description must end with a full stop 101 | ERROR | [x] Doc comment short description must end with a full stop 157 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters 157 | ERROR | [x] Doc comment short description must end with a full stop 158 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 176 | ERROR | [ ] Missing short description in doc comment 181 | ERROR | [ ] Missing short description in doc comment 186 | ERROR | [x] Missing function doc comment 197 | ERROR | [ ] Missing short description in doc comment 198 | ERROR | [ ] Description for the @return value is missing 204 | ERROR | [ ] Missing short description in doc comment 205 | ERROR | [ ] Missing parameter comment 214 | ERROR | [ ] Missing short description in doc comment 215 | ERROR | [ ] Description for the @return value is missing 221 | ERROR | [ ] Missing short description in doc comment 222 | ERROR | [ ] Missing parameter comment 231 | ERROR | [ ] Missing short description in doc comment 232 | ERROR | [ ] Description for the @return value is missing 238 | ERROR | [ ] Missing short description in doc comment 239 | ERROR | [ ] Missing parameter comment 241 | ERROR | [ ] Description for the @return value is missing 248 | ERROR | [ ] Missing short description in doc comment 249 | ERROR | [ ] Description for the @return value is missing 255 | ERROR | [ ] Missing short description in doc comment 256 | ERROR | [ ] Missing parameter comment 260 | ERROR | [ ] Type hint "array" missing for $recipient 265 | ERROR | [ ] Missing short description in doc comment 266 | ERROR | [ ] Description for the @return value is missing 272 | ERROR | [ ] Missing short description in doc comment 273 | ERROR | [ ] Missing parameter comment 277 | ERROR | [ ] Type hint "array" missing for $cc 282 | ERROR | [ ] Missing short description in doc comment 283 | ERROR | [ ] Description for the @return value is missing 289 | ERROR | [ ] Missing short description in doc comment 290 | ERROR | [ ] Missing parameter comment 294 | ERROR | [ ] Type hint "array" missing for $bcc 299 | ERROR | [ ] Missing short description in doc comment 300 | ERROR | [ ] Description for the @return value is missing 306 | ERROR | [ ] Missing short description in doc comment 307 | ERROR | [ ] Missing parameter comment 316 | ERROR | [ ] Missing short description in doc comment 317 | ERROR | [ ] Description for the @return value is missing 323 | ERROR | [ ] Missing short description in doc comment 324 | ERROR | [ ] Missing parameter comment 333 | ERROR | [ ] Missing short description in doc comment 334 | ERROR | [ ] Description for the @return value is missing 340 | ERROR | [ ] Missing short description in doc comment 341 | ERROR | [ ] Missing parameter comment 350 | ERROR | [ ] Missing short description in doc comment 351 | ERROR | [ ] Description for the @return value is missing 357 | ERROR | [ ] Missing short description in doc comment 358 | ERROR | [ ] Missing parameter comment 367 | ERROR | [ ] Missing short description in doc comment 368 | ERROR | [ ] Description for the @return value is missing 374 | ERROR | [ ] Missing short description in doc comment 375 | ERROR | [ ] Missing parameter comment 384 | ERROR | [ ] Missing short description in doc comment 385 | ERROR | [ ] Description for the @return value is missing 391 | ERROR | [ ] Missing short description in doc comment 392 | ERROR | [ ] Missing parameter comment 396 | ERROR | [ ] Type hint "array" missing for $bodyHtml 401 | ERROR | [ ] Missing short description in doc comment 402 | ERROR | [ ] Description for the @return value is missing 408 | ERROR | [ ] Missing short description in doc comment 409 | ERROR | [ ] Missing parameter comment 418 | ERROR | [ ] Missing short description in doc comment 419 | ERROR | [ ] Description for the @return value is missing 425 | ERROR | [ ] Missing short description in doc comment 426 | ERROR | [ ] Missing parameter comment 428 | ERROR | [ ] Description for the @return value is missing 435 | ERROR | [ ] Missing short description in doc comment 436 | ERROR | [ ] Description for the @return value is missing 442 | ERROR | [ ] Missing short description in doc comment 443 | ERROR | [ ] Missing parameter comment 447 | ERROR | [ ] Type hint "array" missing for $attachment 452 | ERROR | [ ] Missing short description in doc comment 453 | ERROR | [ ] Description for the @return value is missing 459 | ERROR | [ ] Missing short description in doc comment 460 | ERROR | [ ] Missing parameter comment 469 | ERROR | [ ] Missing short description in doc comment 470 | ERROR | [ ] Description for the @return value is missing 476 | ERROR | [ ] Missing short description in doc comment 477 | ERROR | [ ] Missing parameter comment 479 | ERROR | [ ] Description for the @return value is missing 486 | ERROR | [ ] Missing short description in doc comment 487 | ERROR | [ ] Description for the @return value is missing 493 | ERROR | [ ] Missing short description in doc comment 494 | ERROR | [ ] Missing parameter comment 496 | ERROR | [ ] Description for the @return value is missing ---------------------------------------------------------------------- PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Entity/EasyEmail.php ---------------------------------------------------------------------------------------------- FOUND 104 ERRORS AND 1 WARNING AFFECTING 105 LINES ---------------------------------------------------------------------------------------------- 87 | ERROR | [ ] Missing short description in doc comment 133 | ERROR | [x] Expected 1 blank line after function; 3 found 136 | ERROR | [ ] More than 2 empty lines are not allowed 152 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters 204 | ERROR | [ ] Missing short description in doc comment 211 | ERROR | [ ] Missing short description in doc comment 217 | ERROR | [x] Expected 1 blank line after function; 2 found 220 | ERROR | [ ] Missing short description in doc comment 230 | ERROR | [ ] Missing short description in doc comment 240 | ERROR | [ ] Missing short description in doc comment 250 | ERROR | [ ] Missing short description in doc comment 260 | ERROR | [ ] Missing short description in doc comment 270 | ERROR | [ ] Missing short description in doc comment 278 | ERROR | [x] Expected 1 blank line after function; 2 found 281 | ERROR | [ ] Missing short description in doc comment 288 | ERROR | [ ] Missing short description in doc comment 296 | ERROR | [ ] Missing short description in doc comment 300 | ERROR | [x] Expected one space after the comma, 0 found 303 | ERROR | [ ] Missing short description in doc comment 310 | ERROR | [ ] Missing short description in doc comment 313 | ERROR | [ ] Public method name "EasyEmail::getCC" is not in lowerCamel format 320 | ERROR | [ ] Missing short description in doc comment 323 | ERROR | [ ] Public method name "EasyEmail::setCC" is not in lowerCamel format 330 | ERROR | [ ] Missing short description in doc comment 333 | ERROR | [ ] Public method name "EasyEmail::getCCIds" is not in lowerCamel format 340 | ERROR | [ ] Missing short description in doc comment 343 | ERROR | [ ] Public method name "EasyEmail::setCCIds" is not in lowerCamel format 350 | ERROR | [ ] Missing short description in doc comment 353 | ERROR | [ ] Public method name "EasyEmail::addCC" is not in lowerCamel format 360 | ERROR | [ ] Missing short description in doc comment 363 | ERROR | [ ] Public method name "EasyEmail::removeCC" is not in lowerCamel format 370 | ERROR | [ ] Missing short description in doc comment 373 | ERROR | [ ] Public method name "EasyEmail::getCCAddresses" is not in lowerCamel format 380 | ERROR | [ ] Missing short description in doc comment 383 | ERROR | [ ] Public method name "EasyEmail::setCCAddresses" is not in lowerCamel format 390 | ERROR | [ ] Missing short description in doc comment 393 | ERROR | [ ] Public method name "EasyEmail::addCCAddress" is not in lowerCamel format 400 | ERROR | [ ] Missing short description in doc comment 403 | ERROR | [ ] Public method name "EasyEmail::removeCCAddress" is not in lowerCamel format 410 | ERROR | [ ] Missing short description in doc comment 413 | ERROR | [ ] Public method name "EasyEmail::getBCC" is not in lowerCamel format 420 | ERROR | [ ] Missing short description in doc comment 423 | ERROR | [ ] Public method name "EasyEmail::setBCC" is not in lowerCamel format 430 | ERROR | [ ] Missing short description in doc comment 433 | ERROR | [ ] Public method name "EasyEmail::getBCCIds" is not in lowerCamel format 440 | ERROR | [ ] Missing short description in doc comment 443 | ERROR | [ ] Public method name "EasyEmail::setBCCIds" is not in lowerCamel format 450 | ERROR | [ ] Missing short description in doc comment 453 | ERROR | [ ] Public method name "EasyEmail::addBCC" is not in lowerCamel format 460 | ERROR | [ ] Missing short description in doc comment 463 | ERROR | [ ] Public method name "EasyEmail::removeBCC" is not in lowerCamel format 470 | ERROR | [ ] Missing short description in doc comment 473 | ERROR | [ ] Public method name "EasyEmail::getBCCAddresses" is not in lowerCamel format 480 | ERROR | [ ] Missing short description in doc comment 483 | ERROR | [ ] Public method name "EasyEmail::setBCCAddresses" is not in lowerCamel format 490 | ERROR | [ ] Missing short description in doc comment 493 | ERROR | [ ] Public method name "EasyEmail::addBCCAddress" is not in lowerCamel format 500 | ERROR | [ ] Missing short description in doc comment 503 | ERROR | [ ] Public method name "EasyEmail::removeBCCAddress" is not in lowerCamel format 510 | ERROR | [ ] Missing short description in doc comment 520 | ERROR | [ ] Missing short description in doc comment 530 | ERROR | [ ] Missing short description in doc comment 540 | ERROR | [ ] Missing short description in doc comment 550 | ERROR | [ ] Missing short description in doc comment 560 | ERROR | [ ] Missing short description in doc comment 570 | ERROR | [ ] Missing short description in doc comment 577 | ERROR | [ ] Missing short description in doc comment 585 | ERROR | [ ] Missing short description in doc comment 595 | ERROR | [ ] Missing short description in doc comment 605 | ERROR | [ ] Missing short description in doc comment 610 | ERROR | [ ] The array declaration extends to column 101 (the limit is 80). The array content should be split up over multiple lines 615 | ERROR | [ ] Missing short description in doc comment 625 | ERROR | [ ] Missing short description in doc comment 635 | ERROR | [ ] Missing short description in doc comment 645 | ERROR | [ ] Missing short description in doc comment 655 | ERROR | [ ] Missing short description in doc comment 665 | ERROR | [ ] Missing short description in doc comment 675 | ERROR | [ ] Missing short description in doc comment 685 | ERROR | [ ] Missing short description in doc comment 695 | ERROR | [ ] Missing short description in doc comment 705 | ERROR | [ ] Missing short description in doc comment 715 | ERROR | [ ] Missing short description in doc comment 725 | ERROR | [ ] Missing short description in doc comment 735 | ERROR | [ ] Missing short description in doc comment 745 | ERROR | [ ] Missing short description in doc comment 755 | ERROR | [ ] Missing short description in doc comment 763 | ERROR | [ ] Missing short description in doc comment 777 | ERROR | [ ] Missing short description in doc comment 789 | ERROR | [x] Expected 1 blank line after function; 2 found 814 | ERROR | [ ] Missing short description in doc comment 815 | ERROR | [ ] Missing parameter comment 820 | ERROR | [ ] Type hint "\Drupal\Core\Field\EntityReferenceFieldItemList" missing for $field_item_list 835 | ERROR | [ ] Missing parameter comment 836 | ERROR | [ ] Missing parameter comment 850 | ERROR | [x] Function comment short description must start with exactly one space 852 | ERROR | [ ] Missing parameter comment 853 | ERROR | [ ] Missing parameter comment 870 | ERROR | [ ] Missing short description in doc comment 871 | ERROR | [ ] Missing parameter comment 876 | ERROR | [ ] Type hint "\Drupal\Core\Field\FieldItemList" missing for $field_item_list 892 | ERROR | [ ] Missing parameter comment 893 | ERROR | [ ] Missing parameter comment 907 | ERROR | [x] Function comment short description must start with exactly one space 909 | ERROR | [ ] Missing parameter comment 910 | ERROR | [ ] Missing parameter comment ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Entity/EasyEmailTypeInterface.php ---------------------------------------------------------------------- FOUND 80 ERRORS AFFECTING 80 LINES ---------------------------------------------------------------------- 13 | ERROR | [ ] Missing short description in doc comment 14 | ERROR | [ ] Description for the @return value is missing 16 | ERROR | [x] Expected 1 blank line before function; 2 found 18 | ERROR | [ ] Missing short description in doc comment 19 | ERROR | [ ] Missing parameter comment 25 | ERROR | [ ] Missing short description in doc comment 26 | ERROR | [ ] Description for the @return value is missing 30 | ERROR | [ ] Missing short description in doc comment 31 | ERROR | [ ] Missing parameter comment 37 | ERROR | [ ] Missing short description in doc comment 38 | ERROR | [ ] Description for the @return value is missing 42 | ERROR | [ ] Missing short description in doc comment 43 | ERROR | [ ] Missing parameter comment 45 | ERROR | [ ] Description for the @return value is missing 49 | ERROR | [ ] Missing short description in doc comment 50 | ERROR | [ ] Description for the @return value is missing 54 | ERROR | [ ] Missing short description in doc comment 55 | ERROR | [ ] Missing parameter comment 59 | ERROR | [ ] Type hint "array" missing for $recipient 61 | ERROR | [ ] Missing short description in doc comment 62 | ERROR | [ ] Description for the @return value is missing 66 | ERROR | [ ] Missing short description in doc comment 67 | ERROR | [ ] Missing parameter comment 71 | ERROR | [ ] Type hint "array" missing for $cc 73 | ERROR | [ ] Missing short description in doc comment 74 | ERROR | [ ] Description for the @return value is missing 78 | ERROR | [ ] Missing short description in doc comment 79 | ERROR | [ ] Missing parameter comment 83 | ERROR | [ ] Type hint "array" missing for $bcc 85 | ERROR | [ ] Missing short description in doc comment 86 | ERROR | [ ] Description for the @return value is missing 90 | ERROR | [ ] Missing short description in doc comment 91 | ERROR | [ ] Missing parameter comment 97 | ERROR | [ ] Missing short description in doc comment 98 | ERROR | [ ] Description for the @return value is missing 102 | ERROR | [ ] Missing short description in doc comment 103 | ERROR | [ ] Missing parameter comment 109 | ERROR | [ ] Missing short description in doc comment 110 | ERROR | [ ] Description for the @return value is missing 114 | ERROR | [ ] Missing short description in doc comment 115 | ERROR | [ ] Missing parameter comment 121 | ERROR | [ ] Missing short description in doc comment 122 | ERROR | [ ] Description for the @return value is missing 126 | ERROR | [ ] Missing short description in doc comment 127 | ERROR | [ ] Missing parameter comment 133 | ERROR | [ ] Missing short description in doc comment 134 | ERROR | [ ] Description for the @return value is missing 138 | ERROR | [ ] Missing short description in doc comment 139 | ERROR | [ ] Missing parameter comment 145 | ERROR | [ ] Missing short description in doc comment 146 | ERROR | [ ] Description for the @return value is missing 150 | ERROR | [ ] Missing short description in doc comment 151 | ERROR | [ ] Missing parameter comment 155 | ERROR | [ ] Type hint "array" missing for $bodyHtml 157 | ERROR | [ ] Missing short description in doc comment 158 | ERROR | [ ] Description for the @return value is missing 162 | ERROR | [ ] Missing short description in doc comment 163 | ERROR | [ ] Missing parameter comment 169 | ERROR | [ ] Missing short description in doc comment 170 | ERROR | [ ] Description for the @return value is missing 174 | ERROR | [ ] Missing short description in doc comment 175 | ERROR | [ ] Missing parameter comment 177 | ERROR | [ ] Description for the @return value is missing 181 | ERROR | [ ] Missing short description in doc comment 182 | ERROR | [ ] Description for the @return value is missing 186 | ERROR | [ ] Missing short description in doc comment 187 | ERROR | [ ] Missing parameter comment 191 | ERROR | [ ] Type hint "array" missing for $attachment 193 | ERROR | [ ] Missing short description in doc comment 194 | ERROR | [ ] Description for the @return value is missing 198 | ERROR | [ ] Missing short description in doc comment 199 | ERROR | [ ] Missing parameter comment 205 | ERROR | [ ] Missing short description in doc comment 206 | ERROR | [ ] Description for the @return value is missing 210 | ERROR | [ ] Missing short description in doc comment 211 | ERROR | [ ] Missing parameter comment 217 | ERROR | [ ] Missing short description in doc comment 218 | ERROR | [ ] Description for the @return value is missing 222 | ERROR | [ ] Missing short description in doc comment 223 | ERROR | [ ] Missing parameter comment ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/EasyEmailListBuilder.php ---------------------------------------------------------------------- FOUND 8 ERRORS AND 1 WARNING AFFECTING 8 LINES ---------------------------------------------------------------------- 16 | ERROR | [ ] Missing short description in doc comment 49 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 51 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 6 55 | WARNING | [x] Inline @var declarations should use the /** */ delimiters 76 | ERROR | [ ] Missing short description in doc comment 80 | ERROR | [x] Expected 1 space after "="; 2 found 87 | ERROR | [x] Expected 1 blank line after function; 2 found 90 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------- PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/EasyEmailTranslationHandler.php ----------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE ----------------------------------------------------------------------------- 12 | WARNING | [x] There must be no blank line following an inline comment 12 | WARNING | [ ] There must be no blank line following an inline comment ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Controller/EasyEmailController.php ---------------------------------------------------------------------------------------------- FOUND 22 ERRORS AND 10 WARNINGS AFFECTING 31 LINES ---------------------------------------------------------------------------------------------- 15 | WARNING | [x] Unused use statement 27 | ERROR | [ ] Missing short description in doc comment 32 | ERROR | [ ] Missing short description in doc comment 40 | ERROR | [ ] Missing parameter comment 41 | ERROR | [ ] Missing parameter comment 46 | ERROR | [x] Expected 1 blank line after function; 2 found 49 | ERROR | [x] Missing function doc comment 56 | ERROR | [x] Missing function doc comment 65 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 74 | ERROR | [x] Missing function doc comment 75 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 87 | ERROR | [x] Missing function doc comment 89 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 100 | ERROR | [x] Missing function doc comment 101 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 105 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 110 | ERROR | [x] Missing function doc comment 114 | ERROR | [x] Missing function doc comment 115 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 127 | ERROR | [x] Missing function doc comment 128 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 130 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 167 | ERROR | [ ] The array declaration extends to column 182 (the limit is 80). The array content should be split up over multiple lines 167 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 187 | ERROR | [ ] The array declaration extends to column 146 (the limit is 80). The array content should be split up over multiple lines 211 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 213 | ERROR | [ ] The array declaration extends to column 157 (the limit is 80). The array content should be split up over multiple lines 226 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 227 | ERROR | [ ] The array declaration extends to column 118 (the limit is 80). The array content should be split up over multiple lines 252 | ERROR | [ ] The array declaration extends to column 160 (the limit is 80). The array content should be split up over multiple lines 253 | ERROR | [ ] The array declaration extends to column 132 (the limit is 80). The array content should be split up over multiple lines 260 | ERROR | [ ] The array declaration extends to column 141 (the limit is 80). The array content should be split up over multiple lines ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/EasyEmailTypeHtmlRouteProvider.php ----------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------- 7 | WARNING | [x] Unused use statement 23 | WARNING | [x] There must be no blank line following an inline comment 23 | WARNING | [ ] There must be no blank line following an inline comment ----------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/EasyEmailHtmlRouteProvider.php ---------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------- 60 | ERROR | [x] Missing function doc comment 83 | ERROR | [x] Missing function doc comment ---------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/EasyEmailStorage.php ------------------------------------------------------------------------ FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------ 10 | WARNING | [x] Unused use statement 84 | ERROR | [ ] Missing short description in doc comment ------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------ FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Service/EmailUserEvaluator.php ---------------------------------------------------------------------------- FOUND 11 ERRORS AFFECTING 10 LINES ---------------------------------------------------------------------------- 11 | ERROR | [x] Missing class doc comment 13 | ERROR | [ ] Missing short description in doc comment 18 | ERROR | [ ] Missing short description in doc comment 23 | ERROR | [ ] Missing short description in doc comment 31 | ERROR | [ ] Missing parameter comment 32 | ERROR | [ ] Missing parameter comment 41 | ERROR | [x] Expected 1 blank line after function; 2 found 44 | ERROR | [ ] Missing short description in doc comment 87 | ERROR | [x] Expected 1 blank line after function; 2 found 90 | ERROR | [x] Expected 1 newline at end of file; 0 found 90 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Service/EmailUserEvaluatorInterface.php ---------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------------- 7 | ERROR | [x] Missing interface doc comment 12 | ERROR | [ ] Missing parameter comment 16 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Service/EmailAttachmentEvaluator.php -------------------------------------------------------------------------------- FOUND 20 ERRORS AND 5 WARNINGS AFFECTING 22 LINES -------------------------------------------------------------------------------- 3 | ERROR | [x] There must be one blank line after the namespace declaration 11 | WARNING | [x] Unused use statement 12 | WARNING | [x] Unused use statement 15 | ERROR | [x] Missing class doc comment 17 | ERROR | [ ] Missing short description in doc comment 22 | ERROR | [ ] Missing short description in doc comment 27 | ERROR | [ ] Missing short description in doc comment 33 | ERROR | [x] Doc comment short description must end with a full stop 35 | ERROR | [ ] Missing parameter comment 36 | ERROR | [ ] Missing parameter comment 37 | ERROR | [ ] Missing parameter comment 45 | ERROR | [ ] Missing short description in doc comment 52 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters 56 | ERROR | [x] Comments may not appear after statements 60 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 74 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 79 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters 106 | ERROR | [ ] Missing short description in doc comment 106 | ERROR | [ ] Parameter $source is not described in comment 106 | ERROR | [ ] Parameter $dest_directory is not described in comment 107 | ERROR | [ ] Missing parameter comment 108 | ERROR | [ ] Missing parameter comment 108 | ERROR | [ ] Doc comment for parameter $file does not match actual variable name $dest_directory 111 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 116 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Service/EmailAttachmentEvaluatorInterface.php ---------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------- 7 | ERROR | [x] Missing interface doc comment 13 | ERROR | [x] Parameter comment must end with a full stop 18 | ERROR | [x] Additional blank lines found at end of doc comment 21 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Service/EmailTokenEvaluatorInterface.php ----------------------------------------------------------------------------- FOUND 15 ERRORS AFFECTING 15 LINES ----------------------------------------------------------------------------- 8 | ERROR | [x] Missing interface doc comment 13 | ERROR | [ ] Missing parameter comment 17 | ERROR | [ ] Missing short description in doc comment 18 | ERROR | [ ] Missing parameter comment 19 | ERROR | [ ] Missing parameter comment 20 | ERROR | [ ] Missing parameter comment 22 | ERROR | [ ] Description for the @return value is missing 26 | ERROR | [ ] Missing short description in doc comment 27 | ERROR | [ ] Missing parameter comment 29 | ERROR | [ ] Description for the @return value is missing 33 | ERROR | [ ] Missing short description in doc comment 34 | ERROR | [ ] Missing parameter comment 35 | ERROR | [ ] Missing parameter comment 37 | ERROR | [ ] Description for the @return value is missing 41 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Service/EmailTokenEvaluator.php ----------------------------------------------------------------------------- FOUND 16 ERRORS AND 2 WARNINGS AFFECTING 18 LINES ----------------------------------------------------------------------------- 3 | ERROR | [x] There must be one blank line after the namespace declaration 6 | WARNING | [x] Unused use statement 14 | ERROR | [x] Missing class doc comment 16 | ERROR | [ ] Missing short description in doc comment 21 | ERROR | [ ] Missing short description in doc comment 27 | ERROR | [x] Doc comment short description must end with a full stop 29 | ERROR | [ ] Missing parameter comment 30 | ERROR | [ ] Missing parameter comment 37 | ERROR | [ ] Missing short description in doc comment 70 | ERROR | [x] Missing function doc comment 85 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found 93 | ERROR | [ ] Missing short description in doc comment 94 | ERROR | [ ] Description for the @return value is missing 99 | WARNING | [x] A comma should follow the last multiline array item. Found: 'cancel-url' 103 | ERROR | [ ] Missing short description in doc comment 118 | ERROR | [x] Expected 1 blank line after function; 2 found 121 | ERROR | [ ] Missing short description in doc comment 139 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Service/EmailHandler.php ---------------------------------------------------------------------- FOUND 77 ERRORS AND 6 WARNINGS AFFECTING 73 LINES ---------------------------------------------------------------------- 15 | WARNING | [x] Unused use statement 18 | ERROR | [x] Missing class doc comment 41 | ERROR | [ ] Missing short description in doc comment 46 | ERROR | [ ] Missing short description in doc comment 51 | ERROR | [ ] Missing short description in doc comment 56 | ERROR | [ ] Missing short description in doc comment 61 | ERROR | [ ] Missing short description in doc comment 66 | ERROR | [ ] Missing short description in doc comment 71 | ERROR | [ ] Missing short description in doc comment 76 | ERROR | [ ] Missing short description in doc comment 81 | ERROR | [ ] Missing short description in doc comment 86 | ERROR | [ ] Missing short description in doc comment 91 | ERROR | [ ] Parameter $eventDispatcher is not described in comment 94 | ERROR | [ ] Missing parameter comment 95 | ERROR | [ ] Missing parameter comment 96 | ERROR | [ ] Missing parameter comment 97 | ERROR | [ ] Missing parameter comment 98 | ERROR | [ ] Missing parameter comment 99 | ERROR | [ ] Missing parameter comment 100 | ERROR | [ ] Missing parameter comment 101 | ERROR | [ ] Missing parameter comment 122 | ERROR | [ ] Missing short description in doc comment 129 | ERROR | [ ] Missing short description in doc comment 149 | ERROR | [ ] Missing short description in doc comment 186 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters 195 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 204 | ERROR | [x] Expected 1 space after IF keyword; 0 found 204 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 214 | ERROR | [ ] Missing short description in doc comment 215 | ERROR | [ ] Missing parameter comment 216 | ERROR | [ ] Missing parameter comment 218 | ERROR | [ ] Description for the @return value is missing 225 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 264 | ERROR | [ ] Missing short description in doc comment 292 | ERROR | [ ] Missing short description in doc comment 293 | ERROR | [ ] Missing parameter comment 294 | ERROR | [ ] Missing parameter comment 296 | ERROR | [ ] Description for the @return value is missing 298 | ERROR | [ ] Type hint "array" missing for $params 314 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 321 | ERROR | [x] No space found before comment text; expected "// $body_without_inbox = $body['body'];" but found "//$body_without_inbox = | | $body['body'];" 322 | ERROR | [x] Comments may not appear after statements 322 | ERROR | [x] No space found before comment text; expected "// $this->renderInNewContext($body);" but found "//$this->renderInNewContext($body);" 324 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters 324 | ERROR | [x] No space found before comment text; expected "// $converter = new Html2Text($this->renderInNewContext($body_without_inbox));" but found | | "//$converter = new Html2Text($this->renderInNewContext($body_without_inbox));" 325 | ERROR | [x] No space found before comment text; expected "// $params['plain'] = trim($converter->getText());" but found "//$params['plain'] = | | trim($converter->getText());" 329 | ERROR | [x] Comments may not appear after statements 329 | ERROR | [x] No space found before comment text; expected "// $this->renderInNewContext();" but found "//$this->renderInNewContext();" 330 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters 330 | ERROR | [x] Comments may not appear after statements 330 | ERROR | [x] No space found before comment text; expected "// $this->renderInNewContext(, TRUE);" but found "//$this->renderInNewContext(, TRUE);" 334 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 336 | ERROR | [x] Comments may not appear after statements 336 | ERROR | [x] No space found before comment text; expected "// $this->renderInNewContext();" but found "//$this->renderInNewContext();" 339 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 341 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters 341 | ERROR | [x] Comments may not appear after statements 341 | ERROR | [x] No space found before comment text; expected "// $this->renderInNewContext(, TRUE);" but found "//$this->renderInNewContext(, TRUE);" 344 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 370 | ERROR | [ ] Missing short description in doc comment 371 | ERROR | [ ] Missing parameter comment 373 | ERROR | [ ] Description for the @return value is missing 375 | ERROR | [ ] Protected method name "EmailHandler::hasHTMLBody" is not in lowerCamel format 379 | ERROR | [ ] Missing short description in doc comment 380 | ERROR | [ ] Missing parameter comment 382 | ERROR | [ ] Description for the @return value is missing 388 | ERROR | [ ] Missing short description in doc comment 389 | ERROR | [ ] Missing parameter comment 391 | ERROR | [ ] Description for the @return value is missing 397 | ERROR | [ ] Missing short description in doc comment 398 | ERROR | [ ] Missing parameter comment 400 | ERROR | [ ] Description for the @return value is missing 420 | ERROR | [ ] Missing short description in doc comment 420 | ERROR | [ ] Parameter $plain_text is not described in comment 421 | ERROR | [ ] Missing parameter comment 423 | ERROR | [ ] Description for the @return value is missing 425 | ERROR | [ ] Type hint "array" missing for $build 434 | ERROR | [ ] Missing short description in doc comment 435 | ERROR | [ ] Missing parameter comment 437 | ERROR | [ ] Description for the @return value is missing 446 | ERROR | [ ] Missing short description in doc comment 447 | ERROR | [ ] Missing parameter comment 449 | ERROR | [ ] Description for the @return value is missing ---------------------------------------------------------------------- PHPCBF CAN FIX THE 23 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Service/EmailHandlerInterface.php ---------------------------------------------------------------------- FOUND 14 ERRORS AND 1 WARNING AFFECTING 15 LINES ---------------------------------------------------------------------- 7 | ERROR | [x] Missing interface doc comment 10 | ERROR | [x] Doc comment short description must end with a full stop 15 | ERROR | [ ] Description for the @return value is missing 17 | ERROR | [ ] Type hint "array" missing for $values 23 | ERROR | [x] Parameter comment must end with a full stop 34 | ERROR | [x] Parameter comment must end with a full stop 36 | ERROR | [x] Parameter comment must end with a full stop 38 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters 43 | ERROR | [ ] Type hint "array" missing for $params 45 | ERROR | [ ] Missing short description in doc comment 46 | ERROR | [ ] Missing parameter comment 47 | ERROR | [ ] Missing parameter comment 49 | ERROR | [ ] Description for the @return value is missing 51 | ERROR | [ ] Type hint "array" missing for $params 53 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Event/EasyEmailEvent.php ---------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 15 | ERROR | [ ] Missing short description in doc comment 24 | ERROR | [x] Parameter comment must end with a full stop 40 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/easy_email/src/Event/EasyEmailEvents.php ----------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ----------------------------------------------------------------------- 5 | ERROR | [x] Missing class doc comment 133 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------- Time: 1.34 secs; Memory: 28MB

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Merge request !2Coding standards fixed by running phpcbf → (Open) created by mohit.bansal623
Comment over 1 year ago →
🇮🇳India rassoni Bangalore
Issue was unassigned.
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
I am removing the assignment, since no progress have been done in four months.
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Assigned to priyanka_chauhan31
Comment about 1 year ago →
🇮🇳India priyanka_chauhan31 Noida
I'll be working on it.
Issue was unassigned.
Comment 10 months ago →
🇮🇳India zkhan.aamir
Unassigning due to inactivity.
Comment 10 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Since there is a 2.1.x branch, let's focus on that first.

I am not sure it is worth fixing all those warnings/errors in a single issue, especially because the module code needs to be changed to create a Drupal 9/10 release. I would rather focus on that, and change what reported here while doing that.
Comment 10 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Assigned to PrabuEla
Comment 10 months ago →
🇮🇳India PrabuEla chennai
Comment 10 months ago →
🇮🇳India zkhan.aamir
Unassigning due to inactivity.
Issue was unassigned.
Status changed to Needs review 10 months ago12:02pm 22 January 2024
Comment 10 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
(Please ignore my previous comment.)
Status changed to Needs work 10 months ago6:36pm 24 January 2024
Comment 10 months ago →
🇺🇸United States zengenuity
I took a quick glance at the merge request, and I see that all the 2 space indents have been replaced with 4 space indents. That's wrong by the Drupal coding standards. ( https://www.drupal.org/docs/develop/standards/php/php-coding-standards → ) So, I'm not going to dig further into the MR. If someone wants to find actual coding standard issues and follow up with an MR that addresses them, I'm happy to take a look at it again.
First commit to issue fork.
Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 9 months ago
Waiting for branch to pass
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7
last update 9 months ago
PHPLint Failed

Comment 9 months ago →

🇮🇳India zkhan.aamir

Hi,

MR #26 getting rejected. Please check.

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib/easy_email (2.1.x)
$ curl https://git.drupalcode.org/project/easy_email/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  715k    0  715k    0     0   752k      0 --:--:-- --:--:-- --:--:--  754k
patching file easy_email.install
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED -- saving rejects to file easy_email.install.rej
patching file easy_email.module
Hunk #2 FAILED at 57.
Hunk #3 FAILED at 232.
Hunk #4 succeeded at 878 (offset 15 lines).
Hunk #5 succeeded at 887 (offset 15 lines).
Hunk #6 succeeded at 967 (offset 15 lines).
2 out of 6 hunks FAILED -- saving rejects to file easy_email.module.rej
patching file easy_email.page.inc
Hunk #5 FAILED at 88.
1 out of 6 hunks FAILED -- saving rejects to file easy_email.page.inc.rej
patching file modules/easy_email_override/easy_email_override.module
patching file modules/easy_email_override/src/EmailOverrideHtmlRouteProvider.php
patching file modules/easy_email_override/src/EmailOverrideListBuilder.php
patching file modules/easy_email_override/src/Entity/EmailOverride.php
patching file modules/easy_email_override/src/Entity/EmailOverrideInterface.php
patching file modules/easy_email_override/src/Form/EmailOverrideDeleteForm.php
patching file modules/easy_email_override/src/Form/EmailOverrideForm.php
patching file modules/easy_email_override/src/Plugin/Email/Email.php
patching file modules/easy_email_override/src/Plugin/Email/EmailInterface.php
patching file modules/easy_email_override/src/Service/DeclaredEmailManager.php
patching file modules/easy_email_override/src/Service/DeclaredEmailManagerInterface.php
patching file modules/easy_email_override/src/Service/MailManager.php
Hunk #1 FAILED at 14.
1 out of 1 hunk FAILED -- saving rejects to file modules/easy_email_override/src/Service/MailManager.php.rej
patching file src/Controller/EasyEmailController.php
Hunk #1 FAILED at 22.
1 out of 1 hunk FAILED -- saving rejects to file src/Controller/EasyEmailController.php.rej
patching file src/EasyEmailAccessControlHandler.php
patching file src/EasyEmailHtmlRouteProvider.php
patching file src/EasyEmailListBuilder.php
Hunk #2 succeeded at 37 (offset 1 line).
Hunk #3 succeeded at 46 (offset 1 line).
Hunk #4 succeeded at 65 (offset 1 line).
Hunk #5 succeeded at 77 (offset 1 line).
Hunk #6 succeeded at 89 (offset 1 line).
patching file src/EasyEmailStorage.php
patching file src/EasyEmailStorageInterface.php
patching file src/EasyEmailTranslationHandler.php
patching file src/EasyEmailTypeHtmlRouteProvider.php
Hunk #1 FAILED at 21.
1 out of 1 hunk FAILED -- saving rejects to file src/EasyEmailTypeHtmlRouteProvider.php.rej
patching file src/EasyEmailTypeListBuilder.php
Hunk #2 FAILED at 41.
1 out of 2 hunks FAILED -- saving rejects to file src/EasyEmailTypeListBuilder.php.rej
patching file src/Entity/EasyEmail.php
Hunk #2 FAILED at 136.
1 out of 2 hunks FAILED -- saving rejects to file src/Entity/EasyEmail.php.rej
patching file src/Entity/EasyEmailInterface.php
patching file src/Entity/EasyEmailType.php
Hunk #1 succeeded at 61 (offset 1 line).
patching file src/Entity/EasyEmailTypeInterface.php
patching file src/Entity/EasyEmailViewsData.php
patching file src/Event/EasyEmailEvent.php
Hunk #1 succeeded at 10 with fuzz 2.
patching file src/Event/EasyEmailEvents.php
patching file src/Form/EasyEmailDeleteForm.php
patching file src/Form/EasyEmailForm.php
Hunk #1 FAILED at 16.
1 out of 1 hunk FAILED -- saving rejects to file src/Form/EasyEmailForm.php.rej
patching file src/Form/EasyEmailRevisionDeleteForm.php
patching file src/Form/EasyEmailRevisionRevertForm.php
patching file src/Form/EasyEmailRevisionRevertTranslationForm.php
patching file src/Form/EasyEmailTypeDeleteForm.php
patching file src/Form/EasyEmailTypeForm.php
Hunk #1 FAILED at 11.
1 out of 1 hunk FAILED -- saving rejects to file src/Form/EasyEmailTypeForm.php.rej
patching file src/Service/EmailAttachmentEvaluator.php
Hunk #1 FAILED at 12.
1 out of 1 hunk FAILED -- saving rejects to file src/Service/EmailAttachmentEvaluator.php.rej
patching file src/Service/EmailAttachmentEvaluatorInterface.php
patching file src/Service/EmailHandler.php
Hunk #1 FAILED at 15.
1 out of 1 hunk FAILED -- saving rejects to file src/Service/EmailHandler.php.rej
patching file src/Service/EmailHandlerInterface.php
patching file src/Service/EmailTokenEvaluator.php
Hunk #1 FAILED at 11.
1 out of 1 hunk FAILED -- saving rejects to file src/Service/EmailTokenEvaluator.php.rej
patching file src/Service/EmailTokenEvaluatorInterface.php
Hunk #1 FAILED at 5.
1 out of 1 hunk FAILED -- saving rejects to file src/Service/EmailTokenEvaluatorInterface.php.rej
patching file src/Service/EmailUserEvaluator.php
Hunk #1 FAILED at 8.
1 out of 1 hunk FAILED -- saving rejects to file src/Service/EmailUserEvaluator.php.rej
patching file src/Service/EmailUserEvaluatorInterface.php
patching file templates/easy-email-body-html.html.twig
patching file templates/easy-email-body-inbox-preview.html.twig
patching file templates/easy-email-body-plain.html.twig
patching file tests/src/Functional/EasyEmailSendTest.php
Hunk #1 FAILED at 9.
1 out of 1 hunk FAILED -- saving rejects to file tests/src/Functional/EasyEmailSendTest.php.rej
patching file tests/src/Functional/EasyEmailTemplateCreateTest.php
patching file tests/src/Functional/EasyEmailTemplatePreviewTest.php
Hunk #1 FAILED at 9.
1 out of 1 hunk FAILED -- saving rejects to file tests/src/Functional/EasyEmailTemplatePreviewTest.php.rej
patching file tests/src/Functional/EasyEmailTestBase.php
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 52.
Hunk #3 succeeded at 63 (offset -11 lines).
Hunk #4 succeeded at 77 (offset -10 lines).
Hunk #5 succeeded at 100 (offset -9 lines).
Hunk #6 succeeded at 124 (offset -9 lines).
Hunk #7 succeeded at 164 (offset -9 lines).
Hunk #8 succeeded at 185 (offset -9 lines).
Hunk #9 succeeded at 211 (offset -9 lines).
Hunk #10 succeeded at 232 (offset -9 lines).
Hunk #11 succeeded at 250 (offset -9 lines).
2 out of 11 hunks FAILED -- saving rejects to file tests/src/Functional/EasyEmailTestBase.php.rej

Assigned to Esha_Kundu
Comment 5 months ago →
Esha_Kundu
Hi,
There is a new development branch 3.0.x-dev, so I have updated the version.
I will work on the it.
Merge request !30Issue #3216431: Fix the issues reported by phpcs → (Open) created by Esha_Kundu
Issue was unassigned.
Status changed to Needs review 5 months ago12:02pm 1 July 2024
Comment 5 months ago →
Esha_Kundu
I have resolved the phpcs issues that were reported after running the following command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml easy_email
for the latest branch and raised MR !30
Please review the changes.

Comment 4 months ago →

Esha_Kundu

Hello,
I have resolved the merge conflict and found the following warnings that was not addressed,

FILE: ...modules/custom/easy_email/src/Controller/EasyEmailController.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
 339 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 339 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 379 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 386 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $vid
 402 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 435 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $langcode
 441 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $vid
 453 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $vid
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/src/Entity/EasyEmailType.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 169 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------


FILE: .../web/modules/custom/easy_email/src/Entity/EasyEmailInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...eb/modules/custom/easy_email/src/Service/EmailTokenEvaluator.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 5 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/src/Service/EmailHandler.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
  15 | WARNING | [x] Unused use statement
 196 | WARNING | [ ] Line exceeds 80 characters; contains 82
     |         |     characters
 231 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: ]
 235 | WARNING | [ ] Line exceeds 80 characters; contains 83
     |         |     characters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...pp/web/modules/custom/easy_email/src/Service/EasyEmailPurger.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 65 | WARNING | Line exceeds 80 characters; contains 86 characters
 69 | WARNING | Line exceeds 80 characters; contains 112 characters
----------------------------------------------------------------------


FILE: ...dules/custom/easy_email/src/Service/EmailAttachmentEvaluator.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------
  11 | WARNING | [x] Unused use statement
  12 | WARNING | [x] Unused use statement
 103 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 109 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 136 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $path
 142 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: $path
----------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: .../modules/custom/easy_email/src/Service/EmailHandlerInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 42 | WARNING | Line exceeds 80 characters; contains 97 characters
----------------------------------------------------------------------


FILE: ...dules/custom/easy_email/src/Form/EasyEmailRevisionRevertForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
 123 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 125 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait
     |         |     and $this->t() instead
 127 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...app/web/modules/custom/easy_email/src/Form/EasyEmailTypeForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 196 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 276 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 377 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
 387 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: ]
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/src/Form/EasyEmailForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------
  11 | WARNING | [x] Unused use statement
  73 | WARNING | [x] Inline @var declarations should use the /** */
     |         |     delimiters
 346 | WARNING | [ ] Line exceeds 80 characters; contains 83
     |         |     characters
 380 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: ]
 381 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: ]
 478 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 501 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 505 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 510 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 513 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...dules/custom/easy_email/src/Form/EasyEmailRevisionDeleteForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
   9 | WARNING | [x] Unused use statement
 111 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 113 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait
     |         |     and $this->t() instead
 115 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/src/EasyEmailStorage.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 10 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/src/EasyEmailListBuilder.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 57 | WARNING | [x] Inline @var declarations should use the /** */
    |         |     delimiters
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/easy_email.install
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 45 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found: )
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...sy_email/modules/easy_email_override/src/Service/MailManager.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 74 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
 76 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
 83 | WARNING | Line exceeds 80 characters; contains 93 characters
 95 | WARNING | Unused variable $result.
----------------------------------------------------------------------


FILE: ...modules/easy_email_override/src/Service/DeclaredEmailManager.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 73 | WARNING | Only string literals should be passed to t() where
    |         | possible
----------------------------------------------------------------------


FILE: /app/web/modules/custom/easy_email/easy_email.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
----------------------------------------------------------------------
   9 | WARNING | [x] Unused use statement
  10 | WARNING | [x] Unused use statement
  11 | WARNING | [x] Unused use statement
  15 | WARNING | [x] Unused use statement
  17 | WARNING | [x] Unused use statement
  18 | WARNING | [x] Unused use statement
  19 | WARNING | [x] Unused use statement
 173 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
 186 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: )
----------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...les/custom/easy_email/tests/src/Functional/EasyEmailTestBase.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 80 | WARNING | t() calls should be avoided in classes, use
    |         | \Drupal\Core\StringTranslation\StringTranslationTrait
    |         | and $this->t() instead
----------------------------------------------------------------------


FILE: ...easy_email/tests/src/Functional/EasyEmailTemplatePreviewTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
  40 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: 'html'
 114 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: 'html'
 193 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: 'html'
 405 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: 'html'
 473 | WARNING | [x] A comma should follow the last multiline array
     |         |     item. Found: 'html'
----------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 1.24 secs; Memory: 26MB

Hence, resolved all the wraning.
Please have a look.

Comment 4 months ago →
Esha_Kundu
Sorry for the multiple commits, found some errors in configuration pages after resolving the phpcs issue so fixed those.
Please review.
Status changed to Needs work 4 months ago12:14pm 16 July 2024

Comment 4 months ago →

🇵🇭Philippines cleavinjosh

Hi @Esha_Kundu,

I applied MR!30 and it was applied smoothly. However, I still encountered an issue after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.

➜  easy_email git:(3.0.x) curl https://git.drupalcode.org/project/easy_email/-/merge_requests/30.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  246k    0  246k    0     0   474k      0 --:--:-- --:--:-- --:--:--  474k
patching file README.md
patching file css/easy-email-preview.css
patching file easy_email.install
patching file easy_email.links.action.yml
patching file easy_email.links.task.yml
patching file easy_email.module
patching file easy_email.page.inc
patching file easy_email.post_update.php
patching file modules/easy_email_commerce/easy_email_commerce.module
patching file modules/easy_email_commerce/templates/easy-email-commerce-order-totals-html.html.twig
patching file modules/easy_email_override/config/schema/easy_email_override.schema.yml
patching file modules/easy_email_override/easy_email_override.install
patching file modules/easy_email_override/easy_email_override.links.action.yml
patching file modules/easy_email_override/easy_email_override.links.menu.yml
patching file modules/easy_email_override/easy_email_override.links.task.yml
patching file modules/easy_email_override/src/EmailOverrideHtmlRouteProvider.php
patching file modules/easy_email_override/src/Entity/EmailOverride.php
patching file modules/easy_email_override/src/Entity/EmailOverrideInterface.php
patching file modules/easy_email_override/src/Form/EmailOverrideForm.php
patching file modules/easy_email_override/src/Plugin/Email/Email.php
patching file modules/easy_email_override/src/Plugin/Email/EmailInterface.php
patching file modules/easy_email_override/src/Service/DeclaredEmailManager.php
patching file modules/easy_email_override/src/Service/MailManager.php
patching file src/Controller/EasyEmailController.php
patching file src/Drush/Commands/PurgeCommands.php
patching file src/EasyEmailAccessControlHandler.php
patching file src/EasyEmailHtmlRouteProvider.php
patching file src/EasyEmailListBuilder.php
patching file src/EasyEmailStorage.php
patching file src/EasyEmailStorageInterface.php
patching file src/EasyEmailTypeAccessControlHandler.php
patching file src/Entity/EasyEmail.php
patching file src/Entity/EasyEmailInterface.php
patching file src/Entity/EasyEmailType.php
patching file src/Entity/EasyEmailTypeInterface.php
patching file src/Event/EasyEmailEvent.php
patching file src/Event/EasyEmailEvents.php
patching file src/Form/EasyEmailForm.php
patching file src/Form/EasyEmailRevisionDeleteForm.php
patching file src/Form/EasyEmailRevisionRevertForm.php
patching file src/Form/EasyEmailSettingsForm.php
patching file src/Form/EasyEmailTypeForm.php
patching file src/Plugin/Action/SendEasyEmail.php
patching file src/Service/EasyEmailPurger.php
patching file src/Service/EasyEmailPurgerInterface.php
patching file src/Service/EmailAttachmentEvaluator.php
patching file src/Service/EmailAttachmentEvaluatorInterface.php
patching file src/Service/EmailHandler.php
patching file src/Service/EmailHandlerInterface.php
patching file src/Service/EmailTokenEvaluator.php
patching file src/Service/EmailTokenEvaluatorInterface.php
patching file src/Service/EmailUserEvaluator.php
patching file src/Service/EmailUserEvaluatorInterface.php
patching file tests/src/Functional/EasyEmailSendTest.php
patching file tests/src/Functional/EasyEmailTemplateCreateTest.php
patching file tests/src/Functional/EasyEmailTemplatePreviewTest.php
patching file tests/src/Functional/EasyEmailTestBase.php
➜  easy_email git:(3.0.x) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml easy_email

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/easy_email/modules/easy_email_override/src/Service/MailManager.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 74 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------------

Time: 3.12 secs; Memory: 24MB

➜  contrib

Thank you.

Pipeline finished with Failed
4 months ago
Total: 355s
#225568
Status changed to RTBC 4 months ago12:56pm 16 July 2024
Comment 4 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
The merge request is four commits ahead of the upstream repository and GitLab CI no longer reports PHP_CodeSniffer errors/warnings.
Comment 4 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
apaderno → changed the visibility of the branch 3216431-resolve-coding-standards to hidden.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!30Fix the issues reported by phpcs
Open

!2Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Merge Requests

!30Fix the issues reported by phpcsOpen

!2Fix the issues reported by phpcsOpen

Comments & Activities

!30Fix the issues reported by phpcs
Open

!2Fix the issues reported by phpcs
Open