I'll cut a new tag for this module and it'll cover this patch.
Patch applied and resolved.
#18 resolved the issue I had. Using ViewsData from the entity module instead of core allowed me to display the values of my custom list_string base field using the entity's form select list.
Thanks!
Now that D9 is EOL, this is no longer needed. D10 support is included in the latest alpha release.
Now that D9 is EOL, this is no longer needed. D10 support is included in the latest alpha release.
This is now merged and included in the first alpha release (2.0.0-alpha1)
My request was approved by Dmitriy.trt.
I'll go ahead and close this out now.
I have reached out to Dmitriy.trt via his Drupal.org contact tab asking for a review of this issue.
merauluka → created an issue.
Marking as "Needs review"
Updating this to a Feature Request given the increased scope. (sorry for all the pings)
Updating issue title and description with changes applied in MR.
I've, perhaps, made this patch bigger than it needed to be. Because it has two updates:
- Updates to allow for D10 compatibility (dropping D9 and lower)
- Adds support to override the langcode value in the URL with a custom value. This mimics what is currently used for the URL prefix language negotiation which is something we need for our project.
merauluka → created an issue.
nicxvan → credited merauluka → .
nicxvan → credited merauluka → .
nicxvan → credited merauluka → .
nicxvan → credited merauluka → .
I have created an MR using the recommendation from the original post. The MR updates the getFieldsToSkipFromTranslationChangesCheck method to skip fields from the content_moderation module.
A more flexible approach would be to make this feature configurable so other can define fields that they would like to ensure are skipped when performing a diff of untranslated fields on save.
I have been able to trigger this same error by:
* Enabling translation on content
* Creating a node and a translation of that node.
* Editing the original node and resaving with "Flag other translations as outdated" checked by default.
So, basically, we are unable to resave the default translation once a translation exists.
I am seeing this on Drupal 9.5.11.
nicxvan → credited merauluka → .
I have used this module on multiple projects over the years. I'm considering using it again, but I am hesitant to do so for this particular project without a stable release. I'd love to see a stable release for this module soon.
This looks good to me!
Why did I update the isEmpty() check when it wasn't actually related to the query parameters? The world may never know. smh
I've reverted that portion of my patch. Reattaching here for posterity....again.
Taking Berdir's advice and trying to update the setValue() function in RedirectSourceItem.php. I also updated the isEmpty() check to be a more basic empty() check.
This is captured in the issue fork (and merge request) I created against this issue. But I'm capturing it here as a patch file for posterity as well.
merauluka → made their first commit to this issue’s fork.
merauluka → created an issue.
volkswagenchick → credited merauluka → .