- First commit to issue fork.
- last update
over 1 year ago 29,371 pass - @rassoni opened merge request.
- Status changed to Needs review
over 1 year ago 9:01am 3 May 2023 - Status changed to RTBC
over 1 year ago 6:09pm 6 May 2023 - 🇺🇸United States smustgrave
Did a fresh install on 10.1 of the Umami profile
Everything imported correctly and is rendering without issue. Checked a few pages and the "How to make" section is there.
Question for the maintainers is any issue changing the machine name? Wasn't too sure since this is a demo profile.
- last update
over 1 year ago 29,379 pass - last update
over 1 year ago 29,380 pass - last update
over 1 year ago 29,383 pass - last update
over 1 year ago 29,388 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,387 pass, 2 fail - last update
over 1 year ago 29,388 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 29,395 pass - last update
over 1 year ago 29,399 pass 29:11 25:04 Running- last update
over 1 year ago 29,400 pass - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,409 pass - last update
over 1 year ago 29,415 pass - last update
over 1 year ago 29,420 pass - last update
over 1 year ago 29,420 pass - last update
over 1 year ago 29,402 pass, 2 fail - last update
over 1 year ago 29,429 pass - last update
over 1 year ago 29,430 pass - last update
over 1 year ago 29,430 pass - last update
over 1 year ago 29,430 pass - Status changed to Needs review
over 1 year ago 10:46am 22 June 2023 - 🇬🇧United Kingdom longwave UK
I'm not convinced "How to Make it" is correctly capitalised, nor is it necessarily better English? There was no discussion of which of the options from the IS we should actually use - personally I prefer "Method" or "Directions".
Also, the field label and machine name don't necessarily have to match. Maybe we should just change the label here?
- 🇮🇪Ireland markconroy
I've no problem with us changing the text, but as an Umami maintainer, I'd vote for "Directions" instead of "How to make it".
I also don't have a problem with us just changing the field label. I often have field machine name such as
field_teaser
and field label such asTeaser text (max 150 characters)
. This might also be a good example of how Drupal can handle different field names vs field labels. - Status changed to Needs work
over 1 year ago 10:15am 23 June 2023 - First commit to issue fork.
- last update
over 1 year ago 29,551 pass - @smaz opened merge request.
- last update
over 1 year ago 29,551 pass - 🇬🇧United Kingdom smaz England, UK
+1 as umami maintainer for 'Directions', if we're going with the approach of just changing the label I've created an MR for that:
https://git.drupalcode.org/project/drupal/-/merge_requests/4244
I guess this could also be added to 10.1.x too? Not sure if I need to do another MR for that?
- Status changed to Needs review
over 1 year ago 11:58am 23 June 2023 - Status changed to RTBC
over 1 year ago 11:56pm 23 June 2023 - 🇺🇸United States smustgrave
If just doing a label change MR 4244 seems good.
- last update
over 1 year ago 29,553 pass - last update
over 1 year ago 29,559 pass - last update
over 1 year ago 29,560 pass, 2 fail - last update
over 1 year ago 29,571 pass - last update
over 1 year ago 29,801 pass -
quietone →
committed e370dbe9 on 10.1.x
Issue #3038861 by smaz, vadim.hirbu, Rassoni, pawandubey, longwave,...
-
quietone →
committed e370dbe9 on 10.1.x
- Status changed to Fixed
over 1 year ago 2:29am 5 July 2023 - 🇳🇿New Zealand quietone
According to the Drupal Usability Core gate → any issue that changes the UI is have a usability review. I do not see a review here. However, there is agreement by two umami maintainers on the change. The proposed wording is also used on similar sites so we have some evidence that humans are used to the word in this context.
Committed to 11.x and cherry-picked to 10.1.x.
Thanks!
-
quietone →
committed 87832c6d on 11.x
Issue #3038861 by smaz, vadim.hirbu, Rassoni, pawandubey, longwave,...
-
quietone →
committed 87832c6d on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.