Fix the issues reported by phpcs

Created on 30 March 2023, almost 2 years ago
Updated 7 July 2023, over 1 year ago

Problem/Motivation

FILE: ~/projects/drupal-d10/modules/contrib/entity_language_fallback/entity_language_fallback.module
--------------------------------------------
FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 10 LINES
-----------------------------------------------
  15 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar()
     |         |     for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
  21 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
  30 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar()
     |         |     for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block
     |         |     templates."
  38 | ERROR   | [x] Expected 1 space after FOREACH keyword; 0 found
  87 | ERROR   | [x] There must be exactly one blank line before the tags in a doc comment
 102 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 121 | ERROR   | [x] Doc comment long description must start with a capital letter
 124 | ERROR   | [x] Trailing punctuation for @see references is not allowed.
 232 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 236 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
-------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/entity_language_fallback/entity_language_fallback.info.yml
-------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/entity_language_fallback/README.txt
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------
 36 | WARNING | [ ] Line exceeds 80 characters; contains 211 characters
 37 | WARNING | [ ] Line exceeds 80 characters; contains 151 characters
 50 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/entity_language_fallback/src/FallbackController.php
---------------------------------------------------
FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 9 LINES
----------------------------------------------------
  10 | ERROR   | [x] Missing class doc comment
  12 | ERROR   | [ ] Missing short description in doc comment
  17 | ERROR   | [ ] Class property $fallback_chain should use lowerCamel naming without underscores
  19 | ERROR   | [ ] Missing member variable doc comment
  21 | ERROR   | [ ] Missing short description in doc comment
  31 | ERROR   | [ ] Missing parameter type
  55 | WARNING | [x] '@todo: Consider using @cache.memory service for cache meta-data (8.6+).' should match the format '@todo Fix problem X here.'
 104 | WARNING | [ ] ConfigurableLanguage::load calls should be avoided in classes, use dependency injection instead
 114 | ERROR   | [x] Expected 1 space after FOREACH keyword; 0 found
--------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/entity_language_fallback/src/Plugin/search_api/datasource/ContentEntityFallback.php
-----------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
----------------------------------------------
  16 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters
  27 | ERROR   | [x] Doc comment short description must end with a full stop
  31 | ERROR   | [x] Additional blank lines found at end of doc comment
 109 | ERROR   | [x] list(...) is forbidden, use [...] instead.
 184 | ERROR   | [ ] Missing parameter comment
 188 | ERROR   | [x] Expected 1 blank line after function; 0 found
 189 | ERROR   | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------


FILE: ...sers/rashmi.krishnachand/projects/drupal-d10/modules/contrib/entity_language_fallback/src/Plugin/search_api/datasource/ContentEntityFallbackDeriver.php
-------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 19 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/entity_language_fallback/src/Plugin/search_api/processor/FallbackLanguage.php
------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------
 28 | ERROR   | [x] Doc comment short description must end with a full stop
 41 | WARNING | [ ] Unused variable $item_id.
 50 | ERROR   | [ ] The array declaration extends to column 122 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/entity_language_fallback/src/FallbackControllerInterface.php
-------------------------------------------------------
FOUND 13 ERRORS AND 1 WARNING AFFECTING 12 LINES
---------------------------------------------------------
  7 | ERROR   | [x] Missing interface doc comment
  7 | ERROR   | [x] Expected 1 space after interface name; 2 found
  7 | ERROR   | [x] Expected 1 space before opening brace; found 2
  9 | ERROR   | [ ] Missing short description in doc comment
 10 | ERROR   | [ ] Missing parameter comment
 12 | ERROR   | [x] Expected "array" but found "[]" for function return type
 13 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 20 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 30 | ERROR   | [ ] Missing short description in doc comment
 32 | ERROR   | [x] Parameter comment must end with a full stop
 34 | ERROR   | [x] Parameter comment must end with a full stop
 40 | ERROR   | [ ] Missing short description in doc comment
 41 | ERROR   | [ ] Missing parameter comment
 43 | ERROR   | [x] Expected "array" but found "[]" for function return type
----------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------

Time: 148ms; Memory: 10MB

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entity_language_fallback

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

1.4

Component

Code

Created by

🇮🇳India rassoni Bangalore

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024