Add a hook_help() to the Umami profile, and link to it from the toolbar when the Help module is enabled

Fixed Custom failed to patch #4for D10.
Addressed #5 feedback points.

I think that the "What to do when you are ready to build your Drupal website" should be split out with it's own tag. This would make it clearer that it is not a 'use' of Umami.

- Addressed

The <h3>s should be changed to <h2>s. This is a HTML schematic error and could be an a11y issue.

- Addressed

Fixed Custom failed to patch #17 for D10.

Sorry for converting patch into MR due to local CI failed.Please review MR.

Below points addressed:

• CSpell - demo-umani to correct word demo-umami
• I think that the "What to do when you are ready to build your Drupal website" should be split out with it's own tag. This would make it clearer that it is not a 'use' of Umami.
• The
  

  s should be changed to
  

  s. This is a HTML schematic error and could be an a11y issue.

Thanks for working on this @Rassoni. I think it's nearly ready. I've made some small changes to remove the dl elements and use heading elements instead, as I think this is more correct semantically for this use case.

Going to mark this but wanted to note

If a follow up should be opened to create help_topic for help_hook.

Visually this looks weird but think it's because the H3s are close in size to H2s

Visually this looks weird but think it's because the H3s are close in size to H2s

Yes, and if I remember correctly, this was using Claro, not Umami, for the admin theme, so maybe we could file a follow-up with Claro maintainers.

Not sure why this is removing experimental from the profile name, I think that needs UX and/or product manager review if we want to do that, it's currently there so people don't think they can install the profile and build a site from it.

Also should this still be hook_help or should it use a help topic at this point? There's not a direct replacement for hook_help() from the new help system yet, so the answer might be 'yes it should still use hook_help()' but wanted to check.

Thanks @catch

This should definitely NOT be removing "Experimental" from the profile name. Let's get that put back in before we move this to RTBC. With that being the case, I'm removing the "Needs product manager review tag".

Applied the MR 3879 and verified the help page see screenshot

Uninstalled help module

Verified "This site is intended for demonstration purposes." links to the Drupal page.

Hiding patches for clarity.

Committed 97ca061 and pushed to 11.x. Thanks!

It needs follow-up as the permission should be access help pages since 10.1 https://www.drupal.org/node/3344060 →

Filed follow-up MR https://git.drupalcode.org/project/drupal/-/merge_requests/6069

Small change seems fine.

Thank you for spotting that @andypost.

andypost → closed merge request !6069

longwave → closed merge request !3879

Automatically closed - issue fixed for 2 weeks with no activity.