Fix the issues reported by phpcs

Fixed coding standard and created MR. Please Review.

Verified MR!2. The patch applied cleanly and all the phpcs issues mentioned in the ticket are fixed now. Need RTBC+1.

I am setting the status to NW. See my comment on the MR.

@nyana_mvr:

I do not understand the comment "Need RTBC+1". If you have reviewed and tested the MR, then you can set the issue status to RTBC. Then later comments might include "+1 for RTBC".

Remember that the T in RTBC stands for "tested". Did you do any manual testing or run the module's automated tests?

@benjifisher I tested it only using the command phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig. That's why I put Need RTBC+1 in the comment. I have seen such comments from reviewers in other tickets also. Will avoid adding such comments if it is confusing.

Also, I have reverted the changes in line 280 as per your comment. So can we ignore WARNING | [ ] Unused variable $span_lang. in such cases?

@nayana_mvr: Thanks for updating the MR.

I rebased the MR on the 8.x-1.x branch. Thanks to 📌 Move automated tests to GitLab CI Fixed , that runs phpcs as a CI job.

I added a commit to sort the use statements, which is required by phpcs.

I reviewed the changes: they look correct to me. The CI job for phpcs passes.

I tested with Drupal 10.2.x, and basic functionality is working. However, I see this deprecation notice:

Deprecated function: Use of "self" in callables is deprecated in Drupal\typogrify\Typogrify::caps() (line 110 of modules/typogrify/src/Typogrify.php).

According to https://php.watch/versions/8.2/partially-supported-callable-deprecation, that pattern is deprecated in PHP 8.2. I think that is out of scope for this issue. Since Drupal 11 requires PHP 8.3, it should be fixed as part of 📌 Automated Drupal 11 compatibility fixes for typogrify Postponed .

Automatically closed - issue fixed for 2 weeks with no activity.