- Issue created by @Project Update Bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β these changes make this module compatible with Drupal 11! π
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-127659These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.9
- palantirnet/drupal-rector: 0.20.1
- First commit to issue fork.
- Status changed to Postponed
6 months ago 4:23am 8 May 2024 - πΊπΈUnited States benjifisher Boston area
I rebased the MR on the 8.1.x branch so that the tests run on CI (thanks to π Move automated tests to GitLab CI Fixed ). The tests all passed: so far, so good.
Then I tested manually with the latest 11.x, and noticed some errors when I enable the filter. I tested with 10.3.x and saw the same errors, but I did not see a problem with 10.2.x.
I opened π Typogrify does not validate its settings Needs review to fix the errors, and I am postponing this issue on that one.
- πΊπΈUnited States benjifisher Boston area
I am adding π Fix the issues reported by phpcs RTBC as a related issue. While testing that issue, I noticed some PHP 8.2 deprecation notices:
Deprecated function: Use of "self" in callables is deprecated in Drupal\typogrify\Typogrify::caps() (line 110 of modules/typogrify/src/Typogrify.php).
Since Drupal 11 requires PHP 8.3, I think we should fix that as part of this issue.
- Status changed to Needs work
6 months ago 11:21pm 9 May 2024 - πΊπΈUnited States benjifisher Boston area
I merged π Typogrify does not validate its settings Needs review , so this issue is now un-postponed.
I still need to fix the deprecations that I mentioned in #6. After some discussion on Slack (thanks to @mglaman, @bbrala, and @GΓ‘bor Hojtsy) I opened https://github.com/phpstan/phpstan/issues/10977, where @ondrejmirtes explained that I would need to run PHPStan at level 7 or higher to detect those deprecations.
-
benjifisher β
committed 89a3ab5e on 8.x-1.x
Issue #3435184: Automated Drupal 11 compatibility fixes for typogrify
-
benjifisher β
committed 89a3ab5e on 8.x-1.x
- Status changed to Fixed
6 months ago 11:54pm 9 May 2024 - πΊπΈUnited States benjifisher Boston area
Now that this issue is Fixed, I will tag an RC release.
Automatically closed - issue fixed for 2 weeks with no activity.