Rename $op operation in hook_node_grants[_alter]() and node_access_grants to $operation

hi, i checked D10.1 , $op argument is not found in documentations, can you specify where the changes need to be done, thanks

Better title as entity.api.php already using $operation

Patch replaces all a can find and related hook names

@rckstr_rohan re #4 use following patterns

$ git grep '($op,'
$ git grep ', $op,'
$ git grep ', $op)'

I have tested the patch #5, applied clearly
A small suggestion please change summery there is mentioned that to change in documentation but it's need to change in comment line in code

@Santosh_Verma CI testing patches, please do not post this kind of screenshots

Re#6 Documentation is all kinds of comments in code

+++ b/core/modules/book/tests/modules/book_breadcrumb_test/book_breadcrumb_test.module
@@ -11,7 +11,7 @@
- * Implements hook_node_access().
+ * Implements hook_ENTITY_TYPE_access().
...
 function book_breadcrumb_test_node_access(NodeInterface $node, $operation, AccountInterface $account) {

+++ b/core/modules/content_moderation/tests/src/Functional/NodeAccessTest.php
@@ -165,7 +165,7 @@ public function testPageAccess() {
     // Now create a private node that the user is not granted access to by the
-    // node grants, but is granted access via hook_node_access().
+    // node grants, but is granted access via hook_ENTITY_TYPE_access().
     // @see node_access_test_node_access

This changes could be moved to separate issue

Moved unrelated changes to 📌 Fix leftover mentions of hook_node_access to hook_ENTITY_TYPE_access Fixed

+++ b/core/modules/node/tests/modules/node_access_test/node_access_test.module
@@ -144,9 +144,9 @@ function node_access_test_add_field(NodeTypeInterface $type) {
- * Implements hook_node_access().
+ * Implements hook_ENTITY_TYPE_access().

this one probably better to keep here

Fix #10 as all mentions should be fixed same time

Applied the patch

See 3 more instances in the node module but none fall under the hooks in the issue summary.

hii, addressed the 3 $op in node.module, as they are not part of hooks [hook_query_alter() ] mentioned above, should they be replaced .

as per my suggestion this hooks also seems to be a part , please confirm, then will proceed with patch.

Thanks @andypost, I will take care of it in the next time

Re-roll after 📌 Fix leftover mentions of hook_node_access to hook_ENTITY_TYPE_access Fixed

Per 🌱 [policy, no patch] Document named arguments BC policy Fixed argument names are considered internal, so we can just go ahead here. Looks good. Committed/pushed to 10.1.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.