CsrfAccessCheck docblock extremely out of date

Here's an attempt at a more accurate and useful docblock.

I'm not going to run tests because that seems like a waste at this point.

Wonder if it would help to put the link into the comment?

That's not a bad idea, @smustgrave.

I searched core for links to docs and they are quite common. I hadn't realized that. There's even this:

@link https://www.drupal.org/docs/8/api/routing-system/parameters-in-routes

in the Drupal\Core\Entity\EntityAccessCheck class, which is an astonishingly similar case. So I'm bumping from "not a bad idea" to " very good idea." I'll set this back to NW for that @link.

Added link. Moving for review.
Thanks

Hi @_pratik_

Thanks for jumping in. The link you added is unfortunately not the link that @smustgrave and I were discussing. Here's an updated patch that adds the link in the IS and discussed by @smustgrave and me.

It still not necessary to run tests on this. We can trigger tests once the language has been settled on. Running tests now would be a waste of money and coal.

#6 looks good to me

Thank for the review, @longwave. I've changed the @link to a @see. I'm still intentionally holding off on running tests.

I'm also happy to make other edits to the proposed docblock as well! Nobody should feel the need to pull any punches here.

Patch Applied Successfully, did a sanity testing in D10 for URL token Access, no issue observed.

I don't think the review in #10 is sufficient or makes a lot of sense given that this is a documentation issue. I'm setting back to NR.

That's my mistake @danflanagan8 from #7 didn't know about the @endlink

But see we replaced with @see so should be good now.

The last submitted patch, 9: 3347067-9.patch, failed testing. View results →

Unrelated "random" failure in Drupal\Tests\media\FunctionalJavascript\MediaSourceFileTest. Back to RTBC.

Nowadays unrelated failure are more, any specific reasons, previously too test case were there.
Willing to investigate on these failures and how to quick fix them.

@rckstr_rohan, if you are interested in doing something about random test failures, this issue is the place to start: 🌱 [meta] Known intermittent, random, and environment-specific test failures Active

I suspect a "quick fix" may not be available however.

Committed 45e7bcd and pushed to 10.1.x. Thanks!

Discussed with @catch and backported to 10.0.x and 9.5.x

Automatically closed - issue fixed for 2 weeks with no activity.