- ๐ณ๐ฑNetherlands huijse
Tested #patch 6 on Drupal 9.4.5 and it works.
- ๐ซ๐ทFrance aiphes
Hello
What can we do if we don't use skeleton but get this error on D9.5 ?
Thanks
- ๐ฎ๐ณIndia rckstr_rohan
yeah i was getting the core same error, I don't use Skeleton, but my issue get fixed by patch #6 , thanks.
Drupal version: 9.4 - ๐บ๐ธUnited States kristi wachter
Same here - I'm not using Skeleton, but patch #6 fixed this error for me.
Is this something that could be committed?
Thank you!
- ๐ซ๐ทFrance aiphes
@Kristi Wachter , how do you apply the patch without skeleton module ?
- ๐น๐ณTunisia Slim Ch
@aiphes you need to apply the patch on Drupal core.
I had the same error and patch #6 fixed it, thanks @Nuaa.
Drupal version : 10.1.4 patch #6 fixed this error for me, thank you!
Drupal version: 9.5.11- ๐ฎ๐ณIndia mukhtarm
Why is this not there in the core yet? I am using D10.2.4 and Patch #6 works for me and resolved my problem.
- ๐ฎ๐ณIndia er.garg.karan Chandigarh
The patch #6 worked perfectly for me until I upgraded from Drupal 10.2 to 10.3 where this patch failed.
I was not able to apply this patch as it kept failing. Created a new patch (with the same code changes) for Drupal 10.3
- Status changed to Needs review
5 months ago 6:16pm 13 July 2024 - ๐ฎ๐ณIndia er.garg.karan Chandigarh
Hi @__VINAY
I see you have copied exactly same code from my patch in #17.
- ๐จ๐ฆCanada Ron Collins
Confirming the patch in #17 works with Drupal 10.3.1 and that the patch in #19 is exactly the same.
It might be a mistake. Or maybe a span account looking for quick cred? It's their only post. Maybe don't confirm the account based on this alone.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Liam Morland โ made their first commit to this issueโs fork.
- Merge request !2Issue #3275683: Add "#" before "attributes" key in skeletontheme_preprocess_page() โ (Open) created by Liam Morland
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
The patches in this issue are for Drupal core. To get a core fix committed, this issue needs to be moved to the Drupal core project.
However, the issue summary talks about the need to replace
attributes
with#attributes
inskeletontheme_preprocess_page()
. I have made this change in the merge request. Untested.