- 🇺🇸United States markie Albuquerque, NM
Removing patch 4 as it has a lot of unnecessary file changes. Lets work in the feature branch.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 3:34am 30 March 2023 - 🇮🇳India rckstr_rohan
Added a MR for the contribution.md file as per my understanding, suggestions are welcome, module looks good to be , will try to pick more issues, thanks.
- First commit to issue fork.
- Status changed to Needs work
about 1 year ago 11:04am 30 March 2023 - 🇺🇸United States ultimike Florida, USA
Thanks, @rckstr_rohan - almost there. Please see my comments above.
-mike
- Status changed to Needs review
about 1 year ago 2:29pm 30 March 2023 - Status changed to Needs work
about 1 year ago 3:47pm 30 March 2023 - Status changed to Needs review
about 1 year ago 4:32pm 30 March 2023 - 🇺🇸United States ultimike Florida, USA
@rckstr_rohan I know I'm being picky about this file - I just want to make sure that is as good as it can be so that other contrib modules can follow our lead, know what I mean.
Thanks so much for sticking with this issue!
-mike
- Status changed to Needs work
about 1 year ago 7:31am 31 March 2023 - Status changed to Needs review
about 1 year ago 3:03am 4 April 2023 - 🇮🇳India rckstr_rohan
Hi @ultimike, sorry for late response, have taken your comments in consideration and have made some changes, please review.
-
ultimike →
committed eb13cae3 on 2.0.x
#3264613: Missing contributor file - finishing touches (for now).
-
ultimike →
committed eb13cae3 on 2.0.x
- Status changed to Fixed
about 1 year ago 10:22am 4 April 2023 - 🇺🇸United States ultimike Florida, USA
Thanks @rckstr_rohan for helping get this over the finish line. I made a few updates before committing it.
-mike
- 🇺🇸United States ultimike Florida, USA
I failed to use the proper commit message, so giving credit here.
Sorry!
-mike Automatically closed - issue fixed for 2 weeks with no activity.