- Issue created by @cosmicdreams
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 10:39am 8 April 2023 - 🇮🇳India Ranjit1032002
Created a patch for removing Pencil icon, please review.
Thank You. - 🇺🇸United States cosmicdreams Minneapolis/St. Paul
Thanks @Ranjit1032002 can you provide it as a Merge Request?
- 🇮🇳India sonam.chaturvedi Pune
Verified and tested patch #5 with 2.0.x-dev version on drupal 10.1.x-dev.
Patch applied cleanlyTest Results:
Pencil icon is removed. However, I think title "Preview" should be aligned left.
Refer attached before and after screenshot - Status changed to Needs work
over 1 year ago 1:09am 12 April 2023 - 🇺🇸United States cosmicdreams Minneapolis/St. Paul
Cool. But can you provide this as an MR?
- 🇮🇳India rckstr_rohan
Hi, @cosmicdreams, reviwed the patch #5, it works well but the patch fixes is inside core, so or for MR need to ovwerwite the same class in the module css.
- @ranjit1032002 opened merge request.
- Status changed to Needs review
over 1 year ago 5:06am 12 April 2023 - 🇮🇳India Ranjit1032002
Hi, @cosmicdreams MR!35 created , please review.
Thank You. - Status changed to RTBC
over 1 year ago 5:55am 12 April 2023 - 🇮🇳India rckstr_rohan
The MR looks good, fixed the issue, also the preview is aligned as expected by @sonam.chaturvedi on #7 , thnks
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
Back to Needs Work with some review notes. I like the result, just have some comments about the implementation.
- Status changed to Needs work
over 1 year ago 6:07pm 27 April 2023 - Status changed to Needs review
over 1 year ago 5:24am 28 April 2023 - Assigned to sharayurajput
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 10:21am 2 May 2023 - 🇮🇳India sharayurajput
Merge request !35 reviewed, its working good as per requirement added screenshot for the reference
so moving status to RTBC - 🇺🇸United States cosmicdreams Minneapolis/St. Paul
The use of !important would have a severe impact to the rest of Drupal development as the styles introduced with this change would override other implementations in a way that would make it hard to undo. Please modify this change to exclude !important.
You can accomplish this be having greater selector specificity so that the scope of the change is assured to only impact our use case.
- Status changed to Needs work
over 1 year ago 1:18pm 2 May 2023 - Status changed to Needs review
over 1 year ago 2:56pm 2 May 2023 - 🇮🇳India Ranjit1032002
I have made changes in MR!35 by excluding !important, Please review.
- 🇮🇳India sharayurajput
its also working instead of using !important so now we can move this issue to RTBC
- Status changed to RTBC
over 1 year ago 7:30am 5 May 2023 - First commit to issue fork.
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
Finally getting around to merging this.
-
cosmicdreams →
committed 92b99bb2 on 2.0.x authored by
Ranjit1032002 →
Issue #3352976: Remove Pencil icon
-
cosmicdreams →
committed 92b99bb2 on 2.0.x authored by
Ranjit1032002 →
-
Ranjit1032002 →
authored 39e88e16 on 2.1.x
Issue #3352976: Remove Pencil icon fix additional issues found in new...
-
Ranjit1032002 →
authored 39e88e16 on 2.1.x
- Status changed to Fixed
over 1 year ago 3:05pm 8 June 2023 - 🇺🇸United States brianperry
This fix looks to be in both 2.0 and 2.1 so marking as fixed.
Automatically closed - issue fixed for 2 weeks with no activity.