Remove whitespace modifiers from links.html.twig

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I have tested the patch provided in comment #103 and it is successfully applied in drupal 10.1.

Patch #103, no longer applies to 10.1.x. I have re-rolled the patch. Please review

<h3>Heading</h3><ul><li>Text 1</li><li><span enabled>Text 2</span></li><li>&lt;a&gt;Link 1&lt;/a&gt;</li></ul>

This is the outcome using patch #118 is that desired?

Think this will need a different solution.

https://twig.symfony.com/doc/2.x/tags/spaceless.html

As of Twig 2.7, use the spaceless filter instead.

Not sure that's the approach we want to take

Applied the patch on #18 📌 Remove whitespace modifiers from links.html.twig Needs work cleanly.

Addressed #119 and #120, used https://twig.symfony.com/doc/2.x/tags/spaceless.html

120 was not addressed.

And what was addressed for 119? Didn’t say anything was off? Just stating what I saw.

Relooking at this and 118 May actually be correct. Moving review for 118

@smustgrave yeah now i noticed spaceless filter
{{
"

"|spaceless }}

is #118 good or should I make a patch to spaceless filter

Think 118 is fine.

This needs an issue summary update:

1. Do we actually need spaceless, or could we just remove the modifiers with no replacement? It adds an extra level of indentation and we don't tend to strip whitespace everywhere else?
2. What is/was the outcome of this from the issue summary? We should either try to figure that out, or open a follow-up.

Also, this template has a wrapping if statement:

{% if links -%}
...
{%- endif %}

The if was a direct copy of functionality from when this was a theme function. We cannot verify why it is still needed. Investigate whether it can be removed, and, if so, remove it.