Olivero: Rename "wide-image" CSS class to "wide-content"

#15 patch is not applied succesfully.

Created new patch for drupal version 10.1.x. Please review.

The last submitted patch, 17: 3281119-17.patch, failed testing. View results →

The last submitted patch, 22: 3281119-17.patch, failed testing. View results →

Providing the patch, Please review it.

Verified and tested Patch Comment #25 on drupal 10.1.x successfully.

Testing Steps:-
1. Install drupal 10.1.x version.
2 Applied Patch cleanly #25
3 checked the changes difference using git diff
3. Add an image to the article content type.
4. Observe the image content by inspecting elements to get the difference.

Testing result:
The "wide-image" CSS class was replaced by "wide-content" for Olivero.

Here I have attached the screenshots.

It's really unclear if this issue is using a patch or a merge request, and which one contains the fix. Please clarify where the work is being done on this issue. (And contributors, please follow that guidance.)

Whether patch or MR is chosen, the current ones don't apply. So after a path is chosen (patch or MR), reroll/rebase.

Also, posting screenshots of a terminal window applying the patch is not helpful. I've hidden the screenshot file showing terminal window. Screenshots are helpful if a patch affects a change in the UI itself. Please review https://www.drupal.org/community/contributor-guide/task/add-screenshots-... → -- especially the "Goal".

Thank you!

Fixed The Failed #25 Patch And re-roll The Patch For 11. x - dev.

Before you “reroll”: Please remember that the “Needs reroll” tag also applies to merge requests that need rebasing. I understand how this can be confusing. And, adding patches to an issue using merge requests can result in confusion and lost work. Please avoid doing that. Refer to the documentation on how to rebase a merge request:

https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

Comparing the MR in #8 that was set to needs review and the patches that followed, it’s clear that all of the patches that followed were incomplete — missing files and changes that were included or requested in the MR. (This is why we don’t want to switch between MR and patch workflow if it can be helped.)

Hiding all of the files since they derailed the issue (except for the ones showing the CSS class name changes in the inspector since I’m not sure how helpful those are or not). The MR (link in #8) is where work needs to resume from:

1. The MR needs to be rebased. The target branch probably needs to be updated as well.
2. The MR needs review — hint: the @file docblock in wide-content.pcss.css needs to conform to https://www.drupal.org/docs/develop/standards/php/api-documentation-and-... → with a summary and description with lines between.
3. When comments on the MR have been addressed, they should be marked as resolved. (The current unresolved comment was addressed, but the update doesn’t meet @file docblock coding standards.)

Please refrain from adding screenshots of terminal windows showing commands for applying a patch. The CI jobs and test runs will tell us if a code change cannot be merged. Screenshots are really only useful for showing a UI change or problem.

Removing credit where patches were added unnecessarily.

Rebased the MR in #8 and changed the target to 11.x with the required changes.

Reroll #33 appears to have been done correctly.

Searched theme for "wide-image" and all instances have been replaced.

lauriii → closed merge request !4229

Committed d582ba4 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.