Views interface - change "Show: Content" to "Show: Content view mode"

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Patch re-roll 😀

-mike

Getting some CS errors:

 98 | WARNING | t() calls should be avoided in classes, use
    |         | \Drupal\Core\StringTranslation\StringTranslationTrait
    |         | and $this->t() instead
    |         | (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
 

+++ b/core/modules/views/src/Plugin/Derivative/ViewsEntityRow.php
@@ -95,7 +95,7 @@ public function getDerivativeDefinitions($base_plugin_definition) {
+          'title' => t('@label view mode', ['@label' => $entity_type->getLabel()]),

Looks like you should be using $this->t() here.

Applied #19 on #18.
Please review.

Applied patch #20 on drupal version 10.1.x. It was successful ly applied and i got the solution. Adding screenshots for the reference.Need RTBC+1.

Hmmm coming back to this, I'm changing my mind about #8, the changed ordering of the items. It's not that I mind too much that 'Fields' is no longer the top one, I mind that the ordering in the screenshot doesn't make any sense, i.e. it seems unordered. Maybe the ordering was only correct by accident before, but this change still breaks that.
So I think we need to make sure that we keep something like an alphabetical order I think (which for core would put Fields back on top).

@lendude - thanks for the feedback, but unless I'm misunderstanding, the options are sorted alphabetically by Views::fetchPluginNames() - there's an asort() in there...

When configuring the "Show" for a View based on nodes, "Content view mode" is alphabetically first. Am I misunderstanding something?

-mike

@ultimike yeah for content it happens to look ok, but if you make a 'Media' view, it doesn't.

The ordering is indeed done by plugin, but by plugin machine name, which for all these entities is 'entity:what_ever_the_entity_id_is'. So they are always ordered by the letter 'e'.

Woot! Ready for a review.

Before and after screenshots added.

-mike

We looked at this together at Drupal Dev Days together, and it looks good now, good to see that existing test still pass

nod_ → closed merge request !11839

Committed 0f37fcb and pushed to 11.x. Thanks!