Contrib.social

Remove quotes from olivero.info.yml

Open on Drupal.org →
Created on 1 May 2022, almost 3 years ago
Updated 17 March 2023, almost 2 years ago

Problem/Motivation

In Olivero's olivero.info.yml file, some strings are quoted, others are not:

regions:
  header: Header
  primary_menu: 'Primary menu'
  secondary_menu: 'Secondary menu'
  hero: 'Hero (full width)'
  highlighted: Highlighted
  breadcrumb: Breadcrumb
  social: Social Bar
  content_above: Content Above
  content: Content
  sidebar: 'Sidebar'
  content_below: 'Content Below'
  footer_top: 'Footer Top'
  footer_bottom: 'Footer Bottom'

From https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/themes/olive...

The rules for strings in YAML are complicated, but since you don't need to quote a string, as long as the first character is not a special character, maybe we should just remove them for consistency? For more, see:

Proposed resolution

Remove all single quotes in olivero.info.yml.

Remaining tasks

  • Decide if removing all quotes is a good idea, or if alternatively all strings should be quoted?
  • Update Creating sub-themes → documentation page, depending on the decision.

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Needs review

Version

10.1 ✨

Component
Olivero  →

Last updated 4 days ago

Created by

🇩🇰Denmark ressa Copenhagen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024