Wrong message on cancelling account with e-mail confirmation request

This is still NW as per #13. I'm not sure about the suggested wording though. For example:

A confirmation request to cancel mstrelan has been sent to the user's email address.

I don't want to be cancelled!

A confirmation request to cancel mstrelan has been sent to the user's email address.

I don't want to be cancelled!

Yeah I wouldn't want to be cancelled either so maybe we need to revisit this 😀

re-rolling patch for 10.1.x

I had Reviewed the patch and it looks good and working as expected mentioned in comment #19

Issue needs to go back to usability group for another review, setting back to NR.

I have applied the patch #19. I think it's just a re-roll. It doesn't make any changes on message as per comment #13.

Adding a patch addressing the points mentioned in #13, removing out of scope code and updating message. please review.

Fixed CCF on #23

The last submitted patch, 24: 2980952-24.patch, failed testing. View results →

Updated the patch with test case changes.

The last submitted patch, 27: 2980952-27.patch, failed testing. View results →

The last submitted patch, 27: 2980952-27.patch, failed testing. View results →

The last submitted patch, 27: interdiff-2980952-24-27.patch, failed testing. View results →

Updated the testing scenario fixes.

The last submitted patch, 32: 2980952-32.patch, failed testing. View results →

Seems the fail is random. Keeping to Review.

+      else {
+        $messenger->addStatus($this->t("A confirmation request to cancel %name account has been sent to the user's email address.", ['%name' => $this->entity->label()]));
+      }

It should be to cancel the %name account, in the same way it is to the user's email address.

#35 comment has been addressed with the latest Patch.

#13 tagged this for issue summary update from the usability meeting at that time. Still needs to happen it seems.

Usability review

We discussed this issue at 📌 Drupal Usability Meeting 2023-08-04 Needs work . That issue will have a link to a recording of the meeting.

For the record, the attendees at today's usability meeting were @AaronMcHale, @Emma Horrell, @benjifisher, @rkoller, @simohell, and @worldlinemine.

We reviewed this in the context of the recent discussion. In comment #13 we recommended the following:

A confirmation request to cancel %name% has been sent to the user's email address.

However, it was pointed out that this wording could imply that the person themselves is being cancelled, and to quote @mstrelan in comment #17:

A confirmation request to cancel mstrelan has been sent to the user's email address.

I don't want to be cancelled!

With that in mind, we are now recommending the following wording, which should address the concern and is a slightly variation on the previous recommendation, adding the text "the account":

A confirmation request to cancel the account %name has been sent to the user's email address.

We also considered a slightly shorter version, without the text "to the user's email address", however while we normally follow the less-is-more principle, we felt it was better to be explicit that the request is indeed being sent to the user's email address.

I should also note that if #3229146: Rename "Account cancellation" to "Account closure" in UI → is done, then this wording will change again slightly, replacing the word "cancel" with the word "close".

Also cleaning up the issue summary as it's a bit out of date now.

Updated previous comment to note other variations on account %name that were considered. I think this still needs an IS update, so leaving that tag.

Akhil Babu → made their first commit to this issue’s fork.

The issue summary is clear and up to date. So removing the tag
I have changed the message to A confirmation request to cancel the account %name has been sent to the user's email address as suggested in #40

Hi @Akhil Babu, I've Tested the shared MR-MR !6303 mergeable on Drupal Version- 11.0-dev, The Patch was applied successfully and looks good to me.

Testing Steps:

1. Install Drupal-11.
2. Go to> admin/people- Create a new user.
3. Edit the user & Click on the Cancel Account and Check the 'Require email confirmation' check box. Attached before results.
4. Download the shared patch & apply.
5. Go to> admin/people- Edit the user & follow the above steps to re-verify this.

Testing Results:
After applying the patch, the confirmation message has been changed. RTBC++

I think the code here is currently not working the way we expect it to, i.e. the condition is always false and therefore the case where the user is cancelling their account is showing the wrong message.

This likely means some of the test changes were not correct