In the modal remove button colour does not match with the design.

Created on 8 February 2024, over 1 year ago

Problem/Motivation

In the modal remove button colour does not match with the design. See the attached screenshot for reference.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @shweta__sharma
  • 🇮🇳India rinku jacob 13 Kerala

    Hi @shweta__sharma, Base theme of adminal theme is seven. so remove button color is inherited from seven theme.
    do we need to follow any theme/design to style remove button?
    for the example in claro theme they are used different style for remove button compared to other buttons. so can you please give any suggestion to style that.

  • First commit to issue fork.
  • First commit to issue fork.
  • 🇮🇳India hritick

    I have fixed the issue and attached a screenshot as reference

  • 🇫🇷France AimadBachar

    Hello,
    The patch works and displays the button when adding media, thanks.

  • Status changed to Needs review about 1 year ago
  • Assigned to kpap
  • 🇬🇷Greece kpap

    Previous changes seemed to not match adminimal's style guide.
    Fixed it in my latest commit.

  • 🇮🇳India sdhruvi5142

    Hi,

    Without applying any patch on drupal 10.3, I don't see any color issue on Remove button, its color looks proper as per the theme. Adding screenshot for reference.

    Please share steps if anyone is facing issue. This require further review so keeping this issue in Need Review.

    Thanks

  • 🇮🇳India Kanchan Bhogade

    Hi
    I have tried to reproduce issue on Drupal 10.3.x with Adminimal theme version 8.x.1.x dev
    but no color issue occurs remove button, button color already compatible..

    Attaching screenshot for reference

  • Hello,
    I've reviewed the issue following the steps mentioned below:

    1. Installed theme version 8.x-1.7 in Drupal version 10.4.7.
    2. Set this theme as the Administration theme.
    3. Ensure that a media & image field is present in the Content Type; if not, add both the fields.
    4. On the add/edit page of a content, add a media file in the media field.
    5. A modal opens with a cross icon representing the remove button, which differs significantly from the remove button that appears for the image field in this theme.
    6. Applied the MR!13 cleanly.
    7. Repeated step 4 and found the button similar to that of the image field. The hover is also aligned with the buttons in this theme.

    Attaching SS for reference. I am also updating the issue summary for improved clarity. Moving to RTBC.
    Thanks

Production build 0.71.5 2024