🇮🇳India @hritick

Hey @janakkha ,

I have reviewed the MR in #6. First of all the error in the drush command is there in the readme file. If following the readme file , regarding creation of a sub-theme using drush command then it will throw an error in the terminal.
Hence , after applying the MR , the error in the readme file gets fixed and the command is also updated. Attaching screenshots for reference.

Thanks and regards.

Hey all ,
I have applied the patch in #2 and following are my observations :

1. First of all , the entire styling for the user login form gets removed. I have used olievero and a random contrib theme and in both the theme's , the user login form styling gets removed after installing the module.

2. The patch provided here , applies without getting any errors. After applying the patch , the title "Log in" just appears without any matching alignment or any styling.

Attaching screenshots as reference for all the above points.

Thanks and regards.

Hi all,
I reviewed the MR at #9 and applied it as a patch and it is being applied without any errors and after applying the MR the search box is designed. Overall the MR solves the issue and attaching screenshots for my findings below.

Hey @jannakha,
Tried to reapply the patch but still it failed. Using curl for applying the patch.

thanks and regards.

hey @mherchel,

Yeah, this is an accessibility requirement (WCAG 2.4.7 Focus Visible), which states as long as a control as focus, it must remain visible. I wonder if we should shift focus to something else.

If we ignore this as of now , rest is good and ready to move forward.
RTBC+

Thanks and regards.

I have tested the Merge Request !8932 and after testing following are my observations.

• I have applied the MR as a patch and it applied with no errors and applied successfully.

• After applying the patch, it adds the "back to top" button at the bottom right of the screen for both the browsers , firefox and chrome.

• For chrome, while scrolling the screen around the button a progress bar was shown and it is also interactive while scrolling the page but this feature is not available for firefox.

• One thing I would like to point out which is that, after clicking the button for scrolling back to top and when the page is at the top the button does not disappear at its own, we have to again click back on the screen and then it disappears.

• Another thing, I am not sure whether to count it as an issue or an suggestion, the button is appearing after a certain amount of scrolling which is according to me could be reduced by a small margin.

• Overall the button is working smoothly. Attaching some screen recordings for reference.

  Thanks and regards.

I have tested the Merge Request in #3 and tried to applied it as a patch but it throwed some errors. Following that, pulled the branch and then tested it and it is working as good and it solves the issue. Attaching screenshots for reference.
Thanks and regards,

Sorry, changing the status to Needs Work.

I have reviewed the Merge Request !21 and following are my observations:

• I have tried to apply this MR as a patch but it failed

• Applied the MR with some other way , it solves the issue where the navigation bar if being placed in some other regions except for primary menu it did not seem to get rendered

• Now after applying the patch , the issue is resolved. Now it works in all regions and the styling also gets improved. One thing to be noted is , for the region named breadcrumb and secondary menu , if placed in it then the navigation menu is not rendered

Attaching screenshots for reference.

Thanks and regards.

Tested the Merge Request !5 and it is working as expected and styles the contact form. Attaching screenshot for reference.
RTBC+

Thanks and Regards.

Hey everyone,
I have reviewed the Merge Request !444 and here are my findings:

I have observed that the overlapping issue of the scroll wrapper and the hidden 'show all columns' button seems to persists for screensizes below 1319px and not only for below 959px. So after applying the patch , the overlapping issue and hiding of the button only seems to be fixed for screensizes below 959px and not for others.

Another thing, I noticed that after applying this patch , the sticky scroll bar was not working for devices having screensize below 959px.

Attaching screen recording for references. Thanks and regards.

Hello everyone ,
I have reviewed the Merge Request !5 and it applied smoothly without any errors. It fixed the width of the form as it was too narrow. Attaching screenshots below for reference.

sure @larowlan I will work on the js files.
assigning it back to me.

thanks and regards.

Hey @Agamich , I have reviewed the MR 215 and according to the issue summary after removing the old packages and re-modifying the gulp file it is working fine and all the functions are running and errors are thrown if there. Attaching screenshots for reference below.

Thanks and regards.

Hey all , I have reviewed the MR by manish and it removes the excess padding above the footer.
Atttaching the screen recordings for better understanding.

Thanks and reagrds.

Hi, I reviewed the MR by manish and this solves the issue as per expectation. Attaching the screen recordings below for better understanding.

@hey sourabh , can you please use the specific color code here instead of mentioning the color variables of gin because again we have to search for that color code in the gin theme. Just create some color variables along with that color code of gin in the file named calendar-view.example.css instead of creating in this file calendar-view.default.css.

hey @tirupati , added the css file as per your recommendation , please check

thanks and regards

made changes please check

Hey @JurriaanRoelofs , hence nothing here is to solve so you can close this issue.

Thanks and regards.

Hey @jannakha. Can you merge the code and grant me credit

Hritick → created an issue.

Hritick → created an issue.

Hey @alex , I have tested the theme on the version here specified which is 5.2.1 on drupal 10.1 and browser here is google chrome. I have not faced any such sort of issues and the hamburger menu works just good and it is accessible for screen sizes below 1200px. Attaching a video here for reference.

"Hey @SeASerNet, I believe I identified this issue before the release of version 1.0.8. Could you please grant me credit for identifying and testing it on version 1.0.8?"

Thanks and regards.

hey @SeaASerNet , placed the block and it is working good. hence moving it to RTBC and you can mark this issue as fixed. Attaching a screenshot for reference.

Thanks and regards.

the changes in the merge request works as per expectation.
RTBC+1

Thanks and regards.

attaching this video for reference. As per I have noticed from the code this thing is hardcoded so the actual work of a search bar cannot be replicated here. So SeASerNet , kindly share some information regarding it

Hey @SeASerNet , I have installed the 1.0.8 version and the submenu are working fine. Attaching a video for reference below.

I am assigning this to myself and I will be looking into this issue.

Thanks and regards.

Hey @ravikant , the merge request is working as per expectations and attaching a screenshot below for reference. Hence moving it to RTBC.

Thanks and Regards.

Hritick → created an issue.

hey @starglide , kindly post issues in English so that everyone can understand and make there point.

thanks and regards.

Hey @jannakha, I have removed the jquery dependency and updated the jquery code. please take a look into the MR link provided below.
https://git.drupalcode.org/project/bootstrap5/-/merge_requests/67

Thanks and regards

Removed the jquery dependency. working on rewriting the existing js codes into vanilla js

Hritick → made their first commit to this issue’s fork.

Hey @ravi kant , added the readme.md file according to drupal readme standards and provided the MR below for review.
https://git.drupalcode.org/project/kite/-/merge_requests/54

Thanks and regards.

Hritick → made their first commit to this issue’s fork.

Hi @Kim.pepper , I have removed the jquery dependency and provided the MR link for the task.
https://git.drupalcode.org/project/svg_icon/-/merge_requests/3

Thanks and regards.

Hritick → made their first commit to this issue’s fork.

I have fixed the issue as per the requirement. please review https://git.drupalcode.org/project/business_bee/-/merge_requests/2

here the footer is being repeated twice and the issue which is being pointed out here is for the extra footer shown at the region of the main content and the footer which is at its right position is looking fine and works correctly. so, if the maintainer suggests to keep both the footer then this issue can be carried forward and more work can be done. I am attaching a screenshot as reference.

STEPS TO REPRODUCE:

• create a menu
• place it in the Footer region and you will observe that same footer is repeated.

the MR request !3 is working fine for the navigation and now for all the child menu links it is coming below the parent links

the changes done are working fine and following is the screenshot for the reference. Hence it can be merged

I have installed the theme and following are some of the screenshots for the very basic view of your theme. I will test it further and show the testcases. So far it is working fine

I cant seem to apply your patch and I am using drupal 9.5.11. While applying the patch it fails.

It depends on how you are adding the image. I am assuming that you are adding the image via ck editor and also with some text. So one solution is you can add some inline styling and add display block on the img tag and now image and text will be separated. Another option is you can attach a library for the page and write some css by targeting the class and you will achieve your desired results.
I hope this solves your query. If you want to know something else then please share

I have fixed the issue and attached a screenshot as reference

Hritick → made their first commit to this issue’s fork.

I have trying to recreate the issue. so can you please specify in details

Hello Taral Oza,

I have recreated this issue after following your steps and would like to conclude some of my observations after testing it thoroughly on my local site.

One thing which I have noticed is that the pagination gets included only when I have listed more than 100 terms and anything less than that results in no pagination. Following are the screenshots for the above :

Additionally I have tested it for admin/content , there is pagination available for adminal theme and the issue which you have mentioned exists for all themes for the taxonomy page. I have tested it on claro which is drupal 10 default admin theme and also tested for Olivero and bootstrap. Following is the screenshot for the above : Following is the screenshot for above :

So, I will work on it and try to create a patch for it.

Thank You for your valuable time.

Hello,
After following your steps to reproduce the issue, I did not faced any issue or any such sort. Everything looked fine even the buttons and everything. I have attached the required screenshot.

Worked on this issue and solved it according to the changes requested and done it by changing the SCSS files and compiled it using gulp

Hritick → made their first commit to this issue’s fork.

WORKED ON THE ISSUE WHICH WAS IF ANY TAGS OR LINKS IS A BIT LONG THEN AN HORIZONTAL SCROLL BAR IS VISIBLE I HAVE CORRECTED IT AND NOW THE TEXT WILL BE ADJUSTED AND NO HORIZONTAL SCROLL BAR WILL VISIBLE

Hritick → made their first commit to this issue’s fork.

I have fixed the alignment issue and worked on the scss files

Hritick → made their first commit to this issue’s fork.