- Issue created by @Ashutosh Ahirwal
- Assigned to Hritick
- Status changed to Active
7 months ago 5:40am 29 April 2024 - Merge request !23439552-menu-fixes: fixed the design issue for level 2 menus → (Open) created by Hritick
- 🇮🇳India Hritick
I have fixed the issue as per the requirement. please review https://git.drupalcode.org/project/business_bee/-/merge_requests/2
- Status changed to Needs review
7 months ago 9:39am 29 April 2024 - Issue was unassigned.
- Status changed to Needs work
7 months ago 10:36am 29 April 2024 - 🇮🇳India Ashutosh Ahirwal India
I have reviewed the MR and tried to apply it but it get failed.
Moving to need work - First commit to issue fork.
- Status changed to Needs review
7 months ago 7:18am 30 April 2024 - 🇮🇳India adarshv
I have fixed the issue as per the requirement. please check MR !3 above.
Hi, reviewd the MR 3, applied cleanly and opens the level 2 menu in the left side for last 2 menus, but last menu level 1 moves out of the screen creating a horizontal scroll.
- Status changed to Needs work
7 months ago 10:51am 3 May 2024 - 🇮🇳India Ashutosh Ahirwal India
Hi adarshv Thanks for again working on this issue.
Your changes are reflecting fine can you please shift it bit more and we not need scroll on pageThanks
- Status changed to Needs review
7 months ago 11:54am 7 May 2024 - 🇮🇳India pray_12
The issue mentioned in comment #11 has been fixed in the latest MR. The menu looks fine now.
Thank you! - Status changed to Needs work
6 months ago 5:24pm 21 June 2024 - 🇮🇳India Tirupati_Singh
Hi, I've applied both
MR!2
andMR!3
as patch and both the MRs applied with no errors.After compiling the
style.scss
file in theMR!2
provided by @Hritick resolves the issue of Level 2 and Last Menu design issue and the changes look good to me. But I think, it would have been better if the compiledstyle.css
file had also been pushed along with thestyle.scss
file.On applying the
MR!3
provided by @adarshv, as patch, the Level 2 and the last menu design issue has been resolved and the changes look good. But the pushedstyle.css
file is not as per thestyle.scss
file. As per thestyle.css
file the Level 2 and Last menu design issue get fixed but after compiling thestyle.scss
file the Level 2 and Last menu design persists. I've attached screenshots of before and after compiling style.scss file for reference.Both the MRs resolve the issue but
MR!2
has the better solution as compared toMR!3
because MR!2 is using theopacity and visibility CSS property
for rendering Menu level which will be better for user design experience. On the other hand, MR!3 usesdisplay: block and :none CSS property
to show and hide Menu items on hover.Attaching all the screenshots for reference and moving to issue status to Need Works.
- 🇮🇳India Hritick
hey @tirupati , added the css file as per your recommendation , please check
thanks and regards
- Status changed to RTBC
5 months ago 6:35am 5 July 2024 - 🇮🇳India Tirupati_Singh
Hi @Hritick, I've applied the MR!2 and reviewed the changes, the nested level menu issue has been fixed and is working fine. I'm attaching before and after screenshots for reference. Since the MR!2 resolves the issue and is working fine MR!3 can be closed as there's no changes made as per the feedback added. Hence moving the issue status to Reviewed & tested.