Need fixes for level 2 menus for last menus

Created on 9 April 2024, 8 months ago
Updated 5 July 2024, 5 months ago

Problem/Motivation

Last menu is breaking for level 2

Steps to reproduce

Install the theme and add some menus and check on home page.

🐛 Bug report
Status

RTBC

Version

1.0

Component

User interface

Created by

🇮🇳India Ashutosh Ahirwal India

Live updates comments and jobs are added and updated live.
  • CSS

    It involves the content or handling of Cascading Style Sheets.

  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Ashutosh Ahirwal
  • Assigned to Hritick
  • Status changed to Active 7 months ago
  • 🇮🇳India Hritick

    I have fixed the issue as per the requirement. please review https://git.drupalcode.org/project/business_bee/-/merge_requests/2

  • Status changed to Needs review 7 months ago
  • Issue was unassigned.
  • Status changed to Needs work 7 months ago
  • 🇮🇳India Ashutosh Ahirwal India

    I have reviewed the MR and tried to apply it but it get failed.
    Moving to need work

  • First commit to issue fork.
  • Merge request !3fixed issue → (Open) created by adarshv
  • Status changed to Needs review 7 months ago
  • 🇮🇳India adarshv

    I have fixed the issue as per the requirement. please check MR !3 above.

  • Hi, reviewd the MR 3, applied cleanly and opens the level 2 menu in the left side for last 2 menus, but last menu level 1 moves out of the screen creating a horizontal scroll.

  • Status changed to Needs work 7 months ago
  • 🇮🇳India Ashutosh Ahirwal India

    Hi adarshv Thanks for again working on this issue.
    Your changes are reflecting fine can you please shift it bit more and we not need scroll on page

    Thanks

  • Status changed to Needs review 7 months ago
  • 🇮🇳India pray_12

    The issue mentioned in comment #11 has been fixed in the latest MR. The menu looks fine now.
    Thank you!

  • Status changed to Needs work 6 months ago
  • 🇮🇳India Tirupati_Singh

    Hi, I've applied both MR!2 and MR!3 as patch and both the MRs applied with no errors.

    After compiling the style.scss file in the MR!2 provided by @Hritick resolves the issue of Level 2 and Last Menu design issue and the changes look good to me. But I think, it would have been better if the compiled style.css file had also been pushed along with the style.scss file.

    On applying the MR!3 provided by @adarshv, as patch, the Level 2 and the last menu design issue has been resolved and the changes look good. But the pushed style.css file is not as per the style.scss file. As per the style.css file the Level 2 and Last menu design issue get fixed but after compiling the style.scss file the Level 2 and Last menu design persists. I've attached screenshots of before and after compiling style.scss file for reference.

    Both the MRs resolve the issue but MR!2 has the better solution as compared to MR!3 because MR!2 is using the opacity and visibility CSS property for rendering Menu level which will be better for user design experience. On the other hand, MR!3 uses display: block and :none CSS property to show and hide Menu items on hover.

    Attaching all the screenshots for reference and moving to issue status to Need Works.

  • 🇮🇳India Hritick

    hey @tirupati , added the css file as per your recommendation , please check

    thanks and regards

  • Status changed to RTBC 5 months ago
  • 🇮🇳India Tirupati_Singh

    Hi @Hritick, I've applied the MR!2 and reviewed the changes, the nested level menu issue has been fixed and is working fine. I'm attaching before and after screenshots for reference. Since the MR!2 resolves the issue and is working fine MR!3 can be closed as there's no changes made as per the feedback added. Hence moving the issue status to Reviewed & tested.

Production build 0.71.5 2024