- Issue created by @sjhuskey
- First commit to issue fork.
- Status changed to Needs review
about 2 months ago 12:31am 23 July 2024 - 🇺🇸United States erutan
Tested this and the behaviour in the report is correct.
Made a quick update here https://git.drupalcode.org/issue/bootstrap5-3458182/-/compare/4.0.x...34...
- Status changed to Needs work
about 2 months ago 4:34am 24 July 2024 - 🇦🇺Australia jannakha Brisbane!
@erutan
thank you for your contribution!can you please create merge request on a branch to proceed with review (see creating MR → ) it'll speed up review, run CI, etc.
- 🇮🇳India atul ghate
atul_ghate → made their first commit to this issue’s fork.
- Merge request !68Issue #3226193 by VladimirAus: Default content generation: social media menu... → (Open) created by Unnamed author
- Status changed to Needs review
about 2 months ago 10:23am 24 July 2024 - Merge request !69#3458182 update readme file re: drush subtheme command → (Open) created by jannakha
- 🇦🇺Australia jannakha Brisbane!
jannakha → changed the visibility of the branch 3458182-updated-drush-command to hidden.
- 🇦🇺Australia jannakha Brisbane!
@atul_ghate
- please do not create new branches, work on existing branches (click "get push access" to do so)
- all NEW branches should have a unique name
- all MRs should be against latest DEV version (eg, 4.0.x-dev) NOT specific tag
- before updating status of the issue to "Needs review" - review your MR to makes sure only YOUR changes are included and MR is MERGEABLE and green - 🇮🇳India atul ghate
Hi @Jannakha, thank you for the feedback. Initially, I attempted to gain push access with the 'git push' command. However, when I used 'git checkout -b '3458182-incorrect-drush-command' --track bootstrap5-3458182/'3458182-incorrect-drush-command'', the branch already contained the latest code. Consequently, I created a new branch. I'll remember this for next time and avoid creating unnecessary new branches.
- Status changed to Needs work
about 1 month ago 4:54am 25 July 2024 - 🇦🇺Australia jannakha Brisbane!
review:
- update command usage in
https://git.drupalcode.org/issue/bootstrap5-3458182/-/blob/3458182-incor...
and
https://git.drupalcode.org/issue/bootstrap5-3458182/-/blob/3458182-incor... to use a proper command name- test commands in usage are in correct format
- Status changed to Needs review
about 1 month ago 9:20am 25 July 2024 - 🇮🇳India Hritick
Hey @janakkha ,
I have reviewed the MR in #6. First of all the error in the drush command is there in the readme file. If following the readme file , regarding creation of a sub-theme using drush command then it will throw an error in the terminal.
Hence , after applying the MR , the error in the readme file gets fixed and the command is also updated. Attaching screenshots for reference.Thanks and regards.
- Status changed to RTBC
9 days ago 12:22pm 30 August 2024