- Issue created by @Neha Wadhwani
- Issue was unassigned.
- Status changed to Needs review
8 months ago 7:39am 28 March 2024 - 🇮🇳India Hritick
I cant seem to apply your patch and I am using drupal 9.5.11. While applying the patch it fails.
- Status changed to Needs work
8 months ago 10:28am 9 April 2024 - 🇮🇳India Ashutosh Ahirwal India
Instant of adding display none to each field label, set the label hidden from manage display form for content type.
- Assigned to sourojeetpaul
Hello, @Neha Wadhwani, I cannot find any style breaking issue on the content view page, I think what you meant here is the field labels coming in the full view mode which can be easily mitigated as correctly suggested by @Ashutosh from the manage display setting. But while trying to reproduce this issue I've observed rather another issue which caught my attention, is that the tabs are aligned vertically which is a bit weird, I think it'll be better if its aligned horizontally, and should only appear vertically through a hamburger menu menu on smaller screens. So I'm fixing that within this issue itself!
Attaching a screenshot for reference!
- Issue was unassigned.
- Status changed to Needs review
7 months ago 11:55am 16 April 2024 I've resolved the issue that I mentioned on the previous comment, also observed that its a common behaviour for the primary tabs local task that's why it was affecting all the tabs, including the login page tabs. So in my commit I've addressed it globally which mitigates the issue. Please have a look:
https://git.drupalcode.org/project/business/-/merge_requests/17
Attaching screenshots for reference!- Status changed to RTBC
6 months ago 5:05am 29 May 2024 Hi,
I came across the same design issue with the tabs with this theme and I have applied the MR!17 which resolves the design issue.
I have attached the before and after ss.
Moving to RTBC.-
Gauravvvv →
committed e91b321b on 9.1.x authored by
sourojeetpaul →
Issue #3436639: Fix tabs style break issue.
-
Gauravvvv →
committed e91b321b on 9.1.x authored by
sourojeetpaul →
-
Gauravvvv →
committed 01f3a5dc on 10.0.x
Issue #3436639: Fix tabs style break issue
-
Gauravvvv →
committed 01f3a5dc on 10.0.x
- Status changed to Fixed
5 months ago 4:22am 12 June 2024 - 🇮🇳India gauravvvv Delhi, India
Thank you for working on the issue, committed to 9.1.x and 10.0.x
Hello @Gauravvvv,
As per granting credits, the contributor reviewing a patch and moving the issue foward to fixing the issue can be granted credit.
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquette/granting-credit-to-issue-contributors →
In this regard I haven't been granted credit. It would be great if you grant credit to me.
Thank you- 🇮🇳India gauravvvv Delhi, India
As per granting credits, the contributor reviewing a patch and moving the issue foward to fixing the issue can be granted credit.
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... →
In this regard I haven't been granted credit. It would be great if you grant credit to me.
Thank youHello @esha_kundu, Thank you for contributing to the issue. I noticed that you have not added any screenshots or provided the steps to test it. Additionally, the "before" and "after" patch images you included are giving a 404 error and are not being displayed. Credits are granted for valuable contributions that help move the issue forward.
Automatically closed - issue fixed for 2 weeks with no activity.