- Issue created by @shweta__sharma
- Status changed to Needs review
about 1 year ago 12:50pm 10 October 2023 - Assigned to Jitender vaidh
- 🇮🇳India Jitender vaidh New Delhi
I have fixed this issue and created and uploaded a patch.
- 🇮🇳India Kanchan Bhogade
Hi
Tested Patch 3392882-2 on Drupal 10.2 for the footer menu has no space from the left side.
The patch was applied successfully...Result:
with patch space added on the left side for the footer menuAttaching screenshot for reference
Keeping in "needs review" for code verification and more test reviews
- Issue was unassigned.
- 🇮🇳India Hritick
here the footer is being repeated twice and the issue which is being pointed out here is for the extra footer shown at the region of the main content and the footer which is at its right position is looking fine and works correctly. so, if the maintainer suggests to keep both the footer then this issue can be carried forward and more work can be done. I am attaching a screenshot as reference.
STEPS TO REPRODUCE:
- create a menu
- place it in the Footer region and you will observe that same footer is repeated.
- Status changed to RTBC
7 months ago 10:53am 7 June 2024 Hello @Hritick,
I went through the theme and followed the steps as you've mentioned on your previous comment. I see there's a legit issue with it because the region is getting rendered twice from page.html.twig. Though I feel that can be addressed on a separate issue. It'll be good to stay in the scope of the issue's motivation.
I've applied the patch provided over here and can confirm that after applying it, the left side spacing issue is getting resolved, also previously there was a horizontal scrollbar coming, after applying the patch that issue has also been resolved.Also I've checked this issue persist on the latest version of the theme as well, so I'm changing the metadata accordingly!
For the footer getting rendered twice please feel free to create a sub issue of this, we can have the discussion over there pertaining to that problem.As the said issue is resolved, hence I'm moving it to RTBC++, attaching before and after screenshots for reference!