- Issue created by @jphelan
- 🇬🇧United Kingdom niklp Nottingham
Seeing something similar manifest in webform dialogs also.
- 🇮🇳India vasantha deepika Coimbatore
Could you please provide the steps to reproduce it? This will help us understand the context.
- 🇺🇸United States jphelan
- Install layout_builder_iframe_modal
- Enabled layout builder on a content type
- Create a node and the edit the layout
- add a section and then add a block
- Select "Create content block"
- Select the basic content block and it should open in a modal
- You should notice that the close button, while present, is not visible
- 🇮🇳India vasantha deepika Coimbatore
Hi @jphelan, I couldn't reproduce the issue on my end, i tried with the versions mentioned below
Gin theme version: 4.0.6
Layout Builder iFrame Modal version: 1.3.6Could you please let me know which version of the Layout Builder iFrame Modal you're using?
- 🇺🇸United States jphelan
Drupal Version - 11.1.5
Gin 4.0.6
layout_builder_iframe_modal 1.3.6Attached my gin theme settings.
Odd, you don't see the
core/themes/claro/css/components/dialog.css
styles loading and overriding the gin styles?
themes/contrib/gin/dist/css/components/dialog.css - 🇮🇳India sandip
Yes @jphelan, this issue is reproducable and the css is coming from claro which is overriding gin styles. i am attaching SS for reference.
I am working on it. - Merge request !610Issue #3512296: Claro theme overriding the position of the close button on dialogs. → (Open) created by Unnamed author
- 🇮🇳India sandip
Hi @jphelan,
I have resolved the issue. The root cause was related to CSS specificity — Claro's CSS was more specific than Gin's. I adjusted Gin’s dialog CSS to match the specificity of Claro's, and that resolved the overriding problem. No changes to Gin's code were necessary beyond that.
Please let me know if you need any further changes.
Thank you!
- Status changed to Needs review
6 days ago 10:54am 13 May 2025 - 🇮🇳India snehal-chibde
hello , I have tested this issue on Drupal Version 11.1.6, and it appears that the issue is not replicated in this version. It seems the problem has been resolved in the latest version. I would recommend upgrading to 11.1.6 for anyone experiencing this issue.
Added screenshot for reference. - 🇮🇳India sandip
Hi @snehal-chibde you are supposed to test this issue in Gin. The image you have provided it seems claro theme.
- 🇮🇳India snehal-chibde
hello @sandip I have checked this on Gin theme and its not replicated.
Added screenshot for reference.