- Issue created by @vasantha deepika
- Merge request !4Issue #3507482: Page not visible in full width. → (Closed) created by vasantha deepika
- 🇮🇳India vasantha deepika Coimbatore
The issue has been resolved, and I have raised a merge request. Please review and provide feedback as needed.
Thanks! - 🇮🇳India vasantha deepika Coimbatore
Apologies for the earlier approach. Since Olivero is a core theme in Drupal 11, I have updated the relevant tags accordingly and will be raising a Merge Request (MR) against Drupal core.
- Merge request !11251Issue: #3507482 - Page not visible fullwidth. → (Open) created by vasantha deepika
- 🇺🇸United States smustgrave
Issue summary appears incomplete, would recommend adding back the missing sections.
There are also multiple MRs when there should be 1 pointed to 11.x
Also not sure maintainers would want to move away from variables to hardcoded values
- 🇮🇳India vasantha deepika Coimbatore
vasantha deepika → changed the visibility of the branch 3507482-page-not-visible-fullwidth to hidden.
- 🇮🇳India rinku jacob 13 Kerala
Hi smustgrave, The issue doesn't appear or isn't visible when the screen width is 100%. However, if the screen width is reduced to less than 90%, the issue will appear on the screen, so should I update the issue summary based on this?
- 🇮🇳India sandip
Removing the
max-width
property from the.page-wrapper
class effectively resolves the issue. This adjustment eliminates the need for unnecessary max-width: 100% or any other values of max-width in the .page-wrapper class, ensuring the page will display full width. - 🇺🇸United States smustgrave
User interface changes section is usually meant for before/after screenshots.
- 🇮🇳India rinku jacob 13 Kerala
I have applied the merge request, and the issue has been resolved. Here are the before and after screenshots for reference.
Before the changes (MR) were applied
After the changes(MR) were applied
- 🇮🇳India rinku jacob 13 Kerala
I have applied the merge request, and the issue has been resolved. Here are the before and after screenshots for reference.
Before the changes (MR) were applied
After the changes(MR) were applied
- 🇮🇳India vasantha deepika Coimbatore
There are some deviations in the MR. I will review them and update the MR accordingly.
- 🇮🇳India rinku jacob 13 Kerala
I applied the MR for Drupal 11.x-dev, and the issue was fixed after its implementation. I've attached the before and after screenshots for reference.
Before applying the style:After applying the style:
- 🇮🇳India sandip
I think the MR is fine as the test failures are not related to this.
@rinku jacob 13, I think you deleted the before and after Screenshots by mistake. Can you Please Upload it again. So we can movie this issue to NR. - 🇮🇳India rinku jacob 13 Kerala
@sandip poddar, I have already added the before and after screenshots, but I have no idea how the latest comment was generated.
- First commit to issue fork.
- 🇧🇷Brazil brandonlira
I’ve rebased this issue branch with the latest changes from 11.x (via merge), resolved all merge conflicts, and ensured the code is up to date. All automated tests are passing successfully.
The issue is now ready for review.
Thanks!
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Olivero was specifically designed like this, see 📌 Olivero: Center align content (instead of left align) Needs work for people who want to have a centered layout. But the drops background + left alignment is a feature, not a bug.