Account created on 30 October 2015, over 9 years ago
  • Sr Software Application Engineer at ICFΒ 
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States leraa

Comment #8 helped me, thanks @sebasgd!

I only needed to change the id to id: 'entity_bundle:node', I did not need to change the node_type header.

πŸ‡ΊπŸ‡ΈUnited States leraa

I tested this patch and the module is working as expected. See in this screenshot of a view, the natural sort is working on Drupal 9.5.10:

πŸ‡ΊπŸ‡ΈUnited States leraa

I had to fork this module to update it for D10,

In my custom version, I simply changed the jQuery UI Accordion dependency to ^2.0 and updated the info.yml file to allow D10.

The module works as expected. I can create and view and use accordions in their Paragraphs widget as expected. I recommend this patch be merged.

πŸ‡ΊπŸ‡ΈUnited States leraa

I also tested and it worked as expected with no errors.

πŸ‡ΊπŸ‡ΈUnited States leraa

This patch confirmed working as expected.

Manual test steps:

  • aria-required="true" is set on the fieldset
  • role="radiogroup" is set on the fieldset
  • aria-required="true" is NOT on the individual radio buttons
  • required="required" is on the individual radio buttons

.
Needs accessibility review.

πŸ‡ΊπŸ‡ΈUnited States leraa

I tested this patch and found correct:

aria-required="true" is set on the fieldset
role="radiogroup" is set on the fieldset

However, I still saw aria-required="true" on the individual radio buttons.

πŸ‡ΊπŸ‡ΈUnited States leraa

For #33: ARIA radiogroup and radio example

Backs up the role="radiogroup" for fieldset and also adds aria-labelledby

Production build 0.71.5 2024