- Issue created by @JayDarnell
I am having a very similar problem with Drupal 9.5.2, Group 3.0.1....
- First commit to issue fork.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7last update
almost 2 years ago Not currently mergeable. - last update
almost 2 years ago 1 pass - 🇺🇸United States msielski
Looking into this I saw that
config_views/src/Plugin/views/query/ConfigEntityQuery::build
does not contain a few lines of code whichviews/src/Plugin/views/query/Sql::build
contains. This missing code sets$view->build_info['query']
which is what is not set whengroup_views_query_alter
runs. With the change in the linked MR, the reported issue seems to be fixed and can no longer be reproduced. - last update
almost 2 years ago 2 fail - Status changed to Needs review
almost 2 years ago 1:40pm 1 June 2023 - 🇩🇪Germany anruether Bonn
Thank you for the MR, @msielski! It works for me,
/admin/structure/types
is available again. - Status changed to RTBC
11 months ago 11:39pm 15 April 2024 - 🇺🇸United States mortona2k Seattle
I'm using this with content_model_documentation and group, and this fixes the error on admin pages for me.
It's a small change, explained well by the developer's comments above.
- 🇺🇸United States ultimike Florida, USA
This MR worked for me as well with Drupal core 10.3.9, Group module 3.3.0, and version 2.1.1 of this module.
-mike
- 🇬🇧United Kingdom scott_euser
If I understand this right, the issue comes when pagination is involved? Is that correct? Ie, not necessarily specific to Group module. Just want to consider how we can add test coverage for this.
- 🇬🇧United Kingdom scott_euser
Also looks like 🐛 Error: group_views_query_alter() Call to a member function addMetaData() Needs work takes a different approach to the same problem?
- 🇺🇸United States maxstarkenburg Washington, DC
scott_euser → credited maxstarkenburg → .
- 🇬🇧United Kingdom scott_euser
Moving back to needs review for advice on #11 so I can understand how to add test coverage.
- 🇬🇧United Kingdom scott_euser
Okay reproduced, added test coverage that fails without this (essentially mimicking what Group does)
Thanks all! -
scott_euser →
committed f211e264 on 2.1.x authored by
msielski →
Issue #3358929 by scott_euser, msielski, timotej-pl, shin.cho,...
-
scott_euser →
committed f211e264 on 2.1.x authored by
msielski →
Automatically closed - issue fixed for 2 weeks with no activity.