Contrib.social

Group Subscription should ignore missing or unpublished entities

Open on Drupal.org →
Created on 1 November 2023, about 1 year ago
Updated 16 January 2024, 10 months ago

Problem/Motivation

Originally this issue was a very small one. I noticed that unpublishing a group didn't remove the group from the group subscription configuration page for users. Then I noticed that unpublishing a group didn't stop subscriptions from being processed for that group's content if the content was still published. In a perfect world, unpublishing a group would also unpublish all group content but we can't assume anything and need to check these scenarios when processing subs.

If any of the following criteria are true skip processing the item.

  • The group cannot be found
  • The group is unpublished
  • The group content cannot be found
  • The group content is unpublished
  • If any of the above parent items are true for a given comment
  • The comment cannot be found
  • The comment is unpublished

Acceptance Criteria

  • Subscription settings for unpublished groups should no longer be visible on user subscriptions pages
  • New published content added to an unpublished group should not generate subscriptions
  • The cron_subscription_builder queue worker should skip items where any of the above criteria are true
  • Immediate and daily subscription queue workers should skip items where any of the above criteria are true
🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇨🇦Canada JayDarnell Guelph, Ontario

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024