Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 22 August 2022, over 2 years ago
Updated 1 June 2023, almost 2 years ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 years ago →
    heddn Nicaragua

    The 3.x version of the module supports Drupal 10. I plan to leave this open for a while if someone wants to test confirm that the module works w/ 10.x, but there is low likelihood we will support Drupal 10 for the 1.x branch.

  • Comment almost 2 years ago →
    🇺🇸United States daletrexel Minnesota, USA

    What are the plans to formally release the 3.x branch from dev? Hopefully well before the D9 EoL in November!

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
    last update almost 2 years ago
    2 fail
  • Comment almost 2 years ago →
    🇺🇸United States zipymonkey Durham, NH

    There are couple of references to the GroupContent in the 3.0.x branch. The attached patch removed the references or replaces them with GroupRelationship.

  • Comment almost 2 years ago →
    System Message

    The last submitted patch, 8: group_content_menu-d10-3305288-8.patch, failed testing. View results →
    - codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • Status changed to Closed: won't fix almost 2 years ago
  • Comment almost 2 years ago →
    heddn Nicaragua

    I won't be making the 1.x branch Drupal 10 compatible. Group v1 doesn't support Drupal 10 either. I could change my mind if someone tests this, but that hasn't happened yet.

  • Comment almost 2 years ago →
    🇺🇸United States zipymonkey Durham, NH

    @heddn The patch for https://www.drupal.org/project/group_content_menu/issues/3305288#comment... 📌 Automated Drupal 10 compatibility fixes Closed: won't fix is for 3.0.x. That removes a few references to GroupContent that are still in the module. I will create a separate ticket.

  • Comment almost 2 years ago →
    🇺🇸United States daletrexel Minnesota, USA

    I'm confused about two things:

    1. Group 8.x-1.5 has been D10 compatible since August 2022 → . That seems in conflict with comment #10.

    2. What versions of Group Content Menu work with which versions of Group? I don't see any information on the project page or in the project's readme file about compatibility and how to choose versions. Can you use Group Content Menu 2.x or 3.x with Group 1.x?

    For context:

    The University of Minnesota manages Drupal in a giant multisite format, and that base setup is on Group 8.x-1.5. Their plan is to stay on the 1.x branch until AFTER upgrading to D10, since Group 1.x is D10 compatible. I have no control over Group. However, I do have control over Group Content Menu, which we manage in our site repository. We're currently on the 1.x branch of Group Content Menu. I need to find a way to survive the pending D10 upgrade this summer. That means either patching Group Content Menu 1.x to be D10 compatible or upgrading to Group Content Menu 2.x or 3.x. Is the latter option even possible with Group 1.x?

  • Comment almost 2 years ago →
    heddn Nicaragua

    While group v1 was marked to support Drupal 10, it doesn't in actuality. The release notes for v2 and v3 of this module gives some clarity that they support group v2 and v3. I will update the project page to make that more obvious.

    What we are doing on several of our sites is updating to Group v2 from v1 (there isn't a direct upgrade path to v3 from v1). And doing this on Drupal 9.5. After that upgrade is stable, we then upgrade to Drupal 10. All this because there isn't a version of Group that supports Drupal 10.

  • Comment almost 2 years ago →
    🇺🇸United States daletrexel Minnesota, USA

    Thanks for the clarification, @heddn!

    I don't know if the note in the Group 8.x-1.5 release has been recently added or if it was always there and I overlooked it because I saw "Works with Drupal: ^9.3 || ^10" at the top, which answered my immediately question about D10 compatibility, and it didn't occur to me to read on in case the release notes were allowed to outright lie. But I do see that message now.

    For Group Content Menu module, it would definitely be helpful to add clarification to the project page, because the wording in the releases for 2.x and 3.x are terse enough to lead to ambiguity: does "support for" a version mean "only" that version, or does that particular release "add" support for that version (with the implication that it includes backwards compatibility with previous versions)?

  • Comment almost 2 years ago →
    heddn Nicaragua

    That was me who added it :blush:

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024