In Views, the "Is Locked" field does not get updated after a lock break

Here is a patch

I reproduced this issue on my local and added MR or checked it, but when I add a node, only when I edit the node from admin, the lock status changes, but when I edit the node from another user. the locked status of the node does not change and is also not shown to other users.

Tried replicating following the steps in the issue summary and the view is updating fine for me with the latest 8.x-2.x changes.

Still not able to replicate but now that we have a views test file I expanded on that to verify this.

Hiding patches.

smustgrave → changed the visibility of the branch 3381841-in-views-the to hidden.

Fixing issue title.

I followed the steps as defined in the issue summary and this is definitely still an issue. Which is good because nothing has been committed recently that would fix this.

The reason the tests pass is that view provided by the module has cache set to none - while the views.view.content has the cache type of tag.

alexpott → changed the visibility of the branch 3381841-in-views-the to active.

alexpott → closed merge request !36

I've fixed the view so that it works - but I'm scared... this means views an edit screen and locking a node will impact the cache. This does not feel like the correct solution.

I think what we should do is introduce a content_lock cache tag and cause views which use it's fields to add that.

The changes to config/optional/views.view.locked_content.yml and src/ContentLock/ContentLock.php can be removed. They’re not necessary.

We also should add an upgrade path that finds views and resaves them if they use the content_lock table.

Completed the upgrade and tested it manually.
Do we expect an upgrade test too? If not this is ready for reviews.

Applied MR locally
Hook ran fine without issue
Tests appear all green

Believe this is good, based also on the slack thread I was on.

Added some comments to the MR - I think we need to add test coverage of the new code.

Adding a test and changed a few things.

Okay - we've got test coverage of the view and saving the view while trying to change the cache plugin. This is looking good. I manually tested the post update and it is was working.

Automatically closed - issue fixed for 2 weeks with no activity.