Considering the
_workbench_email_content_moderation_event_shim
function never gets called unless the Trash module is installed, the proposed solution seems valid to me.
Patch applied fine as expected.
@larowlan I tried making the Trash module have higher weight, but that didn't work. Error still thrown.
OR the remove code that is creating the duplicate tab approach
The Content Moderation checking approach, improved.
The Content Moderation checking approach.
no sssweat → created an issue.
Patch in #7 applied but didn't do what is was suppose to.
I tried placing user role weight as last and also as first and still cannot delete files.
Patch needs work.
I added a bunch more URLs and in the logs those don't show. Def some caching happening here despite trying to flush all caches and even uninstalling and reinstalling the module.
I noticed in the log it doesn't show *.google.com in the allowed list, yet I do have it in my config.
For testing purposes, I changed it to '*.google.com' and did some test, changed it back to *.google.com without the quotes and I noticed it was showing '*.google' in the logs.
Seems to me there is some sort caching problem or google.com is getting stripped for some reason.
no sssweat → created an issue.
no sssweat → made their first commit to this issue’s fork.
I have created MRs
Feel free to use its patches
2.x https://git.drupalcode.org/project/wysiwyg_linebreaks/-/merge_requests/5...
8.x https://git.drupalcode.org/project/wysiwyg_linebreaks/-/merge_requests/6...
No Sssweat → changed the visibility of the branch 3365305-ckeditor-5 to hidden.
No Sssweat → changed the visibility of the branch 3365305-ckeditor-5 to active.
No Sssweat → changed the visibility of the branch 3365305-ckeditor-5 to hidden.
No Sssweat → made their first commit to this issue’s fork.
@lymannx, no. This one is different. You can read about it here
Other known modules affected:
- webform
- leaflet
- sitewide_alert
Providing some guidance on how this library gets loaded since no one has yet.
Check if in /admin/structure/webform/config/libraries, Choices is enabled.
However, this setting alone won't cause the library to get loaded.
In order for it to load, a select element/field needs to have Choices checked in it's config.
The fix is either update the module to the latest version OR make sure Choices is unchecked in /admin/structure/webform/config/libraries
I find it hard to believe that one has report this sooner.
I think it's a side effect of this other issue,
https://www.drupal.org/project/simplesamlphp_auth/issues/3340606#comment... 💬 Document simplesamlphp 2.x directory change (www to public) Active
The second patch from #6 introduces
Warning undefined variable $switcher_horizontal_position and $switcher_vertical_position
$float_position = $settings->get('float_position');
Float position will never be an array and will always be a string since you can only select one. Therefore,
if(is_array($float_position)){
Is not necessary and it's introducing the undefined variables as it will never pass this check.
Use the first patch from comment #2 if anything.
I have not been able to reproduce the bug. Might want to add the steps to reproduce.
Commited to the Dev branch and created new 1.3.0-beta1 release.
Thanks #8 did the trick, but needed a tweak for the .module code
<?php
use Drupal\user_module\YourCustomFormAlterBuilder;
function user_module_form_FORM_ID_alter(&$form, $form_state) {
$form['#pre_render'][] = [new YourCustomFormAlterBuilder, 'preRender'];
}Re-rolled the rc1 patch so it's compatible with 9.5.11
With
$output = \Drupal::service('renderer')->render(['#markup' => $thing]);
I got a
Error: Drupal\Core\Render\Renderer::render(): Argument #1 ($elements) cannot be passed by reference incam_preprocess_page()
Had to
$render_array = [
'#markup' => $thing
];
$footer_contact = \Drupal::service('renderer')->render($render_array);1. Config needs to be inside the /config/install or config/optional folder.
2. It needs have system in the config name, system.action.node_example_action.yml
No Sssweat → created an issue.
As mentioned a newer D10 version has been released.
As mentioned in comment #6, because of the different kernel events. Different values end up being passed to the error and the warning lines.
One of these values is an empty revisions array and a node object as a revision id instead of a string or int.
This might not be the optimal solution, but I manage to get passed those by checking if it's not empty.
After upgrading from PHP 7.4 to 8.1
I am also seeing the type error and the array flip warning that comment #5 mentions with Drupal 9.5.11
TypeError: Illegal offset type in Drupal\Core\Entity\ContentEntityStorageBase->loadRevision() (line 636 of /var/www/html/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php)
Warning: array_flip(): Can only flip string and integer values, entry skipped in Drupal\Core\Entity\ContentEntityStorageBase->loadMultipleRevisions() (line 667 of /var/www/html/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php)
Going through the code in xdebug for some reason with PHP 8.1 it triggers different kernel events compared to 7.4 with the same codebase and DB.
7.4 does a kernerl.response while 8.1 does a kernel.controller event.
Also 7.4 has more service definitions while 8.1 has less (802 vs 754)
No Sssweat → made their first commit to this issue’s fork.
Here is a patch
No Sssweat → created an issue.
I am also experiencing this.
The problem is that the [current-user:display-name] token always uses the current logged in user.
To solve this issue, we can add the user ID as part of the path to the certificate pdf route. Then use the user ID in the path to get the user's name.
You will have to use the new token, [opigno_certificate:user_name]
This will involve patching multiple Opigno modules.
MR created, please review.
No Sssweat → created an issue.
Not a bug
Ooops, we were looking at this at the same time.
My appologies, I misread your objective. We are on the same page
Try installing in D8 versions < 8.8
1) You shouldn't be using D8 as its deprecated and no longer supported by the Drupal security team.
2) If anyone is still using D8, they should atleast be using the latest version 8.9.8 for security sakes.
Please be more specific, what exactly is "not working"?
There is currently no Drupal 10 branch for this module.
Why not upgrade to version 2.0.0?
I agree.
1) First, this depends this other issue getting fixed, https://www.drupal.org/project/opigno_learning_path/issues/3336036 🐛 Re-arraging the learning path Form Display fields causes, TypeError: key(): Argument #1 ($array) must be of type array, null given in key() (line 462 of modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php). Needs review
However, you can manually fix that issue by going to /admin/group/types/manage/learning_path/form-display and correcting the "Duration" field widget to "autocomplete"
2) You will have to manually add/create the checkbox (boolean) field, since you can't use the "part-2-of" patch, with the following values
3) Apply the "part-1-of" & "part-3-of" patches.
I have created 3 patches that adds this functionality.
However, the patch that starts with part-2-of-... must not be used on a live site.
This is because it contains a DB update code, and the update number needs to be agreed upon with the module's maintainer. Therefore, this can likely cause future DB updates not to run.
(If you would like to use this feature on a live site, see my next comment, #4)
These patches will create a new checkbox field in the training edit form/page.
and when that is checked, it will allow user to un-enroll for that particular training.
MR created.
MR created, please review.
No Sssweat → created an issue.
MR created, please review.
As the error alludes to, it's due to not having the entity revision key.
Adding $data['shurly']['table']['entity revision'] = FALSE; will fix the issue.
No Sssweat → created an issue.
Patch doesn't apply for 9.5.2
Why bother? It has been 16 years...
Clearly this tells me that this just a "nice to have" feature that most people are living happily without.
Also, it seems there are a lot of hoops, walls and gates to jump through to get this into core.
This should've been moved into contrib or scrapped all together a long time ago.
"follow"/"following" would work well.
Hmm... that sounds weird to me because of social media.
In my opinion, it be better to say, please "visit" or "go to".
MR created, please review.
No Sssweat → created an issue.
MR created, please review.
Turns out can't add to the conditional with making the conditional significantly more complex.
So I added a 1 liner conditional before it.
Looking at the form validate function, I can see there is already a trim there, but unfortunately it does not get set.
We could add $form_state->setValue('shurly_base', $custom_base_url); and do away with the trim() located in the .module file. However if there is an existing site that happens to have white spaces around it, it will get screwed.
So I agree, lets move the trim inside the check/if condition.
I concur MR created.
No Sssweat → made their first commit to this issue’s fork.
Update to 3.0.4 as that version has it.
Update to 3.0.4 as that version has it.
Sounds like a bug.
I will check soon if this issue still persists in the latest version as of this writing, 3.0.4
MR created for both 3.x and 3.x-dev branches.
No Sssweat → made their first commit to this issue’s fork.
Now I am getting
Error: Call to a member function addError() on null in Drupal\elastic_email\Plugin\Mail\ElasticEmailMailSystem->elasticEmailSend() (line 218 of modules/contrib/elastic_email/src/Plugin/Mail/ElasticEmailMailSystem.php).
I just created a dummy account. If it worked correctly, I should be getting a Drupal message saying that I am not allowed to send from that domain (or something along those lines).
Feel free to use my dummy creds:
nosssweat2016@gmail.com
EAF003414250AA789448DE0DC4963AACCBBD68809BCC30A5C87F747C5DB23AB78781FDC2A2FC2336D5D96F639ED86DD4