[PHP 8] trim(): Passing null to parameter of type string is deprecated

Looking at the form validate function, I can see there is already a trim there, but unfortunately it does not get set.

We could add $form_state->setValue('shurly_base', $custom_base_url); and do away with the trim() located in the .module file. However if there is an existing site that happens to have white spaces around it, it will get screwed.

So I agree, lets move the trim inside the check/if condition.

Turns out can't add to the conditional with making the conditional significantly more complex.

So I added a 1 liner conditional before it.

MR created, please review.

Thanks `No Sssweat` -- the updated MR LGTM! Will test next week and circle back.

Confirmed (for a site that did not have shurly.settings shurly_base configured).
Deprecation warnings ceased.

It's called the null coalescing operator: https://www.tutorialspoint.com/php7https://www.tutorialspoint.com/php7/p...

jcnventura → closed merge request !9

Automatically closed - issue fixed for 2 weeks with no activity.