- Issue created by @kandugatlasantosh
- ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- Issue was unassigned.
- Status changed to Needs review
11 months ago 1:05pm 19 January 2024 - ๐จ๐ฆCanada No Sssweat
The second patch from #6 introduces
Warning undefined variable $switcher_horizontal_position and $switcher_vertical_position
$float_position = $settings->get('float_position');
Float position will never be an array and will always be a string since you can only select one. Therefore,
if(is_array($float_position)){
Is not necessary and it's introducing the undefined variables as it will never pass this check.
Use the first patch from comment #2 if anything.
I have not been able to reproduce the bug. Might want to add the steps to reproduce.
- ๐ฎ๐ณIndia mdsohaib4242
This worked for me.
// Check if $languages is an array before using array_values() $languages = $settings->get('languages'); if (is_array($languages)) { $languages = array_filter(array_values($languages), function($l) { return !empty($l); }); } else { $languages = []; }