The annotations for "edit-form" and "delete-form" of the "og_membership_type" entity type are not consistent with the actual routes.

I just commited the change on this banch https://git.drupalcode.org/issue/og-3338830/-/tree/3338830-annotations-o... on the issue fork.

Now the links annotation for the og_membership_type entity type are:

 *   links = {
 *     "edit-form" = "/admin/structure/membership-types/manage/{og_membership_type}",
 *     "delete-form" = "/admin/structure/membership-types/manage/{og_membership_type}/delete",
 *     "collection" = "/admin/structure/membership-types",
 *   }

Which are consistent with the routes which use "og_membership_type" (as opposed to "membership_type").

needed this patch to fix error when amending membership types, solved the problem

agree, patch is correct

ok I see that this one is already committed on Github several months ago, but not synced back..... also the last commtis including the alpha10 tag is not on the 8.x-1.x branch, but elsewhere.. please bring back some tidiness in the Drupal repo. This would help anyone getting in touch with OG tremendously, hence raising the chance to welcome more people helping to contribute on this project.

eg in my case, I'm currently reviewing this module in order to decide, if we can use it in the current project. Of course I'm willing help on reporting/commenting issues and contribute patches, if possible - but having to find my way through
the Git jungle of this project drastically lowers my motivation regarding this a lot

Thanks! I had exactly the same issue, patch resolved it.

I completely agree with @agoradesign comment's: Seems that moving the issues to Github kind of split the efforts and contributors, not to mention the sync back problem...