Contrib.social

Bad variable name for the "After save behavior"

Open on Drupal.org →
Created on 13 January 2023, over 1 year ago
Updated 3 February 2023, over 1 year ago

Problem/Motivation

In the settings form, the select field to manage the "After save behavior" is referenced under the name of save_behavior but in the gin_lb.module file in the gin_lb_form_redirect_submit function, the variable name checked to make the redirect is safe_behavior. As this variable safe_behavior is set to stay in the gin_lb.settings.yml it is not possible to change the behavior through the settings form.

Steps to reproduce

Proposed resolution

As this parameter is to manage the behavior after the save, I guess it is more suitable to keep to name save_behavior instead of safe_behavior.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇨🇭Switzerland jrenard

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024