πŸ‡ΊπŸ‡ΈUnited States @davidburns

Philadelphia
Account created on 3 August 2006, over 18 years ago
  • VP of Extended Support at LullabotΒ  …
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

Confirmed tested and working as expected

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

Thank you! I've added this logo.png to the 1.x and 2.x branches.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

Confirmed it only needed ^11 version support in info.yml file.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

This patch is working as expected.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

davidburns β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia
πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

Nice features added to v2. Looking forward to using them.
Thanks for the updated documentation.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

Nice addition to this module. Working as expected. Able to limit which reports each role has access to.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia
πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia
πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

This is a nice feature enhancement.
Seems to be working for me.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

D11 support, nice.
Approved.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

Code reviewed and approved.
Tested on Tugboat.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

davidburns β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

davidburns β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

Looks like this is the patch required for "menu_link_config" that will fix this fatal error.
https://www.drupal.org/project/menu_link_config/issues/3410136 πŸ› Fatal error after upgrading to Drupal 10.2 Needs review

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

davidburns β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

Thank you for adding me as a co-maintainer, merging those RTBC patches and tagging a release.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

+1 This is well thought out. Having been involved with many D9 to D10 upgrades this past year there were many times where I wished for a system just like this. Even more so when our developers provided patches that got little to no response. The fewer patches we need to include in our builds and re-roll when they become outdated would save a lot of time and be better for the community when people are evaluating Drupal contrib readiness.

I have similar questions as #4 where HEAD has significantly more changes than what's in the latest release.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

Thank you! That patch works for me.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

I connected w/ @sylturner and this was not related to any code within the module and has been fixed by the DUBBOT team.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

davidburns β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

Confirming that @edmoreta's patch in #5 is working as expected on Drupal 10.
It would be great if we could get a D10 release, even if it's marked as alpha or beta.

πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

There's an accessCheck that needs to be added to the entityQuery for email_noreply_requirements().

Fixes this error:

Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck(). in Drupal\Core\Entity\Query\Sql\Query->prepare() (line 141 of core/lib/Drupal/Core/Entity/Query/Sql/Query.php).
πŸ‡ΊπŸ‡ΈUnited States davidburns Philadelphia

Fixed a couple of other PHPCS things that popped up after applying that patch.
Here's the updated version that has everything passing.

Production build 0.71.5 2024