- Issue created by @loze
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & sqlite-3.27last update
11 months ago Waiting for branch to pass - Status changed to Needs review
11 months ago 12:42am 21 December 2023 - 🇺🇸United States loze Los Angeles
This fixes the error for me and I am able to use the site now.
- Status changed to Needs work
11 months ago 9:51pm 21 December 2023 - 🇺🇸United States loze Los Angeles
Actually after further testing, this doesn't solve the issue.
- Assigned to Anita verma
- Issue was unassigned.
- First commit to issue fork.
- Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & sqlite-3.27last update
11 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & sqlite-3.27last update
11 months ago Waiting for branch to pass - Status changed to Needs review
11 months ago 1:57pm 24 December 2023 - 🇧🇪Belgium daften
I've updated the MR with a patch that works for me. I made the MenuLinkConfig plugin independent from menu_link_content, which should also fix the todo that was still there.
It's only tested briefly, so please thoroughly. I see e.g. in the menu editing for menu link config items that the machine name is not populated, not sure if that was there before.
- 🇧🇪Belgium daften
Updating the title, this seems to be new since Drupal 10.2 specifically
- 🇨🇦Canada joelpittet Vancouver
@daften, The only change here is the interface change or did you both run into other changes needed?
This seems like the only change needed to fix this problem:
- public function getEntity() { + public function getEntity(): MenuLinkConfigInterface {
Alternatively you could change to the decorator instead of extending and avoid these kind of bugs. Would that be an OK direction for this issue?
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & sqlite-3.27last update
10 months ago Waiting for branch to pass - 🇨🇦Canada joelpittet Vancouver
I am just going to RTBC this as it's a fatal and up the priority
- Status changed to RTBC
4 months ago 12:06am 17 July 2024 - 🇨🇦Canada joelpittet Vancouver
The patch in #11 seems to be just the MR in patch form