- Issue created by @samit.310@gmail.com
- Status changed to Needs review
over 1 year ago 9:53am 15 March 2023 - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 9:11am 16 March 2023 - š®š¹Italy apaderno Brescia, š®š¹
- $page = $this->getSession()->getPage(); + // $page = $this->getSession()->getPage();
If a line is initializing a variable that is never used, that line needs to be removed, not commented out.
Also, the variable could be not necessary, but$this->getSession()->getPage()
could still be necessary. Has that been checked? - Status changed to Needs review
over 1 year ago 3:27am 13 May 2023 - last update
over 1 year ago 5 pass - š®š³India chaitanyadessai Goa
Adding patch and interdiff file, please review
- Status changed to Needs work
4 months ago 12:10am 23 July 2024 Hi @everyone,
The patch @chaitanyadessai provided confirmed removed the unused variable as raised by comment #5, but one error were still reported that needs to be fixed. Please see below:
readmore_extrafield git:(3.1.x) curl https://www.drupal.org/files/issues/2023-05-13/3348047-6.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1440 100 1440 0 0 5198 0 --:--:-- --:--:-- --:--:-- 5373 patching file src/Plugin/ExtraField/Display/ReadmoreExtrafield.php patching file tests/src/FunctionalJavascript/ReadMoreExtraFieldFunctionalJavascriptTest.php ā readmore_extrafield git:(3.1.x) ā cd .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig readmore_extrafield FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/readmore_extrafield/src/Plugin/ExtraField/Display/ReadmoreExtrafield.php ---------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Url. ---------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------- Time: 221ms; Memory: 10MB
Kindly check
Thanks,
Jake- Status changed to Needs review
4 months ago 6:11am 23 July 2024 - First commit to issue fork.
- Status changed to RTBC
4 months ago 11:42pm 23 July 2024 Hi @chaitanyadessai,
The patch you provided did fix the errors.
readmore_extrafield git:(3.1.x) ā curl https://www.drupal.org/files/issues/2024-07-23/3348047-8.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1603 100 1603 0 0 6515 0 --:--:-- --:--:-- --:--:-- 6735 patching file src/Plugin/ExtraField/Display/ReadmoreExtrafield.php patching file tests/src/FunctionalJavascript/ReadMoreExtraFieldFunctionalJavascriptTest.php ā readmore_extrafield git:(3.1.x) ā cd .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig readmore_extrafield ā contrib git:(master) ā
Will now move this to RTBC
Thanks,
Jake- Status changed to Needs work
4 months ago 3:46pm 24 July 2024 - š®š¹Italy apaderno Brescia, š®š¹
Let's create a merge request, now that patches are no longer tested.
- Status changed to Needs review
4 months ago 4:12pm 24 July 2024