Fix the issues reported by phpcs

Open on Drupal.org →

Created on 15 March 2023, over 1 year ago

Updated 13 May 2023, about 1 year ago

Problem/Motivation

Getting following warnings.

FILE: /var/www/html/modules/contrib/readmore_extrafield/tests/src/FunctionalJavascript/ReadMoreExtraFieldFunctionalJavascriptTest.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
129 | WARNING | Unused variable $page.
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/readmore_extrafield/src/Plugin/ExtraField/Display/ReadmoreExtrafield.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
9 | WARNING | [x] Unused use statement
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------

Time: 1.86 secs; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/readmore_extrafield/

Proposed resolution

Above warnings need to be fixed.

📌 Task

Status

Needs review

Version

3.1

Component

Code

Created by

🇮🇳India samit.310@gmail.com

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Issue created by @samit.310@gmail.com
Comment over 1 year ago →
🇮🇳India samit.310@gmail.com
Above warnings has been fixed.
Comment over 1 year ago →
🇮🇳India rajneeshb New Delhi
Reviewed patch #2 LGTM, all reported issue fixed. +1RTBC

Attaching SS for reference.
Status changed to Needs review over 1 year ago9:53am 15 March 2023
Comment over 1 year ago →
🇮🇳India samit.310@gmail.com
Issue was unassigned.
Status changed to Needs work over 1 year ago9:11am 16 March 2023
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
- $page = $this->getSession()->getPage(); + // $page = $this->getSession()->getPage();
If a line is initializing a variable that is never used, that line needs to be removed, not commented out.
Also, the variable could be not necessary, but $this->getSession()->getPage() could still be necessary. Has that been checked?
Status changed to Needs review about 1 year ago3:27am 13 May 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
5 pass
Comment about 1 year ago →
🇮🇳India chaitanyadessai
Adding patch and interdiff file, please review

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024