- Issue created by @daffie
- Merge request !9581Changed the filter functionality to a condition object β (Open) created by daffie
- π¦π·Argentina dagmar Argentina
Thanks, looks good to me as well.
The method
addFilterToQuery(Request $request, SelectInterface &$query)
needs some documentation updates. The return type is not properly documented. - First commit to issue fork.
- π³π±Netherlands daffie
The wrong return value and type hint for the method DbLogController::addFilterToQuery() has been adressed.
@dagmar & @rajneeshb: Thanks!
- πΊπΈUnited States smustgrave
Left small comments on the MR
Searching the repo only see about 20 functions that document return void.
- π³π±Netherlands daffie
Removed the return void from the docblock as requested.
BTW: I get over 20 hits when I do a search for
@return void
in the code base. - π³πΏNew Zealand quietone
I read the IS, comments and the MR. I didn't spot any problems here.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Left a question on the MR