- ๐ฎ๐ณIndia Charchil Khandelwal
The patch #5 has been reviewed and applied cleanly, but a few phpcs still remain.
FILE: C:\xampp\htdocs\abc\drupal\modules\profile\README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------
47 | WARNING | Line exceeds 80 characters; contains 194 characters
48 | WARNING | Line exceeds 80 characters; contains 146 characters
49 | WARNING | Line exceeds 80 characters; contains 117 characters
53 | WARNING | Line exceeds 80 characters; contains 158 characters
55 | WARNING | Line exceeds 80 characters; contains 101 characters
56 | WARNING | Line exceeds 80 characters; contains 120 characters
---------------------------------------------------------------------- - @charchil-khandelwal opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:16pm 23 January 2023 - ๐ฎ๐ณIndia rajneeshb New Delhi
Reviewed MR !15 all coding standard issues fixed. Also the readme.md file warning also fixed.
- Status changed to RTBC
over 1 year ago 6:05am 21 March 2023 - ๐ฎ๐ณIndia arunkumark Coimbatore
The MR !15 applied cleanly and resolve all the PHPCS issue for the module. Moving to RTBC.
- Status changed to Needs work
over 1 year ago 9:02am 21 March 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ use StringTranslationTrait; /** * Profile entity storage.
The must be an empty line after
use StringTranslationTrait;
which is missing. - Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:50am 21 March 2023 - ๐ฎ๐ณIndia Nayana Ramakrishnan
nayana_mvr โ made their first commit to this issueโs fork.
- @nayana_mvr opened merge request.
- ๐ฎ๐ณIndia Nayana Ramakrishnan
Verified the patch #14. The patch applied with a warning message:
3328568-14.patch:108: trailing whitespace. Checking patch src/Entity/Profile.php... Checking patch src/Form/ProfileTypeForm.php... Checking patch src/Plugin/Field/FieldWidget/ProfileFormWidget.php... Checking patch tests/src/Functional/ProfileDefaultTest.php... Checking patch tests/src/Functional/ProfileRegisterFormTest.php... Checking patch tests/src/Functional/ProfileTypeTest.php... Applied patch src/Entity/Profile.php cleanly. Applied patch src/Form/ProfileTypeForm.php cleanly. Applied patch src/Plugin/Field/FieldWidget/ProfileFormWidget.php cleanly. Applied patch tests/src/Functional/ProfileDefaultTest.php cleanly. Applied patch tests/src/Functional/ProfileRegisterFormTest.php cleanly. Applied patch tests/src/Functional/ProfileTypeTest.php cleanly. warning: 1 line adds whitespace errors.
Also, the warnings related to README.md file was not there in the patch. So I have fixed the above warning and the warnings in the README file and created a new MR. Please review. Thanks.
- ๐ฎ๐ณIndia rajneeshb New Delhi
Reviewd MR 19 looks good. +1 for RTBC, Attaching screenshots for reference.
- Status changed to RTBC
11 months ago 1:29pm 21 July 2023 - ๐ต๐ญPhilippines roberttabigue
Hi,
I applied the latest MR to the Profile module against 8.x-1.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig profile/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
- Status changed to Needs work
11 months ago 6:13pm 21 July 2023 - First commit to issue fork.
- last update
11 months ago 23 pass - Status changed to Needs review
11 months ago 12:44pm 22 July 2023 - Status changed to Needs work
11 months ago 2:18pm 25 July 2023 - ๐ต๐ญPhilippines roberttabigue
Hi @MukhtarM,
I reviewed your latest changes and after applying MR !19, there are new warnings found.
Please see the attached file for reference.
Moving this to Needs work for now for investigation.
Thank you!
- ๐ฎ๐ณIndia MukhtarM
hi @roberttabigue ohh actually it needs to not use either "t()" or "$this->t()" there in the tests.
Its mentioned in the comment: #20 ๐ Fix the issues reported by phpcs Needs work
I will correct this in the MR.
refer this too: https://drupal.stackexchange.com/questions/258535/should-i-translate-str... - last update
11 months ago 16 pass, 6 fail - last update
11 months ago 17 pass, 4 fail