Phpcs Drupal coding standard issue

Created on 14 February 2023, almost 2 years ago
Updated 10 January 2024, 11 months ago

FILE: /var/www/html/contribution/web/modules/contrib/ephoto_dam/src/Plugin/Filter/EphotoDam.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
50 | WARNING | Possible useless method overriding detected
-----------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/ephoto_dam/src/Form/ConfigurationForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
57 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/ephoto_dam/README.md
-------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 89 characters
-------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/ephoto_dam/ephoto_dam.module
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------
86 | WARNING | [x] A comma should follow the last multiline array item. Found: 'status'
172 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/ephoto_dam/modules/ephoto_dam_field/src/Plugin/Validation/Constraint/EphotoDamFieldConstraintValidator.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------
38 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/ephoto_dam/modules/ephoto_dam_field/src/Plugin/Field/FieldType/EphotoDamField.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
39 | WARNING | Possible useless method overriding detected
129 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
130 | WARNING | Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders
140 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
143 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/ephoto_dam/modules/ephoto_dam_field/src/Plugin/Field/FieldFormatter/EphotoDamFieldFormatter.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
42 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/ephoto_dam/modules/ephoto_dam_field/src/Plugin/Field/FieldWidget/EphotoDamFieldWidget.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 9 WARNINGS AFFECTING 13 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
49 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
74 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
75 | ERROR | [x] Use null coalesce operator instead of ternary operator.
87 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
109 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
110 | ERROR | [x] Use null coalesce operator instead of ternary operator.
132 | ERROR | [x] Use null coalesce operator instead of ternary operator.
138 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
158 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
161 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
177 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
206 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
207 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/contribution/web/modules/contrib/ephoto_dam/modules/ephoto_dam_field/ephoto_dam_field.install
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] When importing a class with "use", do not include a leading \
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------

📌 Task
Status

Fixed

Version

3.15

Component

Code

Created by

🇮🇳India himanshu_jhaloya Indore

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @himanshu_jhaloya
  • Merge request !2fiexed the isses → (Closed) created by himanshu_jhaloya
  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • Status changed to Needs work almost 2 years ago
  • 🇮🇳India rajneeshb New Delhi

    Reviewed MR !2 there are still some coding standard issues

    FILE: /ephoto_dam/modules/ephoto_dam_field/src/Plugin/Field/FieldType/EphotoDamField.php
    -----------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------------------
    39 | WARNING | Possible useless method overriding detected
    -----------------------------------------------------------------------------------------------------------------------------

    FILE: /ephoto_dam/modules/ephoto_dam_field/src/Plugin/Field/FieldFormatter/EphotoDamFieldFormatter.php
    -------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------------------
    42 | WARNING | Possible useless method overriding detected
    -------------------------------------------------------------------------------------------------------------------------------------------

    FILE: /ephoto_dam/src/Plugin/Filter/EphotoDam.php
    --------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------------
    50 | WARNING | Possible useless method overriding detected
    --------------------------------------------------------------------------------------

  • Status changed to Needs review almost 2 years ago
  • Status changed to Fixed 11 months ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024