Fix the issues reported by phpcs

Created an MR

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.

Reviewed MR !2, attaching screenshots for reference, Looks good to me

silvi.addweb → made their first commit to this issue’s fork.

Fixed the mentioned errors.

FILE: /home/addweb/patches/simple_zoom-2955180/src/Plugin/Field/FieldFormatter/ZoomImageFormatter.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------


FILE: /home/addweb/patches/simple_zoom-2955180/simple_zoom.module
--------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Unicode.
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: /home/addweb/patches/simple_zoom-2955180/zoom_inline/src/Plugin/CKEditorPlugin/DrupalInlineImageZoom.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\ckeditor\CKEditorPluginInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------


FILE: /home/addweb/patches/simple_zoom-2955180/zoom_inline/zoom_inline.module
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------

Hi @silvi.addweb,

I applied MR!2 and it was applied smoothly. These are the issues remaining after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.

➜  simple_zoom git:(heads/8.x-2.x) curl https://git.drupalcode.org/project/simple_zoom/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6026    0  6026    0     0  14089      0 --:--:-- --:--:-- --:--:-- 14112
patching file README.txt
patching file css/zoom.css
patching file simple_zoom.module
patching file src/Plugin/Field/FieldFormatter/ZoomImageFormatter.php
patching file zoom_inline/src/Plugin/CKEditorPlugin/DrupalInlineImageZoom.php
patching file zoom_inline/zoom_inline.info.yml
patching file zoom_inline/zoom_inline.module
➜  simple_zoom git:(heads/8.x-2.x) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml simple_zoom

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/simple_zoom/simple_zoom.info.yml
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/simple_zoom/zoom_inline/zoom_inline.info.yml
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------------

Time: 174ms; Memory: 10MB

➜  contrib

Thank you.

MR !2 fixed all the PHP_CodeSniffer warnings/errors reported by GitLAb CI.

apaderno → changed the visibility of the branch 2955180-gitlab-ci-reports to hidden.

Hi @apaderno,

I applied MR!2 and it was applied smoothly. However, I still encountered some issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.

➜  simple_zoom git:(heads/8.x-2.x) curl https://git.drupalcode.org/project/simple_zoom/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7846    0  7846    0     0  12755      0 --:--:-- --:--:-- --:--:-- 12778
patching file .gitlab-ci.yml
patching file README.txt
patching file css/zoom.css
patching file simple_zoom.module
patching file src/Plugin/Field/FieldFormatter/ZoomImageFormatter.php
patching file zoom_inline/src/Plugin/CKEditorPlugin/DrupalInlineImageZoom.php
patching file zoom_inline/zoom_inline.info.yml
patching file zoom_inline/zoom_inline.module
➜  simple_zoom git:(heads/8.x-2.x) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml simple_zoom

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/simple_zoom/simple_zoom.info.yml
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/simple_zoom/zoom_inline/zoom_inline.info.yml
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------------

Time: 424ms; Memory: 10MB

Please check and advise.
Thank you.

There is no need to test a merge request locally: GitLab CI shows PHP_CodeSniffer errors/warnings, if they are not all resolved.

In this case, MR! 2 fixed all the PHP_CodeSniffer errors/warnings reported by PHP_CodeSniffer.