Cannot expand toolbar items referencing "<nolink>" or with options "_no_path"

Verified the patch #16 🐛 Cannot expand toolbar items referencing "" or with options "_no_path" Needs work manually on Drupal 10.0.7. The patch was applied cleanly and worked as expected.

Attached is a screenshot after applying the patch.

Applying Patch:

After Applying Patch:

Setting status to needs review, still needs tests to be written

#16 failed to apply

Issue summary should be updated with the definitive proposed solution.

As mentioned tests are still needed.

Updating the patch #16 as it failed to apply. the patch solves the issue. Updating the issue summery with proposed resolution.

Rerolled the patch from #21 to apply to 10.2.7.

The patch seems to fix the issue.

Thanks everyone for the help!

Hello,

The latest patch #23 seems to break CSS aggregation for me.

It is missing a "-" character at this place :

Rerolled patch #23 with the previous bug fixed

I've created a MR that applies the patch in #26 (after checking: issue still exists, patch still applies, patch fixes the issue).

Can anybody please confirm that this needs test coverage? I cannot find any existing tests that verify if the expand functionality works for normal links, so it seems a bit odd to write a test only for <nolink> items. Thanks!

Hello, i have tested this and have few observations as below.
I added a menu item with and set to expanded and added a sub item below it - After applying the MR the expand collapse functionality worked fine.
The patch 26 fails to apply so styling could not be checked.

Next, I also checked by adding menu item with a normal link, and set to expanded and added a sub item below it and checked, the menu item is not correctly show.

Added screenshots for reference.

Definitely think we would still need test coverage. Can almost say if we had test coverage before this bug may not have popped up.