🇫🇷France @yonailo

Hello,

Tu sum it up, what is the current best practice for creating an HTML tile with for exemple H0 ?

Rerolled patch #23 with the previous bug fixed

It is missing a "-" character at this place :

Hello,

The latest patch #23 seems to break CSS aggregation for me.

Oh sorry, it was my fault, I was applying this patch ( https://www.drupal.org/files/issues/2024-06-13/3198565-23.patch → ), from https://www.drupal.org/node/3198565 → , and it was causing this error.

Thank you for your time.

I don't either understand. I don't know why, even after deleting web/core and reinstalling, my site has this :

 /**
  * Toolbar bar.
  */
 .toolbar .toolbar-bar {
   color: #ddd;
   background-color: #0f0f0f;
-  box-shadow: -1px 0 3px 1px rgba(0, 0, 0, 0.3333); /* LTR */
+  box-shadow: -1px 0 3px 1px rgba(0, 0, 0, 0.3333);
+  /* LTR */
 }

When the comment /* LTR */ is on the same line as box-shadow, the issue happens.

yonailo → created an issue.

Yes #8 works for me too (I am running Drupal 10.3.0)

Yes I am using "editor_advanced_link" module too, so does this mean that we should open an issue in "editor_advanced_link" in order to the preprocess: false to be removed ?

I am hitting this issue too, the patch of issue 3439536 🐛 Exposed filters aggregation (regression?) Active does not fix it.

As stated in the original PR, the issue appears when using a pager.

The fix committed as well as patch #9 don't work for me, the only thing that works is patch #2, I don't know why.

Hello,

I am trying to test this patch using an Umami installation of Drupal 10.3, but I've got errors when attempting to translate an article page ? Does anybody else has tried to test this with Umami ? Previous comments seem to suggest that the patch works so I don't quite understand.

Thank you in advance.

yonailo → created an issue.

Patch #39 works for me, but not patch #40

Oh thank you !! I didn’t know that it has to work like that ….

Is there any documentation about this ? Or an example theme or something that would allow me to see how each component can be configured ?

Thank you again for your support

yonailo → created an issue.

yonailo → created an issue.

Hello,

When I apply your patch to the current dev version, it is applied correctly but then when visiting a page I get this error message :

Error: Call to undefined method Drupal\forward\Services\ForwardFormBuilder::buildForwardEntityForm() in forward_entity_view() (line 195 of modules/contrib/forward/forward.module).

+1

yonailo → created an issue.

I am seeing duplicate "&page" parameters when we use the pagination of the media library widget, I think

    if ($query->has('page')) {
      $query->remove('page');
    }

woud be needed as it has recently been done with "ajax_page_state" .... I dont understand why the grabbing of all the query string parameters is done here :(

Does anybody know why the order has been changed without a change record ?

Thank you for your patch @viren18febS, it fixes an issue with z-index + library media widget in our case.

We are experiencing an issue with z-index in the media library widget related to this CSS sorting change.

It seems that https://www.drupal.org/project/drupal/issues/3396505 🐛 Improved Drupal\Core\Ajax\AddCssCommand causes change in CSS load order. Needs work fixes our issue.

Hope this helps.

We have applied the patch #21 🐛 Ensure that edge caches are busted on deployments for css/js aggregates Fixed , as we want to regenerate all hashes with drush at deployment.

Well … if this is the new way of working …we can remove all our version keys, it is definitely feasible … but we used to use the versions keys to track the version of the library (specially when it is external)…

We were using the contrib module advagg under D9 and we didn’t have to proceed like this… I have been a bit surprised when discovering this issue…

I’ve always thought that the version key was merely informative but I was wrong. I understand that the way Drupal10 works now is correct and coherent so we will try to adapt to it.

Moreover, we can continue using versions… we just need to be careful and not forget incrementing them when we make a modification.

Thank you all for your support and all your explanations in this thread ! ^^

Do you know why the tests are not ok ?

I have stumbled upon this issue and I would like to apply this patch, it is not very beautiful to have status-messages twice...

I don't understand how this commit helps with the deployment process.

We have a webfactory which handles over 20 components, that means +20 drupal libraries.

Our developers apply changes to those libraries quite often, and we deliver those modifications to production once a week.

Does this solution mean that we have to remove all "version" keys of all our libraries to ensure that any change will be reflected in production ?

I would rather have implemented the solution with "css_js_query_string" as in #50 🐛 Ensure that edge caches are busted on deployments for css/js aggregates Fixed

yonailo → created an issue.

Does anybody know when there will be a stable D10 compatible release ?

We currenly can not move forward to D10 because of this module only.

Thanks in advance.

Great patch !

I have used it to create a 5 columns equal layout of 20% using "flex flex flex flex flex".

Thank you very much, I hope this will be commited !!

yonailo → created an issue.

+1 to be RTBC

yes it works, when will this patch go into the official release ?, it is marked as Major and I think it is important enough to make it into the next 7.36 release...

@jakeg: thanks for fixing up the documentation, it was really important IMHO and I have experienced this headache so I totally agree with #18