- Issue created by @21kPiyush
- Open on Drupal.org โCore: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - @21kpiyush opened merge request.
- ๐ฎ๐ณIndia sahil.goyal
sahil.goyal โ made their first commit to this issueโs fork.
- @sahilgoyal opened merge request.
- Status changed to Needs review
over 1 year ago 6:56am 17 July 2023 - ๐ฎ๐ณIndia sahil.goyal
Hi @21kPiyush Thanx for the MR, MR!8 is no doubt resolving the issue by adding the is_object condition, you ensure that the dispatch method is only called when the $event variable is indeed an object, But we can opt other approach as Symfony5/6 enforce the new syntax and needed for D10 Compatibility as well, So i created a MR !9 by updating the argument as needed and it also resolving the issue and functionally works as expected, Please Review.
Also Updating the Issue Summary for steps to reproduce.
- ๐ฎ๐ณIndia keshavv India
keshav.k โ made their first commit to this issueโs fork.
- Open on Drupal.org โCore: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - ๐ฎ๐ณIndia keshavv India
@sahil.goyal
The changes that you added in MR ! 9 are already there in the 3. x branch.
The MR ! 8 Looks good to me the only change is, We need to swap the arguments. We need an object argument first in the dispatch method according to Drupal 10.
I have added that. We can process it with MR !8
Please review.
Thank you! - Open on Drupal.org โCore: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass -
rcodina โ
committed 207660f9 on 3.x authored by
21kPiyush โ
Issue #3374653: ($event) must be of type object
-
rcodina โ
committed 207660f9 on 3.x authored by
21kPiyush โ
- ๐ช๐ธSpain rcodina Barcelona
I'm sorry @keshav.k, I approved the MR but it seems that there is no attribution for you.
- Status changed to Fixed
over 1 year ago 6:07pm 18 July 2023 - ๐ช๐ธSpain rcodina Barcelona
@keshav.k I try to compensate with the commit which updates the CHANGELOG about this issue.
-
rcodina โ
committed fe44f227 on 3.x authored by
keshav.k โ
Issue #3374653 by 21kPiyush, keshav.k, rcodina: ($event) must be of type...
-
rcodina โ
committed fe44f227 on 3.x authored by
keshav.k โ
Automatically closed - issue fixed for 2 weeks with no activity.