- Issue created by @VladimirAus
- @vladimiraus opened merge request.
- 🇮🇳India Akram Khan Cuttack, Odisha
Added updated patch and fix some PHPCS issue
- 🇦🇺Australia VladimirAus Brisbane, Australia
Thanks @Akram Khan
Please push to the MR. - Status changed to Needs review
over 1 year ago 9:11am 5 April 2023 - 🇦🇺Australia VladimirAus Brisbane, Australia
Fixed
FILE: /Users/tesboss/_PROJECTS/drupal/multiupload_filefield_widget/multiupload_filefield_widget.info ---------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------- 8 | ERROR | It's only necessary to declare files[] if they declare a class or interface. ----------------------------------------------------------------------------------------------------
Everything else looks good.
- Status changed to RTBC
over 1 year ago 1:06pm 5 April 2023 -
VladimirAus →
committed 4f9a3073 on 7.x-1.x authored by
sahil.goyal →
Issue #3344612 by VladimirAus, sahil.goyal, Akram Khan: Fix the issues...
-
VladimirAus →
committed 4f9a3073 on 7.x-1.x authored by
sahil.goyal →
- Status changed to Fixed
over 1 year ago 1:12pm 5 April 2023 - Status changed to Needs work
over 1 year ago 1:43am 6 April 2023 - 🇨🇦Canada leducdubleuet Chicoutimi QC
The mfw_managed_file_value function name change to multiupload_filefield_widget_mfw_managed_file_value breaks fields using Multiupload Imagefield Widget from module : https://www.drupal.org/project/multiupload_imagefield_widget →
Do you need a new issue for that?
- Status changed to Postponed: needs info
over 1 year ago 3:44pm 7 April 2023 - 🇦🇺Australia VladimirAus Brisbane, Australia
@LeDucDuBleuet Sounds like your PHP cache wasn't clean properly.
- 🇨🇦Canada leducdubleuet Chicoutimi QC
I doubled checked again and made sure all possible caches were cleaned properly and without the attached patch, both multi files and images fields produce this error :
Error: Call to undefined function mfw_managed_file_value() in mfw_field_widget_value() (line 164 of sites/all/modules/multiupload_filefield_widget/multiupload_filefield_widget.field.inc).
This error pops when trying to access the /node/add/content_type with a file or image field with multiple values enabled.
And when replacing mfw_managed_file_value by multiupload_filefield_widget_mfw_managed_file_value on line 164 of sites/all/modules/multiupload_filefield_widget/multiupload_filefield_widget.field.inc, all is working properly.
Please review the attached patch and let me know what you think?
Thank you.
- Status changed to Needs review
over 1 year ago 6:56pm 7 April 2023 - 🇨🇦Canada leducdubleuet Chicoutimi QC
An issue has been opened for this : https://www.drupal.org/project/multiupload_filefield_widget/issues/3352682 🐛 Call to undefined function mfw_managed_file_value() Fixed
So I am putting back this task to fixed and let's work on the issue over there.
- Status changed to Fixed
over 1 year ago 7:04pm 21 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.