Fix the issues reported by phpcs

FILE: /Users/tesboss/_PROJECTS/drupal/multiupload_filefield_widget/multiupload_filefield_widget.info ---------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------- 8 | ERROR | It's only necessary to declare files[] if they declare a class or interface. ---------------------------------------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/multiupload_filefield_widget/multiupload_filefield_widget.field.inc --------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------- 59 | WARNING | Line exceeds 80 characters; contains 83 characters 137 | ERROR | Missing parameter type 140 | ERROR | Return type missing for @return tag in function comment --------------------------------------------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/multiupload_filefield_widget/README.md ---------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------- 17 | WARNING | Line exceeds 80 characters; contains 91 characters ---------------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/multiupload_filefield_widget/multiupload_filefield_widget.test ---------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES ---------------------------------------------------------------------------------------------------- 8 | ERROR | Doc comment is empty 11 | WARNING | Class name must be prefixed with the project name "MultiuploadFilefieldWidget" 13 | ERROR | Doc comment is empty 24 | ERROR | Doc comment is empty 31 | ERROR | Doc comment is empty 44 | ERROR | Doc comment is empty ---------------------------------------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/multiupload_filefield_widget/multiupload_filefield_widget.module ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 13 ERRORS AFFECTING 13 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 60 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "mfw_managed_file_process" but expected | | "multiupload_filefield_widget_mfw_managed_file_process" 85 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "mfw_managed_file_value" but expected | | "multiupload_filefield_widget_mfw_managed_file_value" 153 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 157 | ERROR | Missing parameter type 160 | ERROR | Return type missing for @return tag in function comment 164 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "mfw_managed_file_save_upload" but expected | | "multiupload_filefield_widget_mfw_managed_file_save_upload" 213 | ERROR | Missing parameter type 215 | ERROR | Missing parameter type 217 | ERROR | Missing parameter type 226 | ERROR | Missing parameter type 230 | ERROR | Missing parameter type 237 | ERROR | Return type missing for @return tag in function comment 247 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "mfw_file_save_upload" but expected | | "multiupload_filefield_widget_mfw_file_save_upload" ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- Time: 347ms; Memory: 12MB

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Issue created by @VladimirAus
@vladimiraus opened merge request.
Comment over 1 year ago →
🇮🇳India Akram Khan Cuttack, Odisha
Added updated patch and fix some PHPCS issue
Comment over 1 year ago →
🇦🇺Australia VladimirAus Brisbane, Australia
Thanks @Akram Khan
Please push to the MR.
Status changed to Needs review about 1 year ago9:11am 5 April 2023
Comment about 1 year ago →
🇮🇳India sahil.goyal

Comment about 1 year ago →

🇦🇺Australia VladimirAus Brisbane, Australia

Fixed

FILE: /Users/tesboss/_PROJECTS/drupal/multiupload_filefield_widget/multiupload_filefield_widget.info
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
 8 | ERROR | It's only necessary to declare files[] if they declare a class or interface.
----------------------------------------------------------------------------------------------------

Everything else looks good.

Status changed to RTBC about 1 year ago1:06pm 5 April 2023
Comment about 1 year ago →
System Message
VladimirAus → closed merge request !1
Comment about 1 year ago →
System Message

VladimirAus → committed 4f9a3073 on 7.x-1.x authored by sahil.goyal →
Issue #3344612 by VladimirAus, sahil.goyal, Akram Khan: Fix the issues...
Status changed to Fixed about 1 year ago1:12pm 5 April 2023
Comment about 1 year ago →
🇦🇺Australia VladimirAus Brisbane, Australia
Thank you! Committed! 🍻
Status changed to Needs work about 1 year ago1:43am 6 April 2023
Comment about 1 year ago →
🇨🇦Canada LeDucDuBleuet Chicoutimi QC
The mfw_managed_file_value function name change to multiupload_filefield_widget_mfw_managed_file_value breaks fields using Multiupload Imagefield Widget from module : https://www.drupal.org/project/multiupload_imagefield_widget →

Do you need a new issue for that?
Status changed to Postponed: needs info about 1 year ago3:44pm 7 April 2023
Comment about 1 year ago →
🇦🇺Australia VladimirAus Brisbane, Australia
@LeDucDuBleuet Sounds like your PHP cache wasn't clean properly.
Comment about 1 year ago →
🇨🇦Canada LeDucDuBleuet Chicoutimi QC
I doubled checked again and made sure all possible caches were cleaned properly and without the attached patch, both multi files and images fields produce this error :

Error: Call to undefined function mfw_managed_file_value() in mfw_field_widget_value() (line 164 of sites/all/modules/multiupload_filefield_widget/multiupload_filefield_widget.field.inc).

This error pops when trying to access the /node/add/content_type with a file or image field with multiple values enabled.

And when replacing mfw_managed_file_value by multiupload_filefield_widget_mfw_managed_file_value on line 164 of sites/all/modules/multiupload_filefield_widget/multiupload_filefield_widget.field.inc, all is working properly.

Please review the attached patch and let me know what you think?

Thank you.
Status changed to Needs review about 1 year ago6:56pm 7 April 2023
Comment about 1 year ago →
🇨🇦Canada LeDucDuBleuet Chicoutimi QC
Comment about 1 year ago →
🇨🇦Canada LeDucDuBleuet Chicoutimi QC
An issue has been opened for this : https://www.drupal.org/project/multiupload_filefield_widget/issues/3352682 🐛 Call to undefined function mfw_managed_file_value() Fixed

So I am putting back this task to fixed and let's work on the issue over there.
Status changed to Fixed about 1 year ago7:04pm 21 April 2023
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.